Netdev Archive on lore.kernel.org
 help / color / Atom feed
* Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
@ 2019-06-13 17:53 Nathan Huckleberry
  2019-06-18  6:39 ` Maxime Chevallier
  0 siblings, 1 reply; 9+ messages in thread
From: Nathan Huckleberry @ 2019-06-13 17:53 UTC (permalink / raw)
  To: maxime.chevallier, davem; +Cc: netdev, clang-built-linux

Hey all,

I'm looking into cleaning up ignored warnings in the kernel so we can
remove compiler flags to ignore warnings.

There's an unused variable 'mvpp2_dbgfs_prs_pmap_fops' in
mvpp2_debugfs.c. It looks like this code is for dumping useful
information into userspace. I'd like to either remove the variable or
dump it to userspace in the same way the other variables are.

Wanted to reach out for opinions on the best course of action before
submitting a patch.

https://github.com/ClangBuiltLinux/linux/issues/529

Thanks,
Nathan Huckleberry

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
  2019-06-13 17:53 Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c Nathan Huckleberry
@ 2019-06-18  6:39 ` Maxime Chevallier
  2019-06-18 16:09   ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
  0 siblings, 1 reply; 9+ messages in thread
From: Maxime Chevallier @ 2019-06-18  6:39 UTC (permalink / raw)
  To: Nathan Huckleberry; +Cc: davem, netdev, clang-built-linux

Hello Nathan,

On Thu, 13 Jun 2019 10:53:05 -0700
Nathan Huckleberry <nhuck@google.com> wrote:

>Hey all,
>
>I'm looking into cleaning up ignored warnings in the kernel so we can
>remove compiler flags to ignore warnings.
>
>There's an unused variable 'mvpp2_dbgfs_prs_pmap_fops' in
>mvpp2_debugfs.c. It looks like this code is for dumping useful
>information into userspace. I'd like to either remove the variable or
>dump it to userspace in the same way the other variables are.

Thanks for reporting this.

The ops should actually be used, fixing the warning should be as simple
as adding this into mvpp2_dbgfs_prs_entry_init :

+       debugfs_create_file("pmap", 0444, prs_entry_dir, entry,
+                           &mvpp2_dbgfs_prs_pmap_fops);
+

>Wanted to reach out for opinions on the best course of action before
>submitting a patch.

Can you submit a patch, or do you prefer me to do it ?

Thanks,

Maxime

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH] net: mvpp2: cls: Add pmap to fs dump
  2019-06-18  6:39 ` Maxime Chevallier
@ 2019-06-18 16:09   ` Nathan Huckleberry
  2019-06-18 19:00     ` Nick Desaulniers
                       ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Nathan Huckleberry @ 2019-06-18 16:09 UTC (permalink / raw)
  To: davem, maxime.chevallier
  Cc: netdev, linux-kernel, Nathan Huckleberry, clang-built-linux

There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
Added a usage consistent with other fops to dump pmap
to userspace.

Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/529
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
index 0ee39ea47b6b..55947bc63cfd 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
@@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent,
 	debugfs_create_file("hits", 0444, prs_entry_dir, entry,
 			    &mvpp2_dbgfs_prs_hits_fops);
 
+	ddebugfs_create_file("pmap", 0444, prs_entry_dir, entry,
+			     &mvpp2_dbgfs_prs_pmap_fops);
+
 	return 0;
 }
 
-- 
2.22.0.410.gd8fdbe21b5-goog


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump
  2019-06-18 16:09   ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
@ 2019-06-18 19:00     ` Nick Desaulniers
  2019-06-19  2:33     ` David Miller
  2019-06-19  6:49     ` Maxime Chevallier
  2 siblings, 0 replies; 9+ messages in thread
From: Nick Desaulniers @ 2019-06-18 19:00 UTC (permalink / raw)
  To: Nathan Huckleberry
  Cc: David S. Miller, maxime.chevallier, netdev, LKML, clang-built-linux

On Tue, Jun 18, 2019 at 9:09 AM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
> Added a usage consistent with other fops to dump pmap
> to userspace.
>
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/529
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>

Looks good to me based on Maxime's suggestion.  Thanks for seeking
clarification and following up on the feedback.
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Nathan, you should use Suggested-by tags (liberally, IMO) when your
patch is based on feedback from others, in this case:
Suggested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>

> ---
>  drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> index 0ee39ea47b6b..55947bc63cfd 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent,
>         debugfs_create_file("hits", 0444, prs_entry_dir, entry,
>                             &mvpp2_dbgfs_prs_hits_fops);
>
> +       ddebugfs_create_file("pmap", 0444, prs_entry_dir, entry,
> +                            &mvpp2_dbgfs_prs_pmap_fops);
> +

-- 
Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump
  2019-06-18 16:09   ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
  2019-06-18 19:00     ` Nick Desaulniers
@ 2019-06-19  2:33     ` David Miller
  2019-06-19  6:49     ` Maxime Chevallier
  2 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2019-06-19  2:33 UTC (permalink / raw)
  To: nhuck; +Cc: maxime.chevallier, netdev, linux-kernel, clang-built-linux

From: Nathan Huckleberry <nhuck@google.com>
Date: Tue, 18 Jun 2019 09:09:10 -0700

> +	ddebugfs_create_file("pmap", 0444, prs_entry_dir, entry,

drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c: In function ¡mvpp2_dbgfs_prs_entry_init¢:
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c:569:2: error: implicit declaration of function ¡ddebugfs_create_file¢; did you mean ¡debugfs_create_file¢? [-Werror=implicit-function-declaration]

This doesn't compile, did you build test this?

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump
  2019-06-18 16:09   ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
  2019-06-18 19:00     ` Nick Desaulniers
  2019-06-19  2:33     ` David Miller
@ 2019-06-19  6:49     ` Maxime Chevallier
  2019-06-19 18:17       ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
  2 siblings, 1 reply; 9+ messages in thread
From: Maxime Chevallier @ 2019-06-19  6:49 UTC (permalink / raw)
  To: Nathan Huckleberry; +Cc: davem, netdev, linux-kernel, clang-built-linux

Hello Nathan,

On Tue, 18 Jun 2019 09:09:10 -0700
Nathan Huckleberry <nhuck@google.com> wrote:

>There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
>Added a usage consistent with other fops to dump pmap
>to userspace.

Thanks for sending a fix. Besides the typo preventing your patch from
compiling, you should also prefix the patch by "net: mvpp2: debugfs:"
rather than "cls", which is used for classifier patches.

Thanks,

Maxime

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [PATCH v2] net: mvpp2: debugfs: Add pmap to fs dump
  2019-06-19  6:49     ` Maxime Chevallier
@ 2019-06-19 18:17       ` " Nathan Huckleberry
  2019-06-19 20:46         ` Nick Desaulniers
  2019-06-19 21:20         ` David Miller
  0 siblings, 2 replies; 9+ messages in thread
From: Nathan Huckleberry @ 2019-06-19 18:17 UTC (permalink / raw)
  To: davem, maxime.chevallier
  Cc: netdev, linux-kernel, Nathan Huckleberry, clang-built-linux

There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
Added a usage consistent with other fops to dump pmap
to userspace.

Cc: clang-built-linux@googlegroups.com
Link: https://github.com/ClangBuiltLinux/linux/issues/529
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
---
Changes from v1 -> v2
* Fix typo
* Change commit prefix to debugfs
 drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
index 0ee39ea47b6b..274fb07362cb 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
@@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent,
 	debugfs_create_file("hits", 0444, prs_entry_dir, entry,
 			    &mvpp2_dbgfs_prs_hits_fops);
 
+	debugfs_create_file("pmap", 0444, prs_entry_dir, entry,
+			     &mvpp2_dbgfs_prs_pmap_fops);
+
 	return 0;
 }
 
-- 
2.22.0.410.gd8fdbe21b5-goog


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] net: mvpp2: debugfs: Add pmap to fs dump
  2019-06-19 18:17       ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
@ 2019-06-19 20:46         ` Nick Desaulniers
  2019-06-19 21:20         ` David Miller
  1 sibling, 0 replies; 9+ messages in thread
From: Nick Desaulniers @ 2019-06-19 20:46 UTC (permalink / raw)
  To: Nathan Huckleberry
  Cc: David S. Miller, maxime.chevallier, netdev, LKML, clang-built-linux

On Wed, Jun 19, 2019 at 11:17 AM 'Nathan Huckleberry' via Clang Built
Linux <clang-built-linux@googlegroups.com> wrote:
>
> There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
> Added a usage consistent with other fops to dump pmap
> to userspace.

> Changes from v1 -> v2
> * Fix typo
> * Change commit prefix to debugfs

Compile-
Tested-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

Requires `make ... W=1` before the patch to observe the warning.

>  drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> index 0ee39ea47b6b..274fb07362cb 100644
> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c
> @@ -566,6 +566,9 @@ static int mvpp2_dbgfs_prs_entry_init(struct dentry *parent,
>         debugfs_create_file("hits", 0444, prs_entry_dir, entry,
>                             &mvpp2_dbgfs_prs_hits_fops);
>
> +       debugfs_create_file("pmap", 0444, prs_entry_dir, entry,
> +                            &mvpp2_dbgfs_prs_pmap_fops);
> +

Thanks,
~Nick Desaulniers

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] net: mvpp2: debugfs: Add pmap to fs dump
  2019-06-19 18:17       ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
  2019-06-19 20:46         ` Nick Desaulniers
@ 2019-06-19 21:20         ` David Miller
  1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2019-06-19 21:20 UTC (permalink / raw)
  To: nhuck; +Cc: maxime.chevallier, netdev, linux-kernel, clang-built-linux

From: Nathan Huckleberry <nhuck@google.com>
Date: Wed, 19 Jun 2019 11:17:15 -0700

> There was an unused variable 'mvpp2_dbgfs_prs_pmap_fops'
> Added a usage consistent with other fops to dump pmap
> to userspace.
> 
> Cc: clang-built-linux@googlegroups.com
> Link: https://github.com/ClangBuiltLinux/linux/issues/529
> Signed-off-by: Nathan Huckleberry <nhuck@google.com>

Applied.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-13 17:53 Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c Nathan Huckleberry
2019-06-18  6:39 ` Maxime Chevallier
2019-06-18 16:09   ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
2019-06-18 19:00     ` Nick Desaulniers
2019-06-19  2:33     ` David Miller
2019-06-19  6:49     ` Maxime Chevallier
2019-06-19 18:17       ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
2019-06-19 20:46         ` Nick Desaulniers
2019-06-19 21:20         ` David Miller

Netdev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/netdev/0 netdev/git/0.git
	git clone --mirror https://lore.kernel.org/netdev/1 netdev/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 netdev netdev/ https://lore.kernel.org/netdev \
		netdev@vger.kernel.org netdev@archiver.kernel.org
	public-inbox-index netdev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.netdev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox