From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, jiri@resnulli.us, kuniyu@amazon.com
Subject: Re: [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols
Date: Mon, 11 Mar 2024 11:38:11 -0700 [thread overview]
Message-ID: <20240311113811.4b878ddb@kernel.org> (raw)
In-Reply-To: <dce00532-d893-40c6-9ec4-df7ad3f47d7b@davidwei.uk>
On Sat, 9 Mar 2024 14:35:30 -0800 David Wei wrote:
> On 2024-03-09 10:34, Jakub Kicinski wrote:
> > There are things in linux/genetlink.h which are only used
> > under net/netlink/. Move them to a new local header.
> > A new header with just 2 externs isn't great, but alternative
> > would be to include af_netlink.h in genetlink.c which feels
> > even worse.
>
> Why is including af_netlink.h worse?
It exposes the internals of the lower layer of the protocol stack.
genetlink.c doesn't really need to know those details.
next prev parent reply other threads:[~2024-03-11 18:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 18:34 [PATCH net-next 0/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-09 18:34 ` [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols Jakub Kicinski
2024-03-09 22:35 ` David Wei
2024-03-11 18:38 ` Jakub Kicinski [this message]
2024-03-09 18:34 ` [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include Jakub Kicinski
2024-03-18 11:51 ` [ovs-dev] " Simon Horman
2024-03-09 18:34 ` [PATCH net-next 3/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-10 7:22 ` Sven Eckelmann
2024-03-11 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311113811.4b878ddb@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).