From: David Wei <dw@davidwei.uk>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
jiri@resnulli.us, kuniyu@amazon.com
Subject: Re: [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols
Date: Sat, 9 Mar 2024 14:35:30 -0800 [thread overview]
Message-ID: <dce00532-d893-40c6-9ec4-df7ad3f47d7b@davidwei.uk> (raw)
In-Reply-To: <20240309183458.3014713-2-kuba@kernel.org>
On 2024-03-09 10:34, Jakub Kicinski wrote:
> There are things in linux/genetlink.h which are only used
> under net/netlink/. Move them to a new local header.
> A new header with just 2 externs isn't great, but alternative
> would be to include af_netlink.h in genetlink.c which feels
> even worse.
Why is including af_netlink.h worse?
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kuniyu@amazon.com
> CC: jiri@resnulli.us
> ---
> include/linux/genetlink.h | 5 -----
> net/netlink/af_netlink.c | 2 +-
> net/netlink/genetlink.c | 2 ++
> net/netlink/genetlink.h | 11 +++++++++++
> 4 files changed, 14 insertions(+), 6 deletions(-)
> create mode 100644 net/netlink/genetlink.h
>
> diff --git a/include/linux/genetlink.h b/include/linux/genetlink.h
> index c285968e437a..9dbd7ba9b858 100644
> --- a/include/linux/genetlink.h
> +++ b/include/linux/genetlink.h
> @@ -4,15 +4,10 @@
>
> #include <uapi/linux/genetlink.h>
>
> -
> /* All generic netlink requests are serialized by a global lock. */
> extern void genl_lock(void);
> extern void genl_unlock(void);
>
> -/* for synchronisation between af_netlink and genetlink */
> -extern atomic_t genl_sk_destructing_cnt;
> -extern wait_queue_head_t genl_sk_destructing_waitq;
Checked these are only used in net/netlink/af_netlink.c and
net/netlink/genetlink.c
> -
> #define MODULE_ALIAS_GENL_FAMILY(family)\
> MODULE_ALIAS_NET_PF_PROTO_NAME(PF_NETLINK, NETLINK_GENERIC, "-family-" family)
>
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index da846212fb9b..621ef3d7f044 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -59,7 +59,6 @@
> #include <linux/rhashtable.h>
> #include <asm/cacheflush.h>
> #include <linux/hash.h>
> -#include <linux/genetlink.h>
> #include <linux/net_namespace.h>
> #include <linux/nospec.h>
> #include <linux/btf_ids.h>
> @@ -73,6 +72,7 @@
> #include <trace/events/netlink.h>
>
> #include "af_netlink.h"
> +#include "genetlink.h"
>
> struct listeners {
> struct rcu_head rcu;
> diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
> index 3b7666944b11..feb54c63a116 100644
> --- a/net/netlink/genetlink.c
> +++ b/net/netlink/genetlink.c
> @@ -22,6 +22,8 @@
> #include <net/sock.h>
> #include <net/genetlink.h>
>
> +#include "genetlink.h"
> +
> static DEFINE_MUTEX(genl_mutex); /* serialization of message processing */
> static DECLARE_RWSEM(cb_lock);
>
> diff --git a/net/netlink/genetlink.h b/net/netlink/genetlink.h
> new file mode 100644
> index 000000000000..89bd9d2631c3
> --- /dev/null
> +++ b/net/netlink/genetlink.h
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef __NET_GENETLINK_H
> +#define __NET_GENETLINK_H
> +
> +#include <linux/wait.h>
> +
> +/* for synchronisation between af_netlink and genetlink */
> +extern atomic_t genl_sk_destructing_cnt;
> +extern wait_queue_head_t genl_sk_destructing_waitq;
> +
> +#endif /* __LINUX_GENERIC_NETLINK_H */
next prev parent reply other threads:[~2024-03-09 22:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 18:34 [PATCH net-next 0/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-09 18:34 ` [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols Jakub Kicinski
2024-03-09 22:35 ` David Wei [this message]
2024-03-11 18:38 ` Jakub Kicinski
2024-03-09 18:34 ` [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include Jakub Kicinski
2024-03-18 11:51 ` [ovs-dev] " Simon Horman
2024-03-09 18:34 ` [PATCH net-next 3/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-10 7:22 ` Sven Eckelmann
2024-03-11 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dce00532-d893-40c6-9ec4-df7ad3f47d7b@davidwei.uk \
--to=dw@davidwei.uk \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).