Re: [PATCH net-next 3/3] genetlink: remove linux/genetlink.h

[Sven Eckelmann <sven@narfation.org>]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On Saturday, 9 March 2024 19:34:58 CET Jakub Kicinski wrote:
> genetlink.h is a shell of what used to be a combined uAPI
> and kernel header over a decade ago. It has fewer than
> 10 lines of code. Merge it into net/genetlink.h.
> In some ways it'd be better to keep the combined header
> under linux/ but it would make looking through git history
> harder.
> 
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[...]
> diff --git a/net/batman-adv/main.c b/net/batman-adv/main.c
> index 75119f1ffccc..8e0f44c71696 100644
> --- a/net/batman-adv/main.c
> +++ b/net/batman-adv/main.c
> @@ -14,7 +14,6 @@
>  #include <linux/crc32c.h>
>  #include <linux/device.h>
>  #include <linux/errno.h>
> -#include <linux/genetlink.h>
>  #include <linux/gfp.h>
>  #include <linux/if_ether.h>
>  #include <linux/if_vlan.h>
> @@ -38,6 +37,7 @@
>  #include <linux/string.h>
>  #include <linux/workqueue.h>
>  #include <net/dsfield.h>
> +#include <net/genetlink.h>
>  #include <net/rtnetlink.h>
>  #include <uapi/linux/batadv_packet.h>
>  #include <uapi/linux/batman_adv.h>
> diff --git a/net/batman-adv/netlink.c b/net/batman-adv/netlink.c
> index 0954757f0b8b..9362cd9d6f3d 100644
> --- a/net/batman-adv/netlink.c
> +++ b/net/batman-adv/netlink.c
> @@ -15,7 +15,6 @@
>  #include <linux/cache.h>
>  #include <linux/err.h>
>  #include <linux/errno.h>
> -#include <linux/genetlink.h>
>  #include <linux/gfp.h>
>  #include <linux/if_ether.h>
>  #include <linux/if_vlan.h>


Acked-by: Sven Eckelmann <sven@narfation.org>

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]