From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, dev@openvswitch.org, jiri@resnulli.us,
netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com
Subject: Re: [ovs-dev] [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include
Date: Mon, 18 Mar 2024 11:51:11 +0000 [thread overview]
Message-ID: <20240318115111.GC1623@kernel.org> (raw)
In-Reply-To: <20240309183458.3014713-3-kuba@kernel.org>
On Sat, Mar 09, 2024 at 10:34:57AM -0800, Jakub Kicinski wrote:
> The only legit reason I could think of for net/genetlink.h
> and linux/genetlink.h to be separate would be if one was
> included by other headers and we wanted to keep it lightweight.
> That is not the case, net/openvswitch/meter.h includes
> linux/genetlink.h but for no apparent reason (for struct genl_family
> perhaps? it's not necessary, types of externs do not need
> to be known).
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-03-18 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 18:34 [PATCH net-next 0/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-09 18:34 ` [PATCH net-next 1/3] netlink: create a new header for internal genetlink symbols Jakub Kicinski
2024-03-09 22:35 ` David Wei
2024-03-11 18:38 ` Jakub Kicinski
2024-03-09 18:34 ` [PATCH net-next 2/3] net: openvswitch: remove unnecessary linux/genetlink.h include Jakub Kicinski
2024-03-18 11:51 ` Simon Horman [this message]
2024-03-09 18:34 ` [PATCH net-next 3/3] genetlink: remove linux/genetlink.h Jakub Kicinski
2024-03-10 7:22 ` Sven Eckelmann
2024-03-11 10:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240318115111.GC1623@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).