netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device
@ 2012-02-13 11:20 Vasily Averin
  2012-02-13 19:09 ` Michael Chan
  0 siblings, 1 reply; 15+ messages in thread
From: Vasily Averin @ 2012-02-13 11:20 UTC (permalink / raw)
  To: Michael Chan; +Cc: netdev, Dmitry Kravkov

Michael, Dmitry,

Could you please clarify how you have fixed this issue?
I've noticed very similar problem in CentOS6.2 environment,
could you please clarify how it's possible to fix or workaround it? 

thank you,
	Vasily Averin

On 10/27/2011 at 16:30 -0700, Michael Chan wrote:
> On Wed, 2011-10-19 at 13:53 -0700, John Fastabend wrote:
>> As a reference point this works fine in both FCoE and iSCSI stacks
>> today. The device is reset or link is lost for whatever reason
>> when the link comes back up the stack logs back in, enumerates
>> the luns and the scsi stack recovers as expected.
>>
>> Firmware should do the equivalent login, lun enumeration, etc as
>> needed.
> 
> Just a quick follow-up on this issue.  Our firmware actually performs
> the same logout before the reset and login after the reset.  For iSCSI,
> the problem on our device was actually caused by our userspace daemon
> logging events to a log file in the root fs.  The file I/O was blocked
> and the daemon could not proceed to do the important operations during
> the reset, and this caused filesystem I/O errors.  We have now fixed the
> problem in the userspace daemon.
> 
> For FCoE, there is no logging issue and the root fs failure seems to
> happen only in a multipath configuration with all paths going down for a
> short time (caused by reset in this case).  We believe this also affects
> other devices and not just ours.  We are now working with the multipath
> maintainer to understand this issue.
> 
> So this confirms that the original patch for bnx2x is not needed.

^ permalink raw reply	[flat|nested] 15+ messages in thread
* [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device
@ 2011-10-14  3:38 Michael Chan
  2011-10-14 15:31 ` Rick Jones
  2011-10-19 20:06 ` David Miller
  0 siblings, 2 replies; 15+ messages in thread
From: Michael Chan @ 2011-10-14  3:38 UTC (permalink / raw)
  To: davem; +Cc: netdev, dmitry, eilong

From: Dmitry Kravkov <dmitry@broadcom.com>

For an FCoE or iSCSI boot device, the networking side must stay "up" all
the time.  Otherwise, the FCoE/iSCSI interface driven by bnx2i/bnx2fc
will be reset and we'll lose the root file system.

If LRO is enabled, scripts that enable IP forwarding or bridging will
disable LRO and cause the device to be reset.  Disabling LRO on these
boot devices will prevent the reset.

Signed-off-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 6486ab8..4960048 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -9794,6 +9794,7 @@ static int __devinit bnx2x_init_bp(struct bnx2x *bp)
 	int func;
 	int timer_interval;
 	int rc;
+	u32 cnic_boot_device;
 
 	mutex_init(&bp->port.phy_mutex);
 	mutex_init(&bp->fw_mb_mutex);
@@ -9840,8 +9841,11 @@ static int __devinit bnx2x_init_bp(struct bnx2x *bp)
 
 	bp->multi_mode = multi_mode;
 
+	cnic_boot_device =
+		!!SHMEM_RD(bp, func_mb[BP_FW_MB_IDX(bp)].iscsi_boot_signature);
+
 	/* Set TPA flags */
-	if (disable_tpa) {
+	if (disable_tpa || cnic_boot_device) {
 		bp->flags &= ~TPA_ENABLE_FLAG;
 		bp->dev->features &= ~NETIF_F_LRO;
 	} else {
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 15+ messages in thread
end of thread, other threads:[~2012-02-13 19:23 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-02-13 11:20 [PATCH net-next] bnx2x: Disable LRO on FCoE or iSCSI boot device Vasily Averin
2012-02-13 19:09 ` Michael Chan
  -- strict thread matches above, loose matches on Subject: below --
2011-10-14  3:38 Michael Chan
2011-10-14 15:31 ` Rick Jones
2011-10-14 15:53   ` Michael Chan
2011-10-14 16:06     ` Rick Jones
2011-10-14 16:15       ` Michael Chan
2011-10-14 20:17         ` John Fastabend
2011-10-14 20:59           ` Michael Chan
2011-10-19 20:06 ` David Miller
2011-10-19 20:12   ` Michael Chan
2011-10-19 20:47     ` David Miller
2011-10-19 20:53       ` John Fastabend
2011-10-19 21:03         ` David Miller
2011-10-27 23:30         ` Michael Chan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).