* [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
@ 2021-01-18 5:46 Giacinto Cifelli
[not found] ` <20210118115250.GA1428@t-online.de>
0 siblings, 1 reply; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-18 5:46 UTC (permalink / raw)
To: netdev; +Cc: Giacinto Cifelli
Bus 003 Device 009: ID 1e2d:006f
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize0 64
idVendor 0x1e2d
idProduct 0x006f
bcdDevice 0.00
iManufacturer 3 Cinterion Wireless Modules
iProduct 2 PLSx3
iSerial 4 fa3c1419
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 303
bNumInterfaces 9
bConfigurationValue 1
iConfiguration 1 Cinterion Configuration
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower 500mA
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 0
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 1
CDC Union:
bMasterInterface 0
bSlaveInterface 1
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 2
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 2
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 3
CDC Union:
bMasterInterface 2
bSlaveInterface 3
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 3
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 4
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 4
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 5
CDC Union:
bMasterInterface 4
bSlaveInterface 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 5
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x86 EP 6 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03 EP 3 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 6
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 6
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 7
CDC Union:
bMasterInterface 6
bSlaveInterface 7
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x87 EP 7 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 7
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x88 EP 8 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x04 EP 4 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 8
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x89 EP 9 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x8a EP 10 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x05 EP 5 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)
Signed-off-by: Giacinto Cifelli <gciofono@gmail.com>
---
drivers/net/usb/qmi_wwan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index af19513a9f75..262d19439b34 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
+ {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
+ {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
{QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
[not found] ` <20210118115250.GA1428@t-online.de>
@ 2021-01-18 21:02 ` Bjørn Mork
2021-01-20 12:36 ` Giacinto Cifelli
2021-01-20 4:56 ` Giacinto Cifelli
1 sibling, 1 reply; 9+ messages in thread
From: Bjørn Mork @ 2021-01-18 21:02 UTC (permalink / raw)
To: Giacinto Cifelli; +Cc: Reinhard Speyerer, netdev, rspmn
Reinhard Speyerer <rspmn@t-online.de> writes:
>> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
>> index af19513a9f75..262d19439b34 100644
>> --- a/drivers/net/usb/qmi_wwan.c
>> +++ b/drivers/net/usb/qmi_wwan.c
>> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
>> {QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
>> {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
>> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
>> + {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
>> + {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
>> {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
>> {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
>> {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
>
> Hi Giacinto,
>
> AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> examples from other UE vendors.
Yup, please fix and send a v2. And please use get_maintainer.pl to get
the proper destinations.
Thanks for spotting this, Reinhard. I would never have caught it with
my current netdev reading frequency....
Bjørn
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
[not found] ` <20210118115250.GA1428@t-online.de>
2021-01-18 21:02 ` Bjørn Mork
@ 2021-01-20 4:56 ` Giacinto Cifelli
1 sibling, 0 replies; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-20 4:56 UTC (permalink / raw)
To: Reinhard Speyerer; +Cc: netdev, Bjørn Mork, rspmn
Hi Reinhard,
>
> AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> examples from other UE vendors.
>
thank you for these suggestions. Indeed I have removed that line,
retested, and the interface works properly.
I am submitting a v2 patch.
Regards,
Giacinto
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
2021-01-18 21:02 ` Bjørn Mork
@ 2021-01-20 12:36 ` Giacinto Cifelli
2021-01-20 13:13 ` Bjørn Mork
0 siblings, 1 reply; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-20 12:36 UTC (permalink / raw)
To: Bjørn Mork; +Cc: Reinhard Speyerer, netdev, rspmn
Hi Bjørn,
On Mon, Jan 18, 2021 at 10:02 PM Bjørn Mork <bjorn@mork.no> wrote:
>
> Reinhard Speyerer <rspmn@t-online.de> writes:
>
> >> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> >> index af19513a9f75..262d19439b34 100644
> >> --- a/drivers/net/usb/qmi_wwan.c
> >> +++ b/drivers/net/usb/qmi_wwan.c
> >> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
> >> {QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
> >> {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
> >> + {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
> >> + {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
> >> {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
> >> {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
> >
> > Hi Giacinto,
> >
> > AFAIK the {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)} is redundant and can simply
> > be deleted. Please see also commit 14cf4a771b3098e431d2677e3533bdd962e478d8
> > ("drivers: net: usb: qmi_wwan: add QMI_QUIRK_SET_DTR for Telit PID 0x1201")
> > and commit 97dc47a1308a3af46a09b1546cfb869f2e382a81
> > ("qmi_wwan: apply SET_DTR quirk to Sierra WP7607") for the corresponding
> > examples from other UE vendors.
>
> Yup, please fix and send a v2. And please use get_maintainer.pl to get
> the proper destinations.
>
I have fixed and resent, but from your comment I might not have
selected the right line from maintaner.pl?
what I have is this:
$ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
"Bjørn Mork" <bjorn@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
<<<< this seems the right one
linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
linux-kernel@vger.kernel.org (open list)
I have at the same time sent a patch for another enumeration of the
same product, for cdc_ether. In that case, I have picked the
following line, which also looked the best fit:
linux-usb@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
Did I misinterpret the results of the script?
Thank you,
Giacinto
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
2021-01-20 12:36 ` Giacinto Cifelli
@ 2021-01-20 13:13 ` Bjørn Mork
2021-01-20 14:37 ` Giacinto Cifelli
0 siblings, 1 reply; 9+ messages in thread
From: Bjørn Mork @ 2021-01-20 13:13 UTC (permalink / raw)
To: Giacinto Cifelli; +Cc: Reinhard Speyerer, netdev, rspmn
Giacinto Cifelli <gciofono@gmail.com> writes:
> Hi Bjørn,
> I have fixed and resent, but from your comment I might not have
> selected the right line from maintaner.pl?
> what I have is this:
> $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
> "Bjørn Mork" <bjorn@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
> "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
> Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
> netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
> <<<< this seems the right one
> linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
> linux-kernel@vger.kernel.org (open list)
>
> I have at the same time sent a patch for another enumeration of the
> same product, for cdc_ether. In that case, I have picked the
> following line, which also looked the best fit:
> linux-usb@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
>
> Did I misinterpret the results of the script?
Yes, but I'll be the first to admit that it isn't easy.
netdev is definitely correct, and the most important one.
But in theory you are supposed to use all the listed addresses. Except
that I don't think you need to CC David (and Jakub?) since they probably
read everything in netdev anyway. And I believe many (most?) people
leave out the linux-kernel catch-all, since it doesn't provide any extra
coverage for networking. At least I do.
Then there's the two remaining addresses. The linux-usb list is
traditionally CCed on patches touching USB drivers, since the USB
experts are there and not necessarily in netdev. And I'd like a copy
because that's the only way I'll be able to catch these patches. I
don't read any of the lists regularily.
This is my interpretation only. I am sure there are other opinions. But
as usual, you cannot do anything wrong. The worst that can ever happen
is that you have to resend a patch or miss my review of it ;-)
Bjørn
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
2021-01-20 13:13 ` Bjørn Mork
@ 2021-01-20 14:37 ` Giacinto Cifelli
2021-01-21 0:29 ` Jakub Kicinski
0 siblings, 1 reply; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-20 14:37 UTC (permalink / raw)
To: Bjørn Mork; +Cc: Reinhard Speyerer, netdev, rspmn
Hi Bjørn,
On Wed, Jan 20, 2021 at 2:13 PM Bjørn Mork <bjorn@mork.no> wrote:
>
> Giacinto Cifelli <gciofono@gmail.com> writes:
>
> > Hi Bjørn,
> > I have fixed and resent, but from your comment I might not have
> > selected the right line from maintaner.pl?
> > what I have is this:
> > $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
> > "Bjørn Mork" <bjorn@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
> > "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
> > Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
> > netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
> > <<<< this seems the right one
> > linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
> > linux-kernel@vger.kernel.org (open list)
> >
> > I have at the same time sent a patch for another enumeration of the
> > same product, for cdc_ether. In that case, I have picked the
> > following line, which also looked the best fit:
> > linux-usb@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
> >
> > Did I misinterpret the results of the script?
>
> Yes, but I'll be the first to admit that it isn't easy.
>
> netdev is definitely correct, and the most important one.
>
> But in theory you are supposed to use all the listed addresses. Except
> that I don't think you need to CC David (and Jakub?) since they probably
> read everything in netdev anyway. And I believe many (most?) people
> leave out the linux-kernel catch-all, since it doesn't provide any extra
> coverage for networking. At least I do.
>
> Then there's the two remaining addresses. The linux-usb list is
> traditionally CCed on patches touching USB drivers, since the USB
> experts are there and not necessarily in netdev. And I'd like a copy
> because that's the only way I'll be able to catch these patches. I
> don't read any of the lists regularily.
>
> This is my interpretation only. I am sure there are other opinions. But
> as usual, you cannot do anything wrong. The worst that can ever happen
> is that you have to resend a patch or miss my review of it ;-)
>
looks like "welcome to the maze" :D
So, the letter of the instructions would be send all, but up to you to
leave some of them out.
Got it.
I am going to wait a couple of days on the off chance that my patches
are reviewed, then I will resend.
Thank you and regards,
Giacinto
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
2021-01-20 14:37 ` Giacinto Cifelli
@ 2021-01-21 0:29 ` Jakub Kicinski
0 siblings, 0 replies; 9+ messages in thread
From: Jakub Kicinski @ 2021-01-21 0:29 UTC (permalink / raw)
To: Giacinto Cifelli; +Cc: Bjørn Mork, Reinhard Speyerer, netdev, rspmn
On Wed, 20 Jan 2021 15:37:59 +0100 Giacinto Cifelli wrote:
> On Wed, Jan 20, 2021 at 2:13 PM Bjørn Mork <bjorn@mork.no> wrote:
> > Giacinto Cifelli <gciofono@gmail.com> writes:
> > > Hi Bjørn,
> > > I have fixed and resent, but from your comment I might not have
> > > selected the right line from maintaner.pl?
> > > what I have is this:
> > > $ ./scripts/get_maintainer.pl --file drivers/net/usb/qmi_wwan.c
I always run it on the patch file formatted by git format-patch.
That way it will also make sure to list people relevant to Fixes
tags etc.
> > > "Bjørn Mork" <bjorn@mork.no> (maintainer:USB QMI WWAN NETWORK DRIVER)
> > > "David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
> > > Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
> > > netdev@vger.kernel.org (open list:USB QMI WWAN NETWORK DRIVER)
> > > <<<< this seems the right one
> > > linux-usb@vger.kernel.org (open list:USB NETWORKING DRIVERS)
> > > linux-kernel@vger.kernel.org (open list)
> > >
> > > I have at the same time sent a patch for another enumeration of the
> > > same product, for cdc_ether. In that case, I have picked the
> > > following line, which also looked the best fit:
> > > linux-usb@vger.kernel.org (open list:USB CDC ETHERNET DRIVER)
> > >
> > > Did I misinterpret the results of the script?
> >
> > Yes, but I'll be the first to admit that it isn't easy.
> >
> > netdev is definitely correct, and the most important one.
> >
> > But in theory you are supposed to use all the listed addresses. Except
> > that I don't think you need to CC David (and Jakub?) since they probably
> > read everything in netdev anyway.
That's fair, I've even said in the past that folks can skip CCing me.
That said with vger being flaky lately maybe it's not a bad idea after
all to CC maintainers - in case someone objects to the patch, and we
don't see it because some email deity decided to hold onto the message..
> > And I believe many (most?) people
> > leave out the linux-kernel catch-all, since it doesn't provide any extra
> > coverage for networking. At least I do.
Same, I wish get_maintainers didn't list it :/
> > Then there's the two remaining addresses. The linux-usb list is
> > traditionally CCed on patches touching USB drivers, since the USB
> > experts are there and not necessarily in netdev. And I'd like a copy
> > because that's the only way I'll be able to catch these patches. I
> > don't read any of the lists regularily.
> >
> > This is my interpretation only. I am sure there are other opinions. But
> > as usual, you cannot do anything wrong. The worst that can ever happen
> > is that you have to resend a patch or miss my review of it ;-)
> >
>
> looks like "welcome to the maze" :D
>
> So, the letter of the instructions would be send all, but up to you to
> leave some of them out.
> Got it.
> I am going to wait a couple of days on the off chance that my patches
> are reviewed, then I will resend.
>
> Thank you and regards,
> Giacinto
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
2021-01-26 4:41 Giacinto Cifelli
@ 2021-01-26 4:46 ` Giacinto Cifelli
0 siblings, 0 replies; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-26 4:46 UTC (permalink / raw)
To: oliver, davem, kuba, linux-usb, netdev
Dear all,
please ignore this. I have sent the wrong patch. This one, in v2, I
am told that has been applied already.
Apologies again.
Kind Regards,
Giacinto
On Tue, Jan 26, 2021 at 5:42 AM Giacinto Cifelli <gciofono@gmail.com> wrote:
>
> Bus 003 Device 009: ID 1e2d:006f
> Device Descriptor:
> bLength 18
> bDescriptorType 1
> bcdUSB 2.00
> bDeviceClass 239 Miscellaneous Device
> bDeviceSubClass 2 ?
> bDeviceProtocol 1 Interface Association
> bMaxPacketSize0 64
> idVendor 0x1e2d
> idProduct 0x006f
> bcdDevice 0.00
> iManufacturer 3 Cinterion Wireless Modules
> iProduct 2 PLSx3
> iSerial 4 fa3c1419
> bNumConfigurations 1
> Configuration Descriptor:
> bLength 9
> bDescriptorType 2
> wTotalLength 303
> bNumInterfaces 9
> bConfigurationValue 1
> iConfiguration 1 Cinterion Configuration
> bmAttributes 0xe0
> Self Powered
> Remote Wakeup
> MaxPower 500mA
> Interface Association:
> bLength 8
> bDescriptorType 11
> bFirstInterface 0
> bInterfaceCount 2
> bFunctionClass 2 Communications
> bFunctionSubClass 2 Abstract (modem)
> bFunctionProtocol 1 AT-commands (v.25ter)
> iFunction 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 0
> bAlternateSetting 0
> bNumEndpoints 1
> bInterfaceClass 2 Communications
> bInterfaceSubClass 2 Abstract (modem)
> bInterfaceProtocol 1 AT-commands (v.25ter)
> iInterface 0
> CDC Header:
> bcdCDC 1.10
> CDC ACM:
> bmCapabilities 0x02
> line coding and serial state
> CDC Call Management:
> bmCapabilities 0x03
> call management
> use DataInterface
> bDataInterface 1
> CDC Union:
> bMasterInterface 0
> bSlaveInterface 1
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x81 EP 1 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 5
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 1
> bAlternateSetting 0
> bNumEndpoints 2
> bInterfaceClass 10 CDC Data
> bInterfaceSubClass 0 Unused
> bInterfaceProtocol 0
> iInterface 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x82 EP 2 IN
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x01 EP 1 OUT
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Interface Association:
> bLength 8
> bDescriptorType 11
> bFirstInterface 2
> bInterfaceCount 2
> bFunctionClass 2 Communications
> bFunctionSubClass 2 Abstract (modem)
> bFunctionProtocol 1 AT-commands (v.25ter)
> iFunction 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 2
> bAlternateSetting 0
> bNumEndpoints 1
> bInterfaceClass 2 Communications
> bInterfaceSubClass 2 Abstract (modem)
> bInterfaceProtocol 1 AT-commands (v.25ter)
> iInterface 0
> CDC Header:
> bcdCDC 1.10
> CDC ACM:
> bmCapabilities 0x02
> line coding and serial state
> CDC Call Management:
> bmCapabilities 0x03
> call management
> use DataInterface
> bDataInterface 3
> CDC Union:
> bMasterInterface 2
> bSlaveInterface 3
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x83 EP 3 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 5
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 3
> bAlternateSetting 0
> bNumEndpoints 2
> bInterfaceClass 10 CDC Data
> bInterfaceSubClass 0 Unused
> bInterfaceProtocol 0
> iInterface 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x84 EP 4 IN
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x02 EP 2 OUT
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Interface Association:
> bLength 8
> bDescriptorType 11
> bFirstInterface 4
> bInterfaceCount 2
> bFunctionClass 2 Communications
> bFunctionSubClass 2 Abstract (modem)
> bFunctionProtocol 1 AT-commands (v.25ter)
> iFunction 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 4
> bAlternateSetting 0
> bNumEndpoints 1
> bInterfaceClass 2 Communications
> bInterfaceSubClass 2 Abstract (modem)
> bInterfaceProtocol 1 AT-commands (v.25ter)
> iInterface 0
> CDC Header:
> bcdCDC 1.10
> CDC ACM:
> bmCapabilities 0x02
> line coding and serial state
> CDC Call Management:
> bmCapabilities 0x03
> call management
> use DataInterface
> bDataInterface 5
> CDC Union:
> bMasterInterface 4
> bSlaveInterface 5
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x85 EP 5 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 5
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 5
> bAlternateSetting 0
> bNumEndpoints 2
> bInterfaceClass 10 CDC Data
> bInterfaceSubClass 0 Unused
> bInterfaceProtocol 0
> iInterface 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x86 EP 6 IN
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x03 EP 3 OUT
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Interface Association:
> bLength 8
> bDescriptorType 11
> bFirstInterface 6
> bInterfaceCount 2
> bFunctionClass 2 Communications
> bFunctionSubClass 2 Abstract (modem)
> bFunctionProtocol 1 AT-commands (v.25ter)
> iFunction 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 6
> bAlternateSetting 0
> bNumEndpoints 1
> bInterfaceClass 2 Communications
> bInterfaceSubClass 2 Abstract (modem)
> bInterfaceProtocol 1 AT-commands (v.25ter)
> iInterface 0
> CDC Header:
> bcdCDC 1.10
> CDC ACM:
> bmCapabilities 0x02
> line coding and serial state
> CDC Call Management:
> bmCapabilities 0x03
> call management
> use DataInterface
> bDataInterface 7
> CDC Union:
> bMasterInterface 6
> bSlaveInterface 7
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x87 EP 7 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 5
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 7
> bAlternateSetting 0
> bNumEndpoints 2
> bInterfaceClass 10 CDC Data
> bInterfaceSubClass 0 Unused
> bInterfaceProtocol 0
> iInterface 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x88 EP 8 IN
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x04 EP 4 OUT
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Interface Descriptor:
> bLength 9
> bDescriptorType 4
> bInterfaceNumber 8
> bAlternateSetting 0
> bNumEndpoints 3
> bInterfaceClass 255 Vendor Specific Class
> bInterfaceSubClass 255 Vendor Specific Subclass
> bInterfaceProtocol 255 Vendor Specific Protocol
> iInterface 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x89 EP 9 IN
> bmAttributes 3
> Transfer Type Interrupt
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0040 1x 64 bytes
> bInterval 5
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x8a EP 10 IN
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Endpoint Descriptor:
> bLength 7
> bDescriptorType 5
> bEndpointAddress 0x05 EP 5 OUT
> bmAttributes 2
> Transfer Type Bulk
> Synch Type None
> Usage Type Data
> wMaxPacketSize 0x0200 1x 512 bytes
> bInterval 0
> Device Qualifier (for other device speed):
> bLength 10
> bDescriptorType 6
> bcdUSB 2.00
> bDeviceClass 239 Miscellaneous Device
> bDeviceSubClass 2 ?
> bDeviceProtocol 1 Interface Association
> bMaxPacketSize0 64
> bNumConfigurations 1
> Device Status: 0x0000
> (Bus Powered)
>
> Signed-off-by: Giacinto Cifelli <gciofono@gmail.com>
> ---
> drivers/net/usb/qmi_wwan.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index af19513a9f75..262d19439b34 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
> {QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
> {QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
> + {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
> + {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
> {QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
> {QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
> {QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family
@ 2021-01-26 4:41 Giacinto Cifelli
2021-01-26 4:46 ` Giacinto Cifelli
0 siblings, 1 reply; 9+ messages in thread
From: Giacinto Cifelli @ 2021-01-26 4:41 UTC (permalink / raw)
To: oliver, davem, kuba, linux-usb, netdev; +Cc: Giacinto Cifelli
Bus 003 Device 009: ID 1e2d:006f
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize0 64
idVendor 0x1e2d
idProduct 0x006f
bcdDevice 0.00
iManufacturer 3 Cinterion Wireless Modules
iProduct 2 PLSx3
iSerial 4 fa3c1419
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 303
bNumInterfaces 9
bConfigurationValue 1
iConfiguration 1 Cinterion Configuration
bmAttributes 0xe0
Self Powered
Remote Wakeup
MaxPower 500mA
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 0
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 1
CDC Union:
bMasterInterface 0
bSlaveInterface 1
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 1
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x82 EP 2 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x01 EP 1 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 2
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 2
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 3
CDC Union:
bMasterInterface 2
bSlaveInterface 3
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 3
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x84 EP 4 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 4
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 4
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 5
CDC Union:
bMasterInterface 4
bSlaveInterface 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x85 EP 5 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 5
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x86 EP 6 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x03 EP 3 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Association:
bLength 8
bDescriptorType 11
bFirstInterface 6
bInterfaceCount 2
bFunctionClass 2 Communications
bFunctionSubClass 2 Abstract (modem)
bFunctionProtocol 1 AT-commands (v.25ter)
iFunction 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 6
bAlternateSetting 0
bNumEndpoints 1
bInterfaceClass 2 Communications
bInterfaceSubClass 2 Abstract (modem)
bInterfaceProtocol 1 AT-commands (v.25ter)
iInterface 0
CDC Header:
bcdCDC 1.10
CDC ACM:
bmCapabilities 0x02
line coding and serial state
CDC Call Management:
bmCapabilities 0x03
call management
use DataInterface
bDataInterface 7
CDC Union:
bMasterInterface 6
bSlaveInterface 7
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x87 EP 7 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 7
bAlternateSetting 0
bNumEndpoints 2
bInterfaceClass 10 CDC Data
bInterfaceSubClass 0 Unused
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x88 EP 8 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x04 EP 4 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 8
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 255 Vendor Specific Subclass
bInterfaceProtocol 255 Vendor Specific Protocol
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x89 EP 9 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 5
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x8a EP 10 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x05 EP 5 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0200 1x 512 bytes
bInterval 0
Device Qualifier (for other device speed):
bLength 10
bDescriptorType 6
bcdUSB 2.00
bDeviceClass 239 Miscellaneous Device
bDeviceSubClass 2 ?
bDeviceProtocol 1 Interface Association
bMaxPacketSize0 64
bNumConfigurations 1
Device Status: 0x0000
(Bus Powered)
Signed-off-by: Giacinto Cifelli <gciofono@gmail.com>
---
drivers/net/usb/qmi_wwan.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index af19513a9f75..262d19439b34 100644
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -1302,6 +1302,8 @@ static const struct usb_device_id products[] = {
{QMI_FIXED_INTF(0x0b3c, 0xc00a, 6)}, /* Olivetti Olicard 160 */
{QMI_FIXED_INTF(0x0b3c, 0xc00b, 4)}, /* Olivetti Olicard 500 */
{QMI_FIXED_INTF(0x1e2d, 0x0060, 4)}, /* Cinterion PLxx */
+ {QMI_FIXED_INTF(0x1e2d, 0x006f, 8)}, /* Cinterion PLS83/PLS63 */
+ {QMI_QUIRK_SET_DTR(0x1e2d, 0x006f, 8)},
{QMI_FIXED_INTF(0x1e2d, 0x0053, 4)}, /* Cinterion PHxx,PXxx */
{QMI_FIXED_INTF(0x1e2d, 0x0063, 10)}, /* Cinterion ALASxx (1 RmNet) */
{QMI_FIXED_INTF(0x1e2d, 0x0082, 4)}, /* Cinterion PHxx,PXxx (2 RmNet) */
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-01-27 12:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-18 5:46 [PATCH] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family Giacinto Cifelli
[not found] ` <20210118115250.GA1428@t-online.de>
2021-01-18 21:02 ` Bjørn Mork
2021-01-20 12:36 ` Giacinto Cifelli
2021-01-20 13:13 ` Bjørn Mork
2021-01-20 14:37 ` Giacinto Cifelli
2021-01-21 0:29 ` Jakub Kicinski
2021-01-20 4:56 ` Giacinto Cifelli
2021-01-26 4:41 Giacinto Cifelli
2021-01-26 4:46 ` Giacinto Cifelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).