From: Rob Herring <robh@kernel.org>
To: Robert Hancock <robert.hancock@calian.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"radhey.shyam.pandey@xilinx.com" <radhey.shyam.pandey@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next v3 v3 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks
Date: Thu, 25 Mar 2021 07:54:21 -0600 [thread overview]
Message-ID: <CAL_JsqKxVH+Z2m09+JFMON8DTeuK4kK73qWB-qxT=_AnZ_L0-g@mail.gmail.com> (raw)
In-Reply-To: <9d9c8eb80f9b1573931a948e69ec0a44b65491b7.camel@calian.com>
On Wed, Mar 24, 2021 at 11:19 AM Robert Hancock
<robert.hancock@calian.com> wrote:
>
> On Wed, 2021-03-24 at 11:08 -0600, Rob Herring wrote:
> > On Fri, Mar 12, 2021 at 01:52:13PM -0600, Robert Hancock wrote:
> > > Update DT bindings to describe all of the clocks that the axienet
> > > driver will now be able to make use of.
> > >
> > > Signed-off-by: Robert Hancock <robert.hancock@calian.com>
> > > ---
> > > .../bindings/net/xilinx_axienet.txt | 25 ++++++++++++++-----
> > > 1 file changed, 19 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > > b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > > index 2cd452419ed0..b8e4894bc634 100644
> > > --- a/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > > +++ b/Documentation/devicetree/bindings/net/xilinx_axienet.txt
> > > @@ -42,11 +42,23 @@ Optional properties:
> > > support both 1000BaseX and SGMII modes. If set, the phy-mode
> > > should be set to match the mode selected on core reset (i.e.
> > > by the basex_or_sgmii core input line).
> > > -- clocks : AXI bus clock for the device. Refer to common clock bindings.
> > > - Used to calculate MDIO clock divisor. If not specified, it is
> > > - auto-detected from the CPU clock (but only on platforms where
> > > - this is possible). New device trees should specify this - the
> > > - auto detection is only for backward compatibility.
> > > +- clock-names: Tuple listing input clock names. Possible clocks:
> > > + s_axi_lite_clk: Clock for AXI register slave interface
> > > + axis_clk: AXI4-Stream clock for TXD RXD TXC and RXS
> > > interfaces
> > > + ref_clk: Ethernet reference clock, used by signal delay
> > > + primitives and transceivers
> > > + mgt_clk: MGT reference clock (used by optional internal
> > > + PCS/PMA PHY)
> >
> > '_clk' is redundant.
>
> True, but there are existing device trees which already referenced these names
> because those are what was used by the Xilinx version of this driver and hence
> the Xilinx device tree generation software. So for compatibility I think we are
> kind of stuck with those names..
upstream? If not, then it doesn't matter what downstream is doing.
However, this isn't that important, so it's fine.
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-03-25 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 19:52 [PATCH net-next v3 v3 0/2] axienet clock additions Robert Hancock
2021-03-12 19:52 ` [PATCH net-next v3 v3 1/2] dt-bindings: net: xilinx_axienet: Document additional clocks Robert Hancock
2021-03-24 17:08 ` Rob Herring
2021-03-24 17:19 ` Robert Hancock
2021-03-25 13:54 ` Rob Herring [this message]
2021-03-12 19:52 ` [PATCH net-next v3 v3 2/2] net: axienet: Enable more clocks Robert Hancock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqKxVH+Z2m09+JFMON8DTeuK4kK73qWB-qxT=_AnZ_L0-g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=radhey.shyam.pandey@xilinx.com \
--cc=robert.hancock@calian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).