* Re: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
@ 2024-03-30 6:41 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-03-30 6:41 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Julia Lawall
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
References: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
TO: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
TO: herbert@gondor.apana.org.au
TO: linux-crypto@vger.kernel.org
CC: Ruud.Derwig@synopsys.com
CC: manjunath.hadli@vayavyalabs.com
CC: bhoomikak@vayavyalabs.com
CC: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
Hi Pavitrakumar,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6a8dbd71a70620c42d4fa82509204ba18231f28d]
url: https://github.com/intel-lab-lkp/linux/commits/Pavitrakumar-M/Add-SPAcc-driver-to-Linux-kernel/20240329-023010
base: 6a8dbd71a70620c42d4fa82509204ba18231f28d
patch link: https://lore.kernel.org/r/20240328182652.3587727-5-pavitrakumarm%40vayavyalabs.com
patch subject: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: x86_64-randconfig-103-20240330 (https://download.01.org/0day-ci/archive/20240330/202403301459.iOQWfbMn-lkp@intel.com/config)
compiler: gcc-12 (Ubuntu 12.3.0-9ubuntu2) 12.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202403301459.iOQWfbMn-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/dwc-spacc/spacc_core.c:1638:1-7: preceding lock on line 1618
vim +1638 drivers/crypto/dwc-spacc/spacc_core.c
b37587c90bca57 Pavitrakumar M 2024-03-28 1546
b37587c90bca57 Pavitrakumar M 2024-03-28 1547 static int spacc_pop_packets_ex(struct spacc_device *spacc, int *num_popped,
b37587c90bca57 Pavitrakumar M 2024-03-28 1548 unsigned long *lock_flag)
b37587c90bca57 Pavitrakumar M 2024-03-28 1549 {
b37587c90bca57 Pavitrakumar M 2024-03-28 1550 int ret = -EINPROGRESS;
b37587c90bca57 Pavitrakumar M 2024-03-28 1551 struct spacc_job *job = NULL;
b37587c90bca57 Pavitrakumar M 2024-03-28 1552 u32 cmdstat, swid, spacc_errcode = SPACC_OK;
b37587c90bca57 Pavitrakumar M 2024-03-28 1553 int jobs;
b37587c90bca57 Pavitrakumar M 2024-03-28 1554
b37587c90bca57 Pavitrakumar M 2024-03-28 1555 *num_popped = 0;
b37587c90bca57 Pavitrakumar M 2024-03-28 1556
b37587c90bca57 Pavitrakumar M 2024-03-28 1557 while ((jobs = _spacc_get_stat_cnt(spacc))) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1558 while (jobs-- > 0) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1559 /* write the pop register to get the next job */
b37587c90bca57 Pavitrakumar M 2024-03-28 1560 writel(1, spacc->regmap + SPACC_REG_STAT_POP);
b37587c90bca57 Pavitrakumar M 2024-03-28 1561 cmdstat = readl(spacc->regmap + SPACC_REG_STATUS);
b37587c90bca57 Pavitrakumar M 2024-03-28 1562
b37587c90bca57 Pavitrakumar M 2024-03-28 1563 swid = SPACC_STATUS_SW_ID_GET(cmdstat);
b37587c90bca57 Pavitrakumar M 2024-03-28 1564
b37587c90bca57 Pavitrakumar M 2024-03-28 1565 if (spacc->job_lookup[swid] == SPACC_JOB_IDX_UNUSED) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1566 ret = -EIO;
b37587c90bca57 Pavitrakumar M 2024-03-28 1567 goto ERR;
b37587c90bca57 Pavitrakumar M 2024-03-28 1568 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1569
b37587c90bca57 Pavitrakumar M 2024-03-28 1570 /* find the associated job with popped swid */
b37587c90bca57 Pavitrakumar M 2024-03-28 1571 if (swid < 0 || swid >= SPACC_MAX_JOBS)
b37587c90bca57 Pavitrakumar M 2024-03-28 1572 job = NULL;
b37587c90bca57 Pavitrakumar M 2024-03-28 1573 else
b37587c90bca57 Pavitrakumar M 2024-03-28 1574 job = &spacc->job[spacc->job_lookup[swid]];
b37587c90bca57 Pavitrakumar M 2024-03-28 1575
b37587c90bca57 Pavitrakumar M 2024-03-28 1576 if (!job) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1577 ret = -EIO;
b37587c90bca57 Pavitrakumar M 2024-03-28 1578 goto ERR;
b37587c90bca57 Pavitrakumar M 2024-03-28 1579 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1580
b37587c90bca57 Pavitrakumar M 2024-03-28 1581 /* mark job as done */
b37587c90bca57 Pavitrakumar M 2024-03-28 1582 job->job_done = 1;
b37587c90bca57 Pavitrakumar M 2024-03-28 1583 spacc->job_lookup[swid] = SPACC_JOB_IDX_UNUSED;
b37587c90bca57 Pavitrakumar M 2024-03-28 1584 spacc_errcode = SPACC_GET_STATUS_RET_CODE(cmdstat);
b37587c90bca57 Pavitrakumar M 2024-03-28 1585
b37587c90bca57 Pavitrakumar M 2024-03-28 1586 switch (spacc_errcode) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1587 case SPACC_ICVFAIL:
b37587c90bca57 Pavitrakumar M 2024-03-28 1588 ret = -EBADMSG;
b37587c90bca57 Pavitrakumar M 2024-03-28 1589 break;
b37587c90bca57 Pavitrakumar M 2024-03-28 1590 case SPACC_MEMERR:
b37587c90bca57 Pavitrakumar M 2024-03-28 1591 ret = -EINVAL;
b37587c90bca57 Pavitrakumar M 2024-03-28 1592 break;
b37587c90bca57 Pavitrakumar M 2024-03-28 1593 case SPACC_BLOCKERR:
b37587c90bca57 Pavitrakumar M 2024-03-28 1594 ret = -EINVAL;
b37587c90bca57 Pavitrakumar M 2024-03-28 1595 break;
b37587c90bca57 Pavitrakumar M 2024-03-28 1596 case SPACC_SECERR:
b37587c90bca57 Pavitrakumar M 2024-03-28 1597 ret = -EIO;
b37587c90bca57 Pavitrakumar M 2024-03-28 1598 break;
b37587c90bca57 Pavitrakumar M 2024-03-28 1599 case SPACC_OK:
b37587c90bca57 Pavitrakumar M 2024-03-28 1600 ret = CRYPTO_OK;
b37587c90bca57 Pavitrakumar M 2024-03-28 1601 break;
b37587c90bca57 Pavitrakumar M 2024-03-28 1602 default:
b37587c90bca57 Pavitrakumar M 2024-03-28 1603 pr_debug(" BUG: Hitting default case");
b37587c90bca57 Pavitrakumar M 2024-03-28 1604 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1605
b37587c90bca57 Pavitrakumar M 2024-03-28 1606 job->job_err = ret;
b37587c90bca57 Pavitrakumar M 2024-03-28 1607
b37587c90bca57 Pavitrakumar M 2024-03-28 1608 /*
b37587c90bca57 Pavitrakumar M 2024-03-28 1609 * We're done touching the SPAcc hw, so release the
b37587c90bca57 Pavitrakumar M 2024-03-28 1610 * lock across the job callback. It must be reacquired
b37587c90bca57 Pavitrakumar M 2024-03-28 1611 * before continuing to the next iteration.
b37587c90bca57 Pavitrakumar M 2024-03-28 1612 */
b37587c90bca57 Pavitrakumar M 2024-03-28 1613
b37587c90bca57 Pavitrakumar M 2024-03-28 1614 if (job->cb) {
b37587c90bca57 Pavitrakumar M 2024-03-28 1615 spin_unlock_irqrestore(&spacc->lock,
b37587c90bca57 Pavitrakumar M 2024-03-28 1616 *lock_flag);
b37587c90bca57 Pavitrakumar M 2024-03-28 1617 job->cb(spacc, job->cbdata);
b37587c90bca57 Pavitrakumar M 2024-03-28 @1618 spin_lock_irqsave(&spacc->lock, *lock_flag);
b37587c90bca57 Pavitrakumar M 2024-03-28 1619 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1620
b37587c90bca57 Pavitrakumar M 2024-03-28 1621 (*num_popped)++;
b37587c90bca57 Pavitrakumar M 2024-03-28 1622 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1623 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1624
b37587c90bca57 Pavitrakumar M 2024-03-28 1625 if (!*num_popped)
b37587c90bca57 Pavitrakumar M 2024-03-28 1626 pr_debug(" Failed to pop a single job\n");
b37587c90bca57 Pavitrakumar M 2024-03-28 1627
b37587c90bca57 Pavitrakumar M 2024-03-28 1628 ERR:
b37587c90bca57 Pavitrakumar M 2024-03-28 1629 spacc_process_jb(spacc);
b37587c90bca57 Pavitrakumar M 2024-03-28 1630
b37587c90bca57 Pavitrakumar M 2024-03-28 1631 /* reset the WD timer to the original value*/
b37587c90bca57 Pavitrakumar M 2024-03-28 1632 if (spacc->op_mode == SPACC_OP_MODE_WD)
b37587c90bca57 Pavitrakumar M 2024-03-28 1633 spacc_set_wd_count(spacc, spacc->config.wd_timer);
b37587c90bca57 Pavitrakumar M 2024-03-28 1634
b37587c90bca57 Pavitrakumar M 2024-03-28 1635 if (*num_popped && spacc->spacc_notify_jobs)
b37587c90bca57 Pavitrakumar M 2024-03-28 1636 spacc->spacc_notify_jobs(spacc);
b37587c90bca57 Pavitrakumar M 2024-03-28 1637
b37587c90bca57 Pavitrakumar M 2024-03-28 @1638 return ret;
b37587c90bca57 Pavitrakumar M 2024-03-28 1639 }
b37587c90bca57 Pavitrakumar M 2024-03-28 1640
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
@ 2024-03-30 1:42 kernel test robot
0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2024-03-30 1:42 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp, Julia Lawall
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
References: <20240328182652.3587727-5-pavitrakumarm@vayavyalabs.com>
TO: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
TO: herbert@gondor.apana.org.au
TO: linux-crypto@vger.kernel.org
CC: Ruud.Derwig@synopsys.com
CC: manjunath.hadli@vayavyalabs.com
CC: bhoomikak@vayavyalabs.com
CC: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
Hi Pavitrakumar,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 6a8dbd71a70620c42d4fa82509204ba18231f28d]
url: https://github.com/intel-lab-lkp/linux/commits/Pavitrakumar-M/Add-SPAcc-driver-to-Linux-kernel/20240329-023010
base: 6a8dbd71a70620c42d4fa82509204ba18231f28d
patch link: https://lore.kernel.org/r/20240328182652.3587727-5-pavitrakumarm%40vayavyalabs.com
patch subject: [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file
:::::: branch date: 31 hours ago
:::::: commit date: 31 hours ago
config: x86_64-randconfig-104-20240330 (https://download.01.org/0day-ci/archive/20240330/202403300947.olMzOBG1-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202403300947.olMzOBG1-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> drivers/crypto/dwc-spacc/spacc_skcipher.c:239:21-25: ERROR: reference preceded by free on line 238
--
>> drivers/crypto/dwc-spacc/spacc_device.c:157:2-9: line 157 is redundant because platform_get_irq() already prints an error
--
>> drivers/crypto/dwc-spacc/spacc_device.c:317:3-8: No need to set .owner here. The core will do it.
vim +239 drivers/crypto/dwc-spacc/spacc_skcipher.c
b37587c90bca57 Pavitrakumar M 2024-03-28 231
b37587c90bca57 Pavitrakumar M 2024-03-28 232 static void spacc_cipher_cra_exit(struct crypto_tfm *tfm)
b37587c90bca57 Pavitrakumar M 2024-03-28 233 {
b37587c90bca57 Pavitrakumar M 2024-03-28 234 struct spacc_crypto_ctx *tctx = crypto_tfm_ctx(tfm);
b37587c90bca57 Pavitrakumar M 2024-03-28 235 struct spacc_priv *priv = dev_get_drvdata(tctx->dev);
b37587c90bca57 Pavitrakumar M 2024-03-28 236
b37587c90bca57 Pavitrakumar M 2024-03-28 237 if (tctx->cipher_key) {
b37587c90bca57 Pavitrakumar M 2024-03-28 @238 kfree(NULL);
b37587c90bca57 Pavitrakumar M 2024-03-28 @239 tctx->cipher_key = NULL;
b37587c90bca57 Pavitrakumar M 2024-03-28 240 }
b37587c90bca57 Pavitrakumar M 2024-03-28 241
b37587c90bca57 Pavitrakumar M 2024-03-28 242 if (tctx->handle >= 0)
b37587c90bca57 Pavitrakumar M 2024-03-28 243 spacc_close(&priv->spacc, tctx->handle);
b37587c90bca57 Pavitrakumar M 2024-03-28 244
b37587c90bca57 Pavitrakumar M 2024-03-28 245 put_device(tctx->dev);
b37587c90bca57 Pavitrakumar M 2024-03-28 246 }
b37587c90bca57 Pavitrakumar M 2024-03-28 247
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-30 6:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-30 6:41 [PATCH v1 4/4] Enable Driver compilation in crypto Kconfig and Makefile file kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2024-03-30 1:42 kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).