Need create a repo for chassis implementation.

Need create a repo for chassis implementation.

[Wang, Kuiying]

[-- Attachment #1.1: Type: text/plain, Size: 3243 bytes --]

Hi Brad/Andrew,

As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3 steps.
Now, the step 1 is almost ready (Patch got two +1), so we can move on the step 2 “upstream the chassis implementation”.
Can you help create a repo “chassis-manager” for chassis implementation?

More info attached:
[cid:image002.jpg@01D41E83.F326C3A0]

       [cid:image004.jpg@01D41E83.F326C3A0]
Thanks,
Kuiying.

From: Andrew Geissler (Code Review) [mailto:gerrit@openbmc-project.xyz]
Sent: Thursday, June 28, 2018 9:44 PM
To: Wang, Kuiying <kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>>
Cc: Jenkins <openbmc-ci-admin@ozlabs.org<mailto:openbmc-ci-admin@ozlabs.org>>; Brad Bishop <bradleyb@fuzziesquirrel.com<mailto:bradleyb@fuzziesquirrel.com>>; Tom Joseph <tomjoseph@in.ibm.com<mailto:tomjoseph@in.ibm.com>>; Yong Li <yong.b.li@linux.intel.com<mailto:yong.b.li@linux.intel.com>>; Tanous, Ed <ed.tanous@intel.com<mailto:ed.tanous@intel.com>>; Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com<mailto:richard.marian.thomaiyar@linux.intel.com>>
Subject: Change in openbmc/phosphor-dbus-interfaces[master]: Upgrade D-Bus API about Chassis Power Control from “/org/openbmc” to ...


Andrew Geissler posted comments on this change.

View Change<https://gerrit.openbmc-project.xyz/11278>

Patch set 4:

ok, this is making more sense. I think what's a bit confusing is we'd pretty much completely deprecated pychassisctl with the new chassis and host state dbus interfaces I linked below. So if you want this review to go quicker, removing that aspect from this review would be best (i.e. just stick with the Buttons). Otherwise we can bang it out in the community call in a few weeks. Breaking it up into smaller, more specific reviews is better in general anyway I think. Thanks for refactoring these into C++ and defining their sdbusplus interfaces, it has always been on our TODO list but never made it to the top.

To view, visit change 11278<https://gerrit.openbmc-project.xyz/11278>. To unsubscribe, visit settings<https://gerrit.openbmc-project.xyz/settings>.
Gerrit-Project: openbmc/phosphor-dbus-interfaces
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf8990d19633d2df2beeb4b2c22f30f1abad6a45
Gerrit-Change-Number: 11278
Gerrit-PatchSet: 4
Gerrit-Owner: kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>
Gerrit-Reviewer: Andrew Geissler <geissonator@yahoo.com<mailto:geissonator@yahoo.com>>
Gerrit-Reviewer: Brad Bishop <bradleyb@fuzziesquirrel.com<mailto:bradleyb@fuzziesquirrel.com>>
Gerrit-Reviewer: Ed Tanous <ed.tanous@intel.com<mailto:ed.tanous@intel.com>>
Gerrit-Reviewer: Jenkins <openbmc-ci-admin@ozlabs.org<mailto:openbmc-ci-admin@ozlabs.org>>
Gerrit-Reviewer: Jia, Chunhui
Gerrit-Reviewer: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com<mailto:richard.marian.thomaiyar@linux.intel.com>>
Gerrit-Reviewer: Tom Joseph <tomjoseph@in.ibm.com<mailto:tomjoseph@in.ibm.com>>
Gerrit-Reviewer: Yong Li <yong.b.li@linux.intel.com<mailto:yong.b.li@linux.intel.com>>
Gerrit-Reviewer: kuiying.wang@intel.com<mailto:kuiying.wang@intel.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 13:44:21 +0000
Gerrit-HasComments: No

[-- Attachment #1.2: Type: text/html, Size: 9210 bytes --]

[-- Attachment #2: image002.jpg --]
[-- Type: image/jpeg, Size: 70862 bytes --]

[-- Attachment #3: image004.jpg --]
[-- Type: image/jpeg, Size: 73916 bytes --]

Re: Need create a repo for chassis implementation.

[Brad Bishop]

On Wed, 2018-07-18 at 02:46 +0000, Wang, Kuiying wrote:
> Hi Brad/Andrew,
>  
> As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3
> steps.
> Now, the step 1 is almost ready (Patch got two +1), so we can move on
> the step 2 “upstream the chassis implementation”.
> Can you help create a repo “chassis-manager” for chassis
> implementation?

Hi Kuiying

Andrew tried to reply to your note but it was bounced by the list for
being too big.  In the future please don't send pictures or attachments
to the list.  I'll insert Andrew's reply here.

thx - brad

Hi Kuiying, thanks for refactoring these skeleton repositories. Within
openbmc, we try to have smaller, more specific repositories. So I'm
wondering if instead we should create a repo specifically for handling
buttons on openbmc machines:
phosphor-buttons

The pychassisctl function has all been deprecated by phosphor-state-
manager interfaces (except the button event monitoring).  I'd vote we
just put the button actions in the new phosphor-button repo (i.e.
calling the appropriate systemd targets)

The power control function is a bit more complicated.  It could be
specific to a machine, specific to a company, or specific to the type
of hardware.  The design there is to have a common dbus API and then a
repo for different implementations.  The code in skeleton/op-
pwrctl/power_control_obj.c was I believe attempted to be written in a
generic way but based on your info below, seems like for now we need
two new repositories?

openpower-power-control
x86-power-control  

Andrew

>  
> More info attached:
> 
>  
>        
> Thanks,
> Kuiying.

RE: Need create a repo for chassis implementation.

[Wang, Kuiying]

Hi Andrew,
I agree w/ you on " smaller, more specific repositories", to create " phosphor-buttons" for handling buttons and create different repo for power control for specific machine/company/hardware like "openpower-power-control" and " x86-power-control".

In a word, we need create 3 repos as following:
phosphor-buttons
openpower-power-control
x86-power-control  

Brad,
I will not send pictures and attachments to the mail list in the future.

Thanks,
Kuiying.


-----Original Message-----
From: bradleyb@bajor.fuzziesquirrel.com [mailto:bradleyb@bajor.fuzziesquirrel.com] On Behalf Of Brad Bishop
Sent: Wednesday, July 25, 2018 6:15 PM
To: Wang, Kuiying <kuiying.wang@intel.com>; 'openbmc@lists.ozlabs.org' <openbmc@lists.ozlabs.org>
Cc: 'geissonator@yahoo.com' <geissonator@yahoo.com>; Tanous, Ed <ed.tanous@intel.com>; 'yong.b.li@linux.intel.com' <yong.b.li@linux.intel.com>; 'richard.marian.thomaiyar@linux.intel.com' <richard.marian.thomaiyar@linux.intel.com>; 'tomjoseph@in.ibm.com' <tomjoseph@in.ibm.com>; 'openbmc-ci-admin@ozlabs.org' <openbmc-ci-admin@ozlabs.org>; 'adamliyi@msn.com' <adamliyi@msn.com>
Subject: Re: Need create a repo for chassis implementation.

On Wed, 2018-07-18 at 02:46 +0000, Wang, Kuiying wrote:
> Hi Brad/Andrew,
>  
> As we discussed, I will upgrade Chassis based on C++ & sdbusplus by 3 
> steps.
> Now, the step 1 is almost ready (Patch got two +1), so we can move on 
> the step 2 “upstream the chassis implementation”.
> Can you help create a repo “chassis-manager” for chassis 
> implementation?

Hi Kuiying

Andrew tried to reply to your note but it was bounced by the list for being too big.  In the future please don't send pictures or attachments to the list.  I'll insert Andrew's reply here.

thx - brad

Hi Kuiying, thanks for refactoring these skeleton repositories. Within openbmc, we try to have smaller, more specific repositories. So I'm wondering if instead we should create a repo specifically for handling buttons on openbmc machines:
phosphor-buttons

The pychassisctl function has all been deprecated by phosphor-state- manager interfaces (except the button event monitoring).  I'd vote we just put the button actions in the new phosphor-button repo (i.e.
calling the appropriate systemd targets)

The power control function is a bit more complicated.  It could be specific to a machine, specific to a company, or specific to the type of hardware.  The design there is to have a common dbus API and then a repo for different implementations.  The code in skeleton/op- pwrctl/power_control_obj.c was I believe attempted to be written in a generic way but based on your info below, seems like for now we need two new repositories?

openpower-power-control
x86-power-control  

Andrew

>  
> More info attached:
> 
>  
>        
> Thanks,
> Kuiying.

Re: Need create a repo for chassis implementation.

[Brad Bishop]

> On Jul 25, 2018, at 10:33 PM, Wang, Kuiying <kuiying.wang@intel.com> wrote:
> 
> Hi Andrew,
> I agree w/ you on " smaller, more specific repositories", to create " phosphor-buttons" for handling buttons and create different repo for power control for specific machine/company/hardware like "openpower-power-control" and " x86-power-control".
> 
> In a word, we need create 3 repos as following:
> phosphor-buttons

created.

> openpower-power-control

I don’t know enough about the design to create this repository yet.
I’m assuming that is OK with Intel?

> x86-power-control  

created.  I apologize for the delay, but there is a general lack of
information here that makes me uncomfortable, and thus the delay.

For instance - is there a DBus API associated with this program?
If so - what is it?  Have you already written this program and
now you just want to host it on OpenBMC?  Or is it a new program?

> 
> Brad,
> I will not send pictures and attachments to the mail list in the future.

thanks!

> 
> Thanks,
> Kuiying.

RE: Need create a repo for chassis implementation.

[Wang, Kuiying]

Hi Brad,
Thanks a lot for your support.
1. I have already written this program on OpenBMC and verified it on X86 platform WFP. 
2. No need for specify Dbus API for x86-power-control, all the APIs are common.

BTW:
Can you add me or other Intel member into the maintainer list for these two repos?


Thanks,
Kuiying.

-----Original Message-----
From: Brad Bishop [mailto:bradleyb@fuzziesquirrel.com] 
Sent: Saturday, August 04, 2018 4:08 AM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: geissonator@yahoo.com; tomjoseph@in.ibm.com; Tanous, Ed <ed.tanous@intel.com>; openbmc@lists.ozlabs.org; yong.b.li@linux.intel.com; Li, Yong B <yong.b.li@intel.com>; openbmc-ci-admin@ozlabs.org; richard.marian.thomaiyar@linux.intel.com
Subject: Re: Need create a repo for chassis implementation.


> On Jul 25, 2018, at 10:33 PM, Wang, Kuiying <kuiying.wang@intel.com> wrote:
> 
> Hi Andrew,
> I agree w/ you on " smaller, more specific repositories", to create " phosphor-buttons" for handling buttons and create different repo for power control for specific machine/company/hardware like "openpower-power-control" and " x86-power-control".
> 
> In a word, we need create 3 repos as following:
> phosphor-buttons

created.

> openpower-power-control

I don’t know enough about the design to create this repository yet.
I’m assuming that is OK with Intel?

> x86-power-control

created.  I apologize for the delay, but there is a general lack of information here that makes me uncomfortable, and thus the delay.

For instance - is there a DBus API associated with this program?
If so - what is it?  Have you already written this program and now you just want to host it on OpenBMC?  Or is it a new program?

> 
> Brad,
> I will not send pictures and attachments to the mail list in the future.

thanks!

> 
> Thanks,
> Kuiying.

Re: Need create a repo for chassis implementation.

[Brad Bishop]

> On Aug 6, 2018, at 9:41 PM, Wang, Kuiying <kuiying.wang@intel.com> wrote:
> 
> Hi Brad,
> Thanks a lot for your support.
> 1. I have already written this program on OpenBMC and verified it on X86 platform WFP. 
> 2. No need for specify Dbus API for x86-power-control, all the APIs are common.
> 
> BTW:
> Can you add me or other Intel member into the maintainer list for these two repos?

Please add a MAINTAINERS file in one of your patches and I’ll
add those individuals to the necessary groups.

> 
> 
> Thanks,
> Kuiying.

RE: Need create a repo for chassis implementation.

[Wang, Kuiying]

Hi Brad,
Ok, I will do that.

Thanks,
Kuiying.

-----Original Message-----
From: Brad Bishop [mailto:bradleyb@fuzziesquirrel.com] 
Sent: Tuesday, August 7, 2018 8:34 PM
To: Wang, Kuiying <kuiying.wang@intel.com>
Cc: geissonator@yahoo.com; tomjoseph@in.ibm.com; Tanous, Ed <ed.tanous@intel.com>; openbmc@lists.ozlabs.org; yong.b.li@linux.intel.com; Li, Yong B <yong.b.li@intel.com>; openbmc-ci-admin@ozlabs.org; richard.marian.thomaiyar@linux.intel.com; Mihm, James <james.mihm@intel.com>
Subject: Re: Need create a repo for chassis implementation.


> On Aug 6, 2018, at 9:41 PM, Wang, Kuiying <kuiying.wang@intel.com> wrote:
> 
> Hi Brad,
> Thanks a lot for your support.
> 1. I have already written this program on OpenBMC and verified it on X86 platform WFP. 
> 2. No need for specify Dbus API for x86-power-control, all the APIs are common.
> 
> BTW:
> Can you add me or other Intel member into the maintainer list for these two repos?

Please add a MAINTAINERS file in one of your patches and I’ll add those individuals to the necessary groups.

> 
> 
> Thanks,
> Kuiying.