From: Rob Herring <robh@kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: devicetree@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs
Date: Mon, 16 Jul 2018 08:13:10 -0600 [thread overview]
Message-ID: <CAL_JsqJ6rEZzj+CJok1feGEFcM2DUxiYXig=h4hpJgyAOc4X5g@mail.gmail.com> (raw)
In-Reply-To: <c37eeb656151831123ec53bfc4e3c6caf718a060.camel@kernel.crashing.org>
On Wed, Jul 11, 2018 at 8:07 PM Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
>
> On Fri, 2018-07-06 at 11:48 +1000, Benjamin Herrenschmidt wrote:
> > > We've generally standardized around "label" for things like slots,
> > > ports, connectors, etc. that need to be physically identified.
> >
> > Yes, label would be an option too, probably a better one that aliases.
> >
> > > "slot-names" it seems hasn't gotten used for FDT. Since there aren't
> > > DT's published for OF based systems nor any documentation, newbies
> > > like me (that only have 8 years of DT experience) don't have any
> > > insight into how things used to be done.
> >
> > In a pretty much ad-hoc way :-) In this case, though, chip-id is a
> > simple solution and works well (and I have the code already written and
> > tested :-)
>
> I want to try to get that stuff upstream. Do you still object to the
> chip-id's after our discussion ? The labels aren't that great really...
No.
Acked-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2018-07-16 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 4:37 [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs Benjamin Herrenschmidt
2018-06-22 4:37 ` [PATCH 2/2] fsi: Add support for device-tree provided chip IDs Benjamin Herrenschmidt
2018-07-03 19:30 ` [PATCH 1/2] dt-bindings: fsi: Add optional chip-id to CFAMs Rob Herring
2018-07-04 1:06 ` Benjamin Herrenschmidt
2018-07-05 18:49 ` Rob Herring
2018-07-06 1:48 ` Benjamin Herrenschmidt
2018-07-12 2:07 ` Benjamin Herrenschmidt
2018-07-16 14:13 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJ6rEZzj+CJok1feGEFcM2DUxiYXig=h4hpJgyAOc4X5g@mail.gmail.com' \
--to=robh@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).