phone-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: phone-devel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Martin Botka <martin.botka@somainline.org>,
	Jami Kettunen <jami.kettunen@somainline.org>,
	Andy Gross <agross@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm6125 compatible
Date: Fri, 13 May 2022 11:17:34 +0200	[thread overview]
Message-ID: <20220513091734.hivkkbpc6inyb4la@SoMainline.org> (raw)
In-Reply-To: <d2507298-00a6-a1cc-0302-f96597fb4127@linaro.org>

On 2022-05-13 10:19:56, Krzysztof Kozlowski wrote:
> On 12/05/2022 00:06, Marijn Suijten wrote:
> > The pm6125 comes with 9 GPIOs, without holes.
> > 
> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> It's the first version, how did the tag appear here?

We are friends and review each-others patches offline before spamming
the mailing list with them, to save readers and maintainers here from
pointing out glaring mistakes.  I hope this is standard practice in
companies too, or do you recommend aganst us doing this?

> > ---
> >  Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> 
> 
> This will need fixups or rebasing on my sets of PMIC gpio schema cleanup:

Ack.

> https://lore.kernel.org/all/20220507194913.261121-1-krzysztof.kozlowski@linaro.org/
> https://lore.kernel.org/all/20220508135932.132378-2-krzysztof.kozlowski@linaro.org/
> 
> Bjorn,
> let us know preferred order (who should rebase on who).

I prefer yours to be applied first, so that I can retest this
patchseries with stricter / more correct dt-bindings introduced by it.
My series can also be resent with the notice that it has already been
rebased on top of your series, after collecting more reviews.  Where
necessary, I can review your series too if that helps getting it in
sooner.

- Marijn

  reply	other threads:[~2022-05-13  9:17 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 22:06 [PATCH 0/7] Add Qcom PM6125 PMIC, and use in Sony Xperia Seine PDX201 Marijn Suijten
2022-05-11 22:06 ` [PATCH 1/7] arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name Marijn Suijten
2022-05-11 22:06 ` [PATCH 2/7] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm6125 compatible Marijn Suijten
2022-05-13  8:19   ` Krzysztof Kozlowski
2022-05-13  9:17     ` Marijn Suijten [this message]
2022-05-13  9:37       ` Krzysztof Kozlowski
2022-05-13 21:09         ` Linus Walleij
2022-05-14 19:47           ` Krzysztof Kozlowski
2022-05-16 15:00   ` Bjorn Andersson
2022-05-19 12:51   ` Linus Walleij
2022-05-11 22:06 ` [PATCH 3/7] pinctrl: qcom: spmi-gpio: " Marijn Suijten
2022-05-16 15:00   ` Bjorn Andersson
2022-05-19 12:52   ` Linus Walleij
2022-05-11 22:06 ` [PATCH 4/7] iio: adc: qcom-spmi-adc5: Add missing VCOIN/AMUX_THM3/GPIO# channels Marijn Suijten
2022-05-14 16:13   ` Jonathan Cameron
2022-05-15 15:30     ` Marijn Suijten
2022-05-15 16:57       ` Jonathan Cameron
2022-05-15 16:58         ` Jonathan Cameron
2022-05-11 22:06 ` [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC Marijn Suijten
2022-05-13  8:24   ` Krzysztof Kozlowski
2022-05-13  9:25     ` Marijn Suijten
2022-05-13  9:33       ` Krzysztof Kozlowski
2022-05-11 22:06 ` [PATCH 6/7] arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON Marijn Suijten
2022-05-11 22:06 ` [PATCH 7/7] arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors Marijn Suijten
2022-05-13  8:25   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220513091734.hivkkbpc6inyb4la@SoMainline.org \
    --to=marijn.suijten@somainline.org \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jami.kettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.botka@somainline.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).