From: Marijn Suijten <marijn.suijten@somainline.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: phone-devel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
~postmarketos/upstreaming@lists.sr.ht,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Martin Botka <martin.botka@somainline.org>,
Jami Kettunen <jami.kettunen@somainline.org>,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC
Date: Fri, 13 May 2022 11:25:51 +0200 [thread overview]
Message-ID: <20220513092551.hvz5jvej57cgvavj@SoMainline.org> (raw)
In-Reply-To: <7c7f7036-e3ad-c9db-2c31-749e2d01e83d@linaro.org>
On 2022-05-13 10:24:04, Krzysztof Kozlowski wrote:
> On 12/05/2022 00:06, Marijn Suijten wrote:
> > This PMIC is commonly used on boards with an SM6125 SoC and looks very
> > similar in layout to the PM6150.
> >
> > Downstream declares more nodes to be available, but these have been
> > omitted from this patch: the pwm/lpg block is unused on my reference
> > device making it impossible to test/validate, and the spmi-clkdiv does
> > not have a single device-tree binding using this driver yet, hence
> > inclusion is better postponed until ie. audio which uses these clocks is
> > brought up.
> >
> > Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
>
> Two reviews on first patch... :)
Same story here, we review each-others patches in advance and it'd be
annoying to have them re-send their approval through the mailing list;
only for me/us to pick it up in a v2.
> > +
> > + pmic@1 {
> > + compatible = "qcom,pm6125", "qcom,spmi-pmic";
> > + reg = <0x1 SPMI_USID>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> No children, so this should not be needed, I think.
The size-cells or the entire node? There's a PWM/LPG block here
according to downstream DT, but my device doesn't use it so I can't test
that it is valid. I can add it anyway, presuming reviewers here have
the ability to validate it for me with a reference manual.
- Marijn
next prev parent reply other threads:[~2022-05-13 9:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 22:06 [PATCH 0/7] Add Qcom PM6125 PMIC, and use in Sony Xperia Seine PDX201 Marijn Suijten
2022-05-11 22:06 ` [PATCH 1/7] arm64: dts: qcom: pm660: Use unique ADC5_VCOIN address in node name Marijn Suijten
2022-05-11 22:06 ` [PATCH 2/7] dt-bindings: pinctrl: qcom-pmic-gpio: Add pm6125 compatible Marijn Suijten
2022-05-13 8:19 ` Krzysztof Kozlowski
2022-05-13 9:17 ` Marijn Suijten
2022-05-13 9:37 ` Krzysztof Kozlowski
2022-05-13 21:09 ` Linus Walleij
2022-05-14 19:47 ` Krzysztof Kozlowski
2022-05-16 15:00 ` Bjorn Andersson
2022-05-19 12:51 ` Linus Walleij
2022-05-11 22:06 ` [PATCH 3/7] pinctrl: qcom: spmi-gpio: " Marijn Suijten
2022-05-16 15:00 ` Bjorn Andersson
2022-05-19 12:52 ` Linus Walleij
2022-05-11 22:06 ` [PATCH 4/7] iio: adc: qcom-spmi-adc5: Add missing VCOIN/AMUX_THM3/GPIO# channels Marijn Suijten
2022-05-14 16:13 ` Jonathan Cameron
2022-05-15 15:30 ` Marijn Suijten
2022-05-15 16:57 ` Jonathan Cameron
2022-05-15 16:58 ` Jonathan Cameron
2022-05-11 22:06 ` [PATCH 5/7] arm64: dts: qcom: Add PM6125 PMIC Marijn Suijten
2022-05-13 8:24 ` Krzysztof Kozlowski
2022-05-13 9:25 ` Marijn Suijten [this message]
2022-05-13 9:33 ` Krzysztof Kozlowski
2022-05-11 22:06 ` [PATCH 6/7] arm64: dts: qcom: sm6125-seine: Include PM6125 and configure PON Marijn Suijten
2022-05-11 22:06 ` [PATCH 7/7] arm64: dts: qcom: sm6125-seine: Configure additional trinket thermistors Marijn Suijten
2022-05-13 8:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513092551.hvz5jvej57cgvavj@SoMainline.org \
--to=marijn.suijten@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jami.kettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).