From: Alex Elder <elder@ieee.org>
To: Sireesh Kodali <sireeshkodali1@gmail.com>,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
elder@kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [RFC PATCH 15/17] net: ipa: Add IPA v2.6L initialization sequence support
Date: Wed, 13 Oct 2021 17:30:45 -0500 [thread overview]
Message-ID: <d7073ebb-03cd-bf2e-52fd-27cafe525a01@ieee.org> (raw)
In-Reply-To: <20210920030811.57273-16-sireeshkodali1@gmail.com>
On 9/19/21 10:08 PM, Sireesh Kodali wrote:
> The biggest changes are:
>
> - Make SMP2P functions no-operation
> - Make resource init no-operation
> - Skip firmware loading
> - Add reset sequence
The only comments I have are not very major, so I'll wait
for a later review to suggest that sort of fine tuning.
-Alex
> Signed-off-by: Sireesh Kodali <sireeshkodali1@gmail.com>
> ---
> drivers/net/ipa/ipa_main.c | 19 ++++++++++++++++---
> drivers/net/ipa/ipa_resource.c | 3 +++
> drivers/net/ipa/ipa_smp2p.c | 11 +++++++++--
> 3 files changed, 28 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index ea6c4347f2c6..b437fbf95edf 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -355,12 +355,22 @@ static void ipa_hardware_config(struct ipa *ipa, const struct ipa_data *data)
> u32 granularity;
> u32 val;
>
> + if (ipa->version <= IPA_VERSION_2_6L) {
> + iowrite32(1, ipa->reg_virt + IPA_REG_COMP_SW_RESET_OFFSET);
> + iowrite32(0, ipa->reg_virt + IPA_REG_COMP_SW_RESET_OFFSET);
> +
> + iowrite32(1, ipa->reg_virt + ipa_reg_comp_cfg_offset(ipa->version));
> + }
> +
> /* IPA v4.5+ has no backward compatibility register */
> - if (version < IPA_VERSION_4_5) {
> + if (version >= IPA_VERSION_2_5 && version < IPA_VERSION_4_5) {
> val = data->backward_compat;
> iowrite32(val, ipa->reg_virt + ipa_reg_bcr_offset(ipa->version));
> }
>
> + if (ipa->version <= IPA_VERSION_2_6L)
> + return;
> +
> /* Implement some hardware workarounds */
> if (version >= IPA_VERSION_4_0 && version < IPA_VERSION_4_5) {
> /* Disable PA mask to allow HOLB drop */
> @@ -412,7 +422,8 @@ static void ipa_hardware_config(struct ipa *ipa, const struct ipa_data *data)
> static void ipa_hardware_deconfig(struct ipa *ipa)
> {
> /* Mostly we just leave things as we set them. */
> - ipa_hardware_dcd_deconfig(ipa);
> + if (ipa->version > IPA_VERSION_2_6L)
> + ipa_hardware_dcd_deconfig(ipa);
> }
>
> /**
> @@ -765,8 +776,10 @@ static int ipa_probe(struct platform_device *pdev)
>
> /* Otherwise we need to load the firmware and have Trust Zone validate
> * and install it. If that succeeds we can proceed with setup.
> + * But on IPA v2.6L we don't need to do firmware loading :D
> */
> - ret = ipa_firmware_load(dev);
> + if (ipa->version > IPA_VERSION_2_6L)
> + ret = ipa_firmware_load(dev);
> if (ret)
> goto err_deconfig;
>
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..36a72324d828 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -162,6 +162,9 @@ int ipa_resource_config(struct ipa *ipa, const struct ipa_resource_data *data)
> {
> u32 i;
>
> + if (ipa->version <= IPA_VERSION_2_6L)
> + return 0;
> +
> if (!ipa_resource_limits_valid(ipa, data))
> return -EINVAL;
>
> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index df7639c39d71..fa4a9f1c196a 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -233,6 +233,10 @@ int ipa_smp2p_init(struct ipa *ipa, bool modem_init)
> u32 valid_bit;
> int ret;
>
> + /* With IPA v2.6L and earlier SMP2P interrupts are used */
> + if (ipa->version <= IPA_VERSION_2_6L)
> + return 0;
> +
> valid_state = qcom_smem_state_get(dev, "ipa-clock-enabled-valid",
> &valid_bit);
> if (IS_ERR(valid_state))
> @@ -302,6 +306,9 @@ void ipa_smp2p_exit(struct ipa *ipa)
> {
> struct ipa_smp2p *smp2p = ipa->smp2p;
>
> + if (!smp2p)
> + return;
> +
> if (smp2p->setup_ready_irq)
> ipa_smp2p_irq_exit(smp2p, smp2p->setup_ready_irq);
> ipa_smp2p_panic_notifier_unregister(smp2p);
> @@ -317,7 +324,7 @@ void ipa_smp2p_disable(struct ipa *ipa)
> {
> struct ipa_smp2p *smp2p = ipa->smp2p;
>
> - if (!smp2p->setup_ready_irq)
> + if (!smp2p || !smp2p->setup_ready_irq)
> return;
>
> mutex_lock(&smp2p->mutex);
> @@ -333,7 +340,7 @@ void ipa_smp2p_notify_reset(struct ipa *ipa)
> struct ipa_smp2p *smp2p = ipa->smp2p;
> u32 mask;
>
> - if (!smp2p->notified)
> + if (!smp2p || !smp2p->notified)
> return;
>
> ipa_smp2p_power_release(ipa);
>
next prev parent reply other threads:[~2021-10-13 22:31 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 3:07 [RFC PATCH 00/17] net: ipa: Add support for IPA v2.x Sireesh Kodali
2021-09-20 3:07 ` [RFC PATCH 01/17] net: ipa: Correct ipa_status_opcode enumeration Sireesh Kodali
2021-10-13 22:28 ` Alex Elder
2021-10-18 16:12 ` Sireesh Kodali
2021-09-20 3:07 ` [RFC PATCH 02/17] net: ipa: revert to IPA_TABLE_ENTRY_SIZE for 32-bit IPA support Sireesh Kodali
2021-10-13 22:28 ` Alex Elder
2021-10-18 16:16 ` Sireesh Kodali
2021-09-20 3:07 ` [RFC PATCH 04/17] net: ipa: Establish ipa_dma interface Sireesh Kodali
2021-10-13 22:29 ` Alex Elder
2021-10-18 16:45 ` Sireesh Kodali
2021-09-20 3:07 ` [RFC PATCH 05/17] net: ipa: Check interrupts for availability Sireesh Kodali
2021-10-13 22:29 ` Alex Elder
2021-09-20 3:08 ` [RFC PATCH 06/17] net: ipa: Add timeout for ipa_cmd_pipeline_clear_wait Sireesh Kodali
2021-10-13 22:29 ` Alex Elder
2021-10-18 17:02 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 07/17] net: ipa: Add IPA v2.x register definitions Sireesh Kodali
2021-10-13 22:29 ` Alex Elder
2021-10-18 17:25 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 08/17] net: ipa: Add support for IPA v2.x interrupts Sireesh Kodali
2021-10-13 22:29 ` Alex Elder
2021-09-20 3:08 ` [RFC PATCH 09/17] net: ipa: Add support for using BAM as a DMA transport Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 17:30 ` Sireesh Kodali
2021-09-20 3:08 ` [PATCH 10/17] net: ipa: Add support for IPA v2.x commands and table init Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 18:13 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 11/17] net: ipa: Add support for IPA v2.x endpoints Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 18:17 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 12/17] net: ipa: Add support for IPA v2.x memory map Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 18:19 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 13/17] net: ipa: Add support for IPA v2.x in the driver's QMI interface Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 18:22 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 14/17] net: ipa: Add support for IPA v2 microcontroller Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-09-20 3:08 ` [RFC PATCH 15/17] net: ipa: Add IPA v2.6L initialization sequence support Sireesh Kodali
2021-10-13 22:30 ` Alex Elder [this message]
2021-09-20 3:08 ` [RFC PATCH 16/17] net: ipa: Add hw config describing IPA v2.x hardware Sireesh Kodali
2021-10-13 22:30 ` Alex Elder
2021-10-18 18:35 ` Sireesh Kodali
2021-09-20 3:08 ` [RFC PATCH 17/17] dt-bindings: net: qcom,ipa: Add support for MSM8953 and MSM8996 IPA Sireesh Kodali
2021-09-23 12:42 ` Rob Herring
2021-10-13 22:31 ` Alex Elder
2021-10-13 22:27 ` [RFC PATCH 00/17] net: ipa: Add support for IPA v2.x Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7073ebb-03cd-bf2e-52fd-27cafe525a01@ieee.org \
--to=elder@ieee.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=sireeshkodali1@gmail.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).