Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support
Type: series
Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
cff80b5d1e BootLinuxConsoleTest: Test the RX-Virt machine
2afa3191c4 MAINTAINERS: Add RX
2581cfc04d Add rx-softmmu
2190818c28 hw/registerfields.h: Add 8bit and 16bit register macros
997230fa9e qemu/bitops.h: Add extract8 and extract16
3481b34b73 hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
c5d63912aa hw/rx: Honor -accel qtest
ad820302f8 target/rx: Move rx_load_image to rx-virt.
387d306c14 hw/rx: RX Target hardware definition
6f8b3aff27 hw/char: RX62N serial communication interface (SCI)
465e8e3419 hw/timer: RX62N internal timer modules
6f0b3c6dda hw/intc: RX62N interrupt controller (ICUa)
56bdfb0467 target/rx: Dump bytes for each insn during disassembly
747fb3b0c1 target/rx: Collect all bytes during disassembly
a00d8b4c86 target/rx: Emit all disassembly in one prt()
2923ce8078 target/rx: Use prt_ldmi for XCHG_mr disassembly
db364b4e70 target/rx: Replace operand with prt_ldmi in disassembler
ab02b67a15 target/rx: Disassemble rx_index_addr into a string
43ba920a8c target/rx: RX disassembler
c77e3d7ee3 target/rx: simplify rx_cpu_class_by_name
cb783ec841 target/rx: Follow the change of tcg.
ceb39de01c target/rx: CPU definition
56775c6167 target/rx: TCG helper
900643e454 target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit 900643e454ec (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit 56775c6167e1 (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit ceb39de01c83 (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit cb783ec8417f (target/rx: Follow the change of tcg.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit c77e3d7ee3fd (target/rx: simplify rx_cpu_class_by_name)
6/24 Checking commit 43ba920a8c9c (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit ab02b67a153e (target/rx: Disassemble rx_index_addr into a string)
8/24 Checking commit db364b4e7075 (target/rx: Replace operand with prt_ldmi in disassembler)
9/24 Checking commit 2923ce807857 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
10/24 Checking commit a00d8b4c8652 (target/rx: Emit all disassembly in one prt())
11/24 Checking commit 747fb3b0c178 (target/rx: Collect all bytes during disassembly)
12/24 Checking commit 56bdfb0467c9 (target/rx: Dump bytes for each insn during disassembly)
13/24 Checking commit 6f0b3c6ddafc (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/24 Checking commit 465e8e3419e0 (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 14/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/24 Checking commit 6f8b3aff27d3 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 15/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/24 Checking commit 387d306c1415 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit ad820302f891 (target/rx: Move rx_load_image to rx-virt.)
18/24 Checking commit c5d63912aa3e (hw/rx: Honor -accel qtest)
19/24 Checking commit 3481b34b7332 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/24 Checking commit 997230fa9e74 (qemu/bitops.h: Add extract8 and extract16)
21/24 Checking commit 2190818c28f8 (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/24 Checking commit 2581cfc04de5 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 22/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit 2afa3191c4f3 (MAINTAINERS: Add RX)
24/24 Checking commit cff80b5d1ebb (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com