Re: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support

[no-reply@patchew.org]

Patchew URL: https://patchew.org/QEMU/20190616142836.10614-1-ysato@users.sourceforge.jp/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v20 00/24] Add RX archtecture support
Type: series
Message-id: 20190616142836.10614-1-ysato@users.sourceforge.jp

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 t [tag update]            patchew/20190616142836.10614-1-ysato@users.sourceforge.jp -> patchew/20190616142836.10614-1-ysato@users.sourceforge.jp
Switched to a new branch 'test'
6cf003324f BootLinuxConsoleTest: Test the RX-Virt machine
5b245d8608 MAINTAINERS: Add RX
a0f72f1c22 Add rx-softmmu
29cee4bf91 hw/registerfields.h: Add 8bit and 16bit register macros
4dc22f4709 qemu/bitops.h: Add extract8 and extract16
6faffcc70c hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core
8525a12c35 hw/rx: Honor -accel qtest
1a73fe6b98 target/rx: Move rx_load_image to rx-virt.
abe443904a hw/rx: RX Target hardware definition
65bcf6380e hw/char: RX62N serial communication interface (SCI)
1c2b600c8d hw/timer: RX62N internal timer modules
492f670463 hw/intc: RX62N interrupt controller (ICUa)
ee55183b75 target/rx: Dump bytes for each insn during disassembly
adf1747a39 target/rx: Collect all bytes during disassembly
af8bf138f1 target/rx: Emit all disassembly in one prt()
f5cc42e0d3 target/rx: Use prt_ldmi for XCHG_mr disassembly
10551aa38a target/rx: Replace operand with prt_ldmi in disassembler
cd70c31a2d target/rx: Disassemble rx_index_addr into a string
9ca9b0f1b7 target/rx: RX disassembler
006b47f9ab target/rx: simplify rx_cpu_class_by_name
c63cb5a1ca target/rx: Follow the change of tcg.
eeca36e3d4 target/rx: CPU definition
ce69a0fc32 target/rx: TCG helper
9407cbd6df target/rx: TCG translation

=== OUTPUT BEGIN ===
1/24 Checking commit 9407cbd6df21 (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 1/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/24 Checking commit ce69a0fc32ce (target/rx: TCG helper)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 649 lines checked

Patch 2/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/24 Checking commit eeca36e3d4cb (target/rx: CPU definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100644

total: 0 errors, 1 warnings, 645 lines checked

Patch 3/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/24 Checking commit c63cb5a1ca57 (target/rx: Follow the change of tcg.)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Patch 4/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/24 Checking commit 006b47f9aba0 (target/rx: simplify rx_cpu_class_by_name)
6/24 Checking commit 9ca9b0f1b7bf (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/24 Checking commit cd70c31a2d67 (target/rx: Disassemble rx_index_addr into a string)
8/24 Checking commit 10551aa38ab8 (target/rx: Replace operand with prt_ldmi in disassembler)
9/24 Checking commit f5cc42e0d3c9 (target/rx: Use prt_ldmi for XCHG_mr disassembly)
10/24 Checking commit af8bf138f119 (target/rx: Emit all disassembly in one prt())
11/24 Checking commit adf1747a39dc (target/rx: Collect all bytes during disassembly)
12/24 Checking commit ee55183b7577 (target/rx: Dump bytes for each insn during disassembly)
13/24 Checking commit 492f670463db (hw/intc: RX62N interrupt controller (ICUa))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#40: 
new file mode 100644

total: 0 errors, 1 warnings, 442 lines checked

Patch 13/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/24 Checking commit 1c2b600c8dbb (hw/timer: RX62N internal timer modules)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#50: 
new file mode 100644

total: 0 errors, 1 warnings, 839 lines checked

Patch 14/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/24 Checking commit 65bcf6380ee0 (hw/char: RX62N serial communication interface (SCI))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43: 
new file mode 100644

total: 0 errors, 1 warnings, 398 lines checked

Patch 15/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/24 Checking commit abe443904a61 (hw/rx: RX Target hardware definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 457 lines checked

Patch 16/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/24 Checking commit 1a73fe6b985d (target/rx: Move rx_load_image to rx-virt.)
18/24 Checking commit 8525a12c3571 (hw/rx: Honor -accel qtest)
19/24 Checking commit 6faffcc70c79 (hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core)
20/24 Checking commit 4dc22f47093f (qemu/bitops.h: Add extract8 and extract16)
21/24 Checking commit 29cee4bf91ce (hw/registerfields.h: Add 8bit and 16bit register macros)
Use of uninitialized value within @rawlines in concatenation (.) or string at ./scripts/checkpatch.pl line 2467.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#27: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#31: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 21/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/24 Checking commit a0f72f1c22ea (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#61: 
new file mode 100644

total: 0 errors, 1 warnings, 73 lines checked

Patch 22/24 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/24 Checking commit 5b245d860873 (MAINTAINERS: Add RX)
24/24 Checking commit 6cf003324f44 (BootLinuxConsoleTest: Test the RX-Virt machine)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20190616142836.10614-1-ysato@users.sourceforge.jp/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com