[Qemu-devel] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length

From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, berto@igalia.com, ehabkost@redhat.com,
	kvm@vger.kernel.org, mtosatti@redhat.com,
	mdroth@linux.vnet.ibm.com, armbru@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length
Date: Tue, 30 Jul 2019 19:01:36 +0300	[thread overview]
Message-ID: <1564502498-805893-2-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1564502498-805893-1-git-send-email-andrey.shinkevich@virtuozzo.com>

ThrottleState::cfg of the static variable 'ts' is reassigned with the
local one in the do_test_accounting() and then is passed to the
throttle_account() with uninitialized member LeakyBucket::burst_length.

Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
 tests/test-throttle.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/test-throttle.c b/tests/test-throttle.c
index a288122..ebf3aeb 100644
--- a/tests/test-throttle.c
+++ b/tests/test-throttle.c
@@ -557,6 +557,8 @@ static bool do_test_accounting(bool is_ops, /* are we testing bps or ops */
     BucketType index;
     int i;
 
+    throttle_config_init(&cfg);
+
     for (i = 0; i < 3; i++) {
         BucketType index = to_test[is_ops][i];
         cfg.buckets[index].avg = avg;
-- 
1.8.3.1


