qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, berto@igalia.com, ehabkost@redhat.com,
	kvm@vger.kernel.org, mtosatti@redhat.com,
	mdroth@linux.vnet.ibm.com, armbru@redhat.com,
	andrey.shinkevich@virtuozzo.com, den@openvz.org,
	pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call
Date: Tue, 30 Jul 2019 19:01:38 +0300	[thread overview]
Message-ID: <1564502498-805893-4-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1564502498-805893-1-git-send-email-andrey.shinkevich@virtuozzo.com>

Not the whole structure is initialized before passing it to the KVM.
Reduce the number of Valgrind reports.

Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
 target/i386/kvm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/target/i386/kvm.c b/target/i386/kvm.c
index dbbb137..ed57e31 100644
--- a/target/i386/kvm.c
+++ b/target/i386/kvm.c
@@ -190,6 +190,7 @@ static int kvm_get_tsc(CPUState *cs)
         return 0;
     }
 
+    memset(&msr_data, 0, sizeof(msr_data));
     msr_data.info.nmsrs = 1;
     msr_data.entries[0].index = MSR_IA32_TSC;
     env->tsc_valid = !runstate_is_running();
@@ -1706,6 +1707,7 @@ int kvm_arch_init_vcpu(CPUState *cs)
 
     if (has_xsave) {
         env->xsave_buf = qemu_memalign(4096, sizeof(struct kvm_xsave));
+        memset(env->xsave_buf, 0, sizeof(struct kvm_xsave));
     }
 
     max_nested_state_len = kvm_max_nested_state_length();
@@ -3477,6 +3479,7 @@ static int kvm_put_debugregs(X86CPU *cpu)
         return 0;
     }
 
+    memset(&dbgregs, 0, sizeof(dbgregs));
     for (i = 0; i < 4; i++) {
         dbgregs.db[i] = env->dr[i];
     }
-- 
1.8.3.1



  parent reply	other threads:[~2019-07-30 16:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30 16:01 [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length Andrey Shinkevich
2019-08-13 12:19   ` Alberto Garcia
2019-07-30 16:01 ` [Qemu-devel] [PATCH 2/3] tests: Fix uninitialized byte in test_visitor_in_fuzz Andrey Shinkevich
2019-07-30 16:01 ` Andrey Shinkevich [this message]
2019-07-30 16:44   ` [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call Philippe Mathieu-Daudé
2019-07-30 17:05     ` Christian Borntraeger
2019-07-30 17:14       ` Philippe Mathieu-Daudé
2019-07-30 17:47         ` Christian Borntraeger
2019-07-31  9:05       ` Christophe de Dinechin
2019-07-31 12:32         ` Paolo Bonzini
2019-07-31 14:10           ` Andrey Shinkevich
2019-07-30 19:22     ` Paolo Bonzini
2019-07-30 16:46   ` Peter Maydell
2019-07-30 17:09     ` Christian Borntraeger
2019-07-30 19:20   ` Paolo Bonzini
2019-07-31  7:24     ` Christian Borntraeger
2019-07-31 12:04       ` Andrey Shinkevich
2019-07-31 12:28         ` Christian Borntraeger
2019-07-31 12:43           ` Christian Borntraeger
2019-07-31 13:03             ` Paolo Bonzini
2019-07-31 14:11             ` Andrey Shinkevich
2019-08-13 12:02 ` [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-08-13 12:05   ` Paolo Bonzini
2019-08-13 12:08     ` Andrey Shinkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1564502498-805893-4-git-send-email-andrey.shinkevich@virtuozzo.com \
    --to=andrey.shinkevich@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=berto@igalia.com \
    --cc=den@openvz.org \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).