From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: vsementsov@virtuozzo.com, berto@igalia.com, ehabkost@redhat.com,
kvm@vger.kernel.org, mtosatti@redhat.com,
mdroth@linux.vnet.ibm.com, armbru@redhat.com,
andrey.shinkevich@virtuozzo.com, den@openvz.org,
pbonzini@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 2/3] tests: Fix uninitialized byte in test_visitor_in_fuzz
Date: Tue, 30 Jul 2019 19:01:37 +0300 [thread overview]
Message-ID: <1564502498-805893-3-git-send-email-andrey.shinkevich@virtuozzo.com> (raw)
In-Reply-To: <1564502498-805893-1-git-send-email-andrey.shinkevich@virtuozzo.com>
One byte in the local buffer stays uninitialized, at least with the
first iteration, because of the double decrement in the
test_visitor_in_fuzz(). This is what Valgrind does not like and not
critical for the test itself. So, reduce the number of the memory
issues reports.
Signed-off-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
---
tests/test-string-input-visitor.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/tests/test-string-input-visitor.c b/tests/test-string-input-visitor.c
index 34b54df..5418e08 100644
--- a/tests/test-string-input-visitor.c
+++ b/tests/test-string-input-visitor.c
@@ -444,16 +444,14 @@ static void test_visitor_in_fuzz(TestInputVisitorData *data,
char buf[10000];
for (i = 0; i < 100; i++) {
- unsigned int j;
+ unsigned int j, k;
j = g_test_rand_int_range(0, sizeof(buf) - 1);
buf[j] = '\0';
- if (j != 0) {
- for (j--; j != 0; j--) {
- buf[j - 1] = (char)g_test_rand_int_range(0, 256);
- }
+ for (k = 0; k != j; k++) {
+ buf[k] = (char)g_test_rand_int_range(0, 256);
}
v = visitor_input_test_init(data, buf);
--
1.8.3.1
next prev parent reply other threads:[~2019-07-30 16:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 16:01 [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-07-30 16:01 ` [Qemu-devel] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length Andrey Shinkevich
2019-08-13 12:19 ` Alberto Garcia
2019-07-30 16:01 ` Andrey Shinkevich [this message]
2019-07-30 16:01 ` [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call Andrey Shinkevich
2019-07-30 16:44 ` Philippe Mathieu-Daudé
2019-07-30 17:05 ` Christian Borntraeger
2019-07-30 17:14 ` Philippe Mathieu-Daudé
2019-07-30 17:47 ` Christian Borntraeger
2019-07-31 9:05 ` Christophe de Dinechin
2019-07-31 12:32 ` Paolo Bonzini
2019-07-31 14:10 ` Andrey Shinkevich
2019-07-30 19:22 ` Paolo Bonzini
2019-07-30 16:46 ` Peter Maydell
2019-07-30 17:09 ` Christian Borntraeger
2019-07-30 19:20 ` Paolo Bonzini
2019-07-31 7:24 ` Christian Borntraeger
2019-07-31 12:04 ` Andrey Shinkevich
2019-07-31 12:28 ` Christian Borntraeger
2019-07-31 12:43 ` Christian Borntraeger
2019-07-31 13:03 ` Paolo Bonzini
2019-07-31 14:11 ` Andrey Shinkevich
2019-08-13 12:02 ` [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests Andrey Shinkevich
2019-08-13 12:05 ` Paolo Bonzini
2019-08-13 12:08 ` Andrey Shinkevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564502498-805893-3-git-send-email-andrey.shinkevich@virtuozzo.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=den@openvz.org \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).