From: Hu Tao <hutao@cn.fujitsu.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: aliguori@us.ibm.com, gleb@redhat.com,
Marcel Apfelbaum <marcel.a@redhat.com>,
qemu-devel@nongnu.org, Ronen Hod <rhod@redhat.com>,
kraxel@redhat.com, Paolo Bonzini <pbonzini@redhat.com>,
afaerber@suse.de, vrozenfe@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type
Date: Wed, 21 Aug 2013 17:56:53 +0800 [thread overview]
Message-ID: <20130821095653.GD32733@localhost.localdomain> (raw)
In-Reply-To: <20130821094237.GA4757@redhat.com>
On Wed, Aug 21, 2013 at 12:42:37PM +0300, Michael S. Tsirkin wrote:
> On Wed, Aug 21, 2013 at 10:18:23AM +0200, Paolo Bonzini wrote:
> > Il 21/08/2013 10:03, Marcel Apfelbaum ha scritto:
> > > On Wed, 2013-08-14 at 10:02 +0300, Ronen Hod wrote:
> > >> How about adding a flag that tells QEMU whether to pause or reboot the guest
> > >> after the panic?
> > >> We cannot assume that we always have a management layer that takes care
> > >> of this.
> > >> One example is Microsoft's WHQL that deliberately generates a BSOD, and then
> > >> examines the dump files.
> > > After this patch the pvpanic is not part of the global devices anymore so just
> > > don't enable it if you want to reboot on BSOD.
> > > In my opinion "reboot after panic" equals "run without pvpanic device"
> >
> > This is not entirely possible, since "reboot after panic" is a guest
> > setting while "run without pvpanic device" is a host setting (that the
> > guest administrator may not even have access to: Ronen's case is a good
> > example of this, because the "administrator" there is the WHQL harness).
> >
> > However, I think this is a driver problem. The driver should just probe
> > the "reboot after panic" setting and not issue the outb to the pvpanic port.
> >
> > Paolo
>
> This might or might not be possible on different OS-es.
> What exactly is gained by doing vmstop on outb of pvpanic?
This gives management apps (libvirt) a chance to take care of the situation.
It can reboot, poweroff, or dump guest.
> We want a notification about the panic but
> adding yet another way to halt seems kind of useless.
> Why not let VM continue? If it wants to stop it
> can always call halt.
>
next prev parent reply other threads:[~2013-08-21 9:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 15:10 [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type Marcel Apfelbaum
2013-08-11 15:10 ` [Qemu-devel] [PATCH for-1.6 V2 1/2] hw/misc: don't create pvpanic device by default Marcel Apfelbaum
2013-08-12 3:06 ` Hu Tao
2013-08-12 15:59 ` Andreas Färber
2013-08-13 11:26 ` Markus Armbruster
2013-08-11 15:10 ` [Qemu-devel] [PATCH for-1.6 V2 2/2] hw/misc: make pvpanic known to user Marcel Apfelbaum
2013-08-12 3:07 ` Hu Tao
2013-08-12 15:53 ` [Qemu-devel] [PATCH for-1.6 V2 0/2] pvpanic: Separate pvpanic from machine type Eric Blake
2013-08-12 16:26 ` Marcel Apfelbaum
2013-08-14 7:02 ` Ronen Hod
2013-08-21 8:03 ` Marcel Apfelbaum
2013-08-21 8:18 ` Paolo Bonzini
2013-08-21 9:42 ` Michael S. Tsirkin
2013-08-21 9:56 ` Hu Tao [this message]
2013-08-21 9:59 ` Paolo Bonzini
2013-08-21 10:16 ` Michael S. Tsirkin
2013-08-21 10:37 ` Paolo Bonzini
2013-08-14 16:27 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821095653.GD32733@localhost.localdomain \
--to=hutao@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=gleb@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rhod@redhat.com \
--cc=vrozenfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).