qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
@ 2016-02-07 17:22 Stephen Warren
  2016-02-08  9:05 ` Markus Armbruster
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2016-02-07 17:22 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-devel, Stephen Warren

Add an entry to MAINTAINERS that matches every patch, and requests the
user send patches to qemu-devel@nongnu.org.

It's not 100% obvious to project newcomers that all patches should be sent
there; checkpatch doesn't say so, and since it mentions other lists to CC,
the wording "the list" from the SubmitAPatch wiki page can be taken
to mean only those lists, not the main list too.

The F: entries were taken from a similar entry in the Linux kernel.

Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b6ed87a26349..2d78eea5d62d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -52,6 +52,11 @@ General Project Administration
 ------------------------------
 M: Peter Maydell <peter.maydell@linaro.org>
 
+All patches CC here
+L: qemu-devel@nongnu.org
+F: *
+F: */
+
 Responsible Disclosure, Reporting Security Issues
 ------------------------------
 W: http://wiki.qemu.org/SecurityProcess
-- 
1.9.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
  2016-02-07 17:22 [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ Stephen Warren
@ 2016-02-08  9:05 ` Markus Armbruster
  2016-02-08 18:52   ` John Snow
  0 siblings, 1 reply; 6+ messages in thread
From: Markus Armbruster @ 2016-02-08  9:05 UTC (permalink / raw)
  To: Stephen Warren; +Cc: Peter Maydell, qemu-devel

Stephen Warren <swarren@wwwdotorg.org> writes:

> Add an entry to MAINTAINERS that matches every patch, and requests the
> user send patches to qemu-devel@nongnu.org.
>
> It's not 100% obvious to project newcomers that all patches should be sent
> there; checkpatch doesn't say so, and since it mentions other lists to CC,
> the wording "the list" from the SubmitAPatch wiki page can be taken
> to mean only those lists, not the main list too.
>
> The F: entries were taken from a similar entry in the Linux kernel.
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6ed87a26349..2d78eea5d62d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -52,6 +52,11 @@ General Project Administration
>  ------------------------------
>  M: Peter Maydell <peter.maydell@linaro.org>
>  
> +All patches CC here
> +L: qemu-devel@nongnu.org
> +F: *
> +F: */
> +
>  Responsible Disclosure, Reporting Security Issues
>  ------------------------------
>  W: http://wiki.qemu.org/SecurityProcess

I acknowledge the problem, but your patch breaks the "No maintainers
found, printing recent contributors" functionality.

Before:

    $ scripts/get_maintainer.pl -f MAINTAINERS 
    get_maintainer.pl: No maintainers found, printing recent contributors.
    get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.

    Paolo Bonzini <pbonzini@redhat.com> (commit_signer:20/74=27%)
    Kevin Wolf <kwolf@redhat.com> (commit_signer:13/74=18%)
    Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:13/74=18%)
    "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:10/74=14%)
    Peter Maydell <peter.maydell@linaro.org> (commit_signer:8/74=11%)

After:

    $ scripts/get_maintainer.pl -f MAINTAINERS 
    qemu-devel@nongnu.org (open list:All patches CC here)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
  2016-02-08  9:05 ` Markus Armbruster
@ 2016-02-08 18:52   ` John Snow
  2016-02-08 19:04     ` Stephen Warren
  0 siblings, 1 reply; 6+ messages in thread
From: John Snow @ 2016-02-08 18:52 UTC (permalink / raw)
  To: Markus Armbruster, Stephen Warren; +Cc: Peter Maydell, qemu-devel



On 02/08/2016 04:05 AM, Markus Armbruster wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
> 
>> Add an entry to MAINTAINERS that matches every patch, and requests the
>> user send patches to qemu-devel@nongnu.org.
>>
>> It's not 100% obvious to project newcomers that all patches should be sent
>> there; checkpatch doesn't say so, and since it mentions other lists to CC,
>> the wording "the list" from the SubmitAPatch wiki page can be taken
>> to mean only those lists, not the main list too.
>>
>> The F: entries were taken from a similar entry in the Linux kernel.
>>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>>  MAINTAINERS | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6ed87a26349..2d78eea5d62d 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -52,6 +52,11 @@ General Project Administration
>>  ------------------------------
>>  M: Peter Maydell <peter.maydell@linaro.org>
>>  
>> +All patches CC here
>> +L: qemu-devel@nongnu.org
>> +F: *
>> +F: */
>> +
>>  Responsible Disclosure, Reporting Security Issues
>>  ------------------------------
>>  W: http://wiki.qemu.org/SecurityProcess
> 
> I acknowledge the problem, but your patch breaks the "No maintainers
> found, printing recent contributors" functionality.
> 
> Before:
> 
>     $ scripts/get_maintainer.pl -f MAINTAINERS 
>     get_maintainer.pl: No maintainers found, printing recent contributors.
>     get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
> 
>     Paolo Bonzini <pbonzini@redhat.com> (commit_signer:20/74=27%)
>     Kevin Wolf <kwolf@redhat.com> (commit_signer:13/74=18%)
>     Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:13/74=18%)
>     "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:10/74=14%)
>     Peter Maydell <peter.maydell@linaro.org> (commit_signer:8/74=11%)
> 
> After:
> 
>     $ scripts/get_maintainer.pl -f MAINTAINERS 
>     qemu-devel@nongnu.org (open list:All patches CC here)
> 

Agree ... Might this also break any "unmaintained" scripts we use?

How about:
 1) Update the wiki to be clearer on the submission process, and
 2) Update the "no contributors found" output to also include the list
to send to?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
  2016-02-08 18:52   ` John Snow
@ 2016-02-08 19:04     ` Stephen Warren
  2016-02-08 19:15       ` Peter Maydell
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Warren @ 2016-02-08 19:04 UTC (permalink / raw)
  To: John Snow, Markus Armbruster; +Cc: Peter Maydell, qemu-devel

On 02/08/2016 11:52 AM, John Snow wrote:
>
>
> On 02/08/2016 04:05 AM, Markus Armbruster wrote:
>> Stephen Warren <swarren@wwwdotorg.org> writes:
>>
>>> Add an entry to MAINTAINERS that matches every patch, and requests the
>>> user send patches to qemu-devel@nongnu.org.
>>>
>>> It's not 100% obvious to project newcomers that all patches should be sent
>>> there; checkpatch doesn't say so, and since it mentions other lists to CC,
>>> the wording "the list" from the SubmitAPatch wiki page can be taken
>>> to mean only those lists, not the main list too.
>>>
>>> The F: entries were taken from a similar entry in the Linux kernel.
>>>
>>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>>> ---
>>>   MAINTAINERS | 5 +++++
>>>   1 file changed, 5 insertions(+)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b6ed87a26349..2d78eea5d62d 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -52,6 +52,11 @@ General Project Administration
>>>   ------------------------------
>>>   M: Peter Maydell <peter.maydell@linaro.org>
>>>
>>> +All patches CC here
>>> +L: qemu-devel@nongnu.org
>>> +F: *
>>> +F: */
>>> +
>>>   Responsible Disclosure, Reporting Security Issues
>>>   ------------------------------
>>>   W: http://wiki.qemu.org/SecurityProcess
>>
>> I acknowledge the problem, but your patch breaks the "No maintainers
>> found, printing recent contributors" functionality.
>>
>> Before:
>>
>>      $ scripts/get_maintainer.pl -f MAINTAINERS
>>      get_maintainer.pl: No maintainers found, printing recent contributors.
>>      get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
>>
>>      Paolo Bonzini <pbonzini@redhat.com> (commit_signer:20/74=27%)
>>      Kevin Wolf <kwolf@redhat.com> (commit_signer:13/74=18%)
>>      Stefan Hajnoczi <stefanha@redhat.com> (commit_signer:13/74=18%)
>>      "Michael S. Tsirkin" <mst@redhat.com> (commit_signer:10/74=14%)
>>      Peter Maydell <peter.maydell@linaro.org> (commit_signer:8/74=11%)
>>
>> After:
>>
>>      $ scripts/get_maintainer.pl -f MAINTAINERS
>>      qemu-devel@nongnu.org (open list:All patches CC here)
>>
>
> Agree ... Might this also break any "unmaintained" scripts we use?
>
> How about:
>   1) Update the wiki to be clearer on the submission process, and
>   2) Update the "no contributors found" output to also include the list
> to send to?

My case was that maintainers were found, but the list only included the 
maintainer (Peter) and the ARM list, but not the main qemu list. So (2) 
above wouldn't have solved my original issue.

qemu's get_maintainers.pl must be doing something different to the Linux 
kernel's version then, since IIRC the Linux kernel version always prints 
out recent contributors irrespective of whether maintainers were found, 
rather than as an alternative. I think if qemu's get_maintainers.pl 
acted in that way it would solve the problem my patch caused?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
  2016-02-08 19:04     ` Stephen Warren
@ 2016-02-08 19:15       ` Peter Maydell
  2016-02-08 19:56         ` Paolo Bonzini
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Maydell @ 2016-02-08 19:15 UTC (permalink / raw)
  To: Stephen Warren; +Cc: John Snow, Markus Armbruster, QEMU Developers

On 8 February 2016 at 19:04, Stephen Warren <swarren@wwwdotorg.org> wrote:
> qemu's get_maintainers.pl must be doing something different to the Linux
> kernel's version then, since IIRC the Linux kernel version always prints out
> recent contributors irrespective of whether maintainers were found, rather
> than as an alternative. I think if qemu's get_maintainers.pl acted in that
> way it would solve the problem my patch caused?

That difference from the kernel script's behaviour is deliberate, because
the attempt to list recent contributors tends to list a whole lot of
irrelevant people. So if there's a documented maintainer we prefer to
just list them, and not all the random other people looking at the git
logs drags up. Commit c6561586f0f8586 is where we changed the behaviour
of get_maintainer.pl and the commit message has some rationale.

thanks
-- PMM

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@
  2016-02-08 19:15       ` Peter Maydell
@ 2016-02-08 19:56         ` Paolo Bonzini
  0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2016-02-08 19:56 UTC (permalink / raw)
  To: Peter Maydell, Stephen Warren
  Cc: John Snow, Markus Armbruster, QEMU Developers



On 08/02/2016 20:15, Peter Maydell wrote:
> That difference from the kernel script's behaviour is deliberate, because
> the attempt to list recent contributors tends to list a whole lot of
> irrelevant people. So if there's a documented maintainer we prefer to
> just list them, and not all the random other people looking at the git
> logs drags up. Commit c6561586f0f8586 is where we changed the behaviour
> of get_maintainer.pl and the commit message has some rationale.

It should be enough not to check @list_to in the line that commit
c6561586f0f8586 adds:

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 7dacf32..f2ee9d8 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -636,7 +636,7 @@ sub get_maintainers {
 
     if ($email) {
 	if (! $interactive) {
-	    $email_git_fallback = 0 if @email_to > 0 || @list_to > 0 || $email_git || $email_git_blame;
+	    $email_git_fallback = 0 if @email_to > 0 || $email_git || $email_git_blame;
 	    if ($email_git_fallback) {
 	        print STDERR "get_maintainer.pl: No maintainers found, printing recent contributors.\n";
 	        print STDERR "get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.\n";

I think this makes sense.

Paolo

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-02-08 19:56 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-07 17:22 [Qemu-devel] [PATCH] MAINTAINERS: add all-match entry for qemu-devel@ Stephen Warren
2016-02-08  9:05 ` Markus Armbruster
2016-02-08 18:52   ` John Snow
2016-02-08 19:04     ` Stephen Warren
2016-02-08 19:15       ` Peter Maydell
2016-02-08 19:56         ` Paolo Bonzini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).