* [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
@ 2021-05-13 17:12 Philippe Mathieu-Daudé
2021-05-13 18:23 ` Volker Rümelin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-13 17:12 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Volker Rümelin, Philippe Mathieu-Daudé
Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
hw/input/ps2.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 72cdb80ae1c..02d7e5da723 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s)
void ps2_queue(PS2State *s, int b)
{
ps2_queue_noirq(s, b);
- s->update_irq(s->update_arg, 1);
+ ps2_raise_irq(s);
}
void ps2_queue_2(PS2State *s, int b1, int b2)
@@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2)
ps2_queue_noirq(s, b1);
ps2_queue_noirq(s, b2);
- s->update_irq(s->update_arg, 1);
+ ps2_raise_irq(s);
}
void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
@@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
ps2_queue_noirq(s, b1);
ps2_queue_noirq(s, b2);
ps2_queue_noirq(s, b3);
- s->update_irq(s->update_arg, 1);
+ ps2_raise_irq(s);
}
void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
@@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
ps2_queue_noirq(s, b2);
ps2_queue_noirq(s, b3);
ps2_queue_noirq(s, b4);
- s->update_irq(s->update_arg, 1);
+ ps2_raise_irq(s);
}
/* keycode is the untranslated scancode in the current scancode set. */
--
2.26.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
2021-05-13 17:12 [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Philippe Mathieu-Daudé
@ 2021-05-13 18:23 ` Volker Rümelin
2021-05-17 1:56 ` Bin Meng
2021-05-25 7:48 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Volker Rümelin @ 2021-05-13 18:23 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial
> Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/ps2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index 72cdb80ae1c..02d7e5da723 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s)
> void ps2_queue(PS2State *s, int b)
> {
> ps2_queue_noirq(s, b);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_2(PS2State *s, int b1, int b2)
> @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2)
>
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> ps2_queue_noirq(s, b4);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> /* keycode is the untranslated scancode in the current scancode set. */
Hi Philippe,
can you read my local qemu repository? :-)
Reviewed-by: Volker Rümelin <vr_qemu@t-online.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
2021-05-13 17:12 [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Philippe Mathieu-Daudé
2021-05-13 18:23 ` Volker Rümelin
@ 2021-05-17 1:56 ` Bin Meng
2021-05-25 7:48 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Bin Meng @ 2021-05-17 1:56 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: QEMU Trivial, Volker Rümelin, qemu-devel@nongnu.org Developers
On Fri, May 14, 2021 at 1:26 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/ps2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it
2021-05-13 17:12 [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Philippe Mathieu-Daudé
2021-05-13 18:23 ` Volker Rümelin
2021-05-17 1:56 ` Bin Meng
@ 2021-05-25 7:48 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-05-25 7:48 UTC (permalink / raw)
To: qemu-devel, Gerd Hoffmann; +Cc: qemu-trivial, Volker Rümelin
ping? (patch reviewed)
On 5/13/21 7:12 PM, Philippe Mathieu-Daudé wrote:
> Inspired-by: Volker Rümelin <vr_qemu@t-online.de>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/input/ps2.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> index 72cdb80ae1c..02d7e5da723 100644
> --- a/hw/input/ps2.c
> +++ b/hw/input/ps2.c
> @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s)
> void ps2_queue(PS2State *s, int b)
> {
> ps2_queue_noirq(s, b);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_2(PS2State *s, int b1, int b2)
> @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2)
>
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3)
> ps2_queue_noirq(s, b1);
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4)
> ps2_queue_noirq(s, b2);
> ps2_queue_noirq(s, b3);
> ps2_queue_noirq(s, b4);
> - s->update_irq(s->update_arg, 1);
> + ps2_raise_irq(s);
> }
>
> /* keycode is the untranslated scancode in the current scancode set. */
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-25 7:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-13 17:12 [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Philippe Mathieu-Daudé
2021-05-13 18:23 ` Volker Rümelin
2021-05-17 1:56 ` Bin Meng
2021-05-25 7:48 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).