From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: mmorrell@tachyum.com, alex.bennee@linaro.org,
qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH 06/11] target/rx: Handle the FPSW.DN bit in helper_set_fpsw
Date: Sat, 29 May 2021 00:34:55 +0900 [thread overview]
Message-ID: <87eedq7ty8.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20210527041405.391567-7-richard.henderson@linaro.org>
On Thu, 27 May 2021 13:14:00 +0900,
Richard Henderson wrote:
>
> Both input and output denormals flush to zero when DN is set.
>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewd-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> target/rx/op_helper.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/target/rx/op_helper.c b/target/rx/op_helper.c
> index ef904eb5f9..2139def3b2 100644
> --- a/target/rx/op_helper.c
> +++ b/target/rx/op_helper.c
> @@ -127,13 +127,20 @@ void helper_set_fpsw(CPURXState *env, uint32_t val)
> float_round_down,
> };
> uint32_t fpsw = env->fpsw;
> + bool dn;
> +
> fpsw |= 0x7fffff03;
> val &= ~0x80000000;
> fpsw &= val;
> FIELD_DP32(fpsw, FPSW, FS, FIELD_EX32(fpsw, FPSW, FLAGS) != 0);
> env->fpsw = fpsw;
> - set_float_rounding_mode(roundmode[FIELD_EX32(env->fpsw, FPSW, RM)],
> +
> + set_float_rounding_mode(roundmode[FIELD_EX32(fpsw, FPSW, RM)],
> &env->fp_status);
> +
> + dn = FIELD_EX32(env->fpsw, FPSW, DN);
> + set_flush_to_zero(dn, &env->fp_status);
> + set_flush_inputs_to_zero(dn, &env->fp_status);
> }
>
> #define FLOATOP(op, func) \
> --
> 2.25.1
>
>
next prev parent reply other threads:[~2021-05-28 15:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 4:13 [PATCH 00/11] softfloat: Improve denormal handling Richard Henderson
2021-05-27 4:13 ` [PATCH 01/11] softfloat: Rename float_flag_input_denormal to float_flag_iflush_denormal Richard Henderson
2021-06-07 15:16 ` Alex Bennée
2021-06-19 15:08 ` Philippe Mathieu-Daudé
2021-05-27 4:13 ` [PATCH 02/11] softfloat: Rename float_flag_output_denormal to float_flag_oflush_denormal Richard Henderson
2021-06-07 15:16 ` Alex Bennée
2021-06-19 15:08 ` Philippe Mathieu-Daudé
2021-05-27 4:13 ` [PATCH 03/11] softfloat: Introduce float_flag_inorm_denormal Richard Henderson
2021-05-28 17:41 ` Michael Morrell
2021-05-29 15:21 ` Richard Henderson
2021-07-14 16:44 ` Michael Morrell
2021-07-14 16:57 ` Richard Henderson
2021-07-14 17:50 ` Michael Morrell
2022-01-12 0:02 ` Michael Morrell
2021-06-07 15:35 ` Alex Bennée
2021-06-07 16:28 ` Alex Bennée
2021-06-07 16:41 ` Richard Henderson
2021-06-07 17:19 ` Alex Bennée
2021-06-07 20:52 ` Richard Henderson
2021-05-27 4:13 ` [PATCH 04/11] softfloat: Introduce float_flag_result_denormal Richard Henderson
2021-06-07 16:30 ` Alex Bennée
2021-06-19 15:10 ` Philippe Mathieu-Daudé
2021-05-27 4:13 ` [PATCH 05/11] target/i386: Use float_flag_inorm_denormal Richard Henderson
2021-06-19 18:41 ` Richard Henderson
2021-05-27 4:14 ` [PATCH 06/11] target/rx: Handle the FPSW.DN bit in helper_set_fpsw Richard Henderson
2021-05-28 15:34 ` Yoshinori Sato [this message]
2021-05-27 4:14 ` [PATCH 07/11] target/rx: Use FloatRoundMode " Richard Henderson
2021-05-28 15:35 ` Yoshinori Sato
2021-06-01 3:27 ` Philippe Mathieu-Daudé
2021-05-27 4:14 ` [PATCH 08/11] target/rx: Fix setting of FPSW.CE Richard Henderson
2021-05-28 15:35 ` Yoshinori Sato
2021-05-27 4:14 ` [PATCH 09/11] target/mips: Drop inline markers from msa_helper.c Richard Henderson
2021-06-01 3:27 ` Philippe Mathieu-Daudé
2021-05-27 4:14 ` [PATCH 10/11] target/mips: Do not check MSACSR_FS_MASK in update_msacsr Richard Henderson
2021-06-19 15:15 ` Philippe Mathieu-Daudé
2021-05-27 4:14 ` [PATCH 11/11] target/mips: Drop denormal operand to update_msacsr Richard Henderson
2021-06-01 3:29 ` Philippe Mathieu-Daudé
2021-06-07 16:31 ` [PATCH 00/11] softfloat: Improve denormal handling Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eedq7ty8.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=alex.bennee@linaro.org \
--cc=f4bug@amsat.org \
--cc=mmorrell@tachyum.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).