Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation

From: "Alex Bennée" <alex.bennee@linaro.org>
To: alvise rigo <a.rigo@virtualopensystems.com>
Cc: MTTCG Devel <mttcg@listserver.greensocs.com>,
	Claudio Fontana <claudio.fontana@huawei.com>,
	QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Jani Kokkonen <jani.kokkonen@huawei.com>,
	VirtualOpenSystems Technical Team <tech@virtualopensystems.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [RFC v7 00/16] Slow-path for atomic instruction translation
Date: Fri, 19 Feb 2016 12:19:45 +0000	[thread overview]
Message-ID: <87r3g8dh9a.fsf@linaro.org> (raw)
In-Reply-To: <CAH47eN1enbnEm31X6T4j0bZ0KOBn__JU80ZE42XeootpcipmBA@mail.gmail.com>

alvise rigo <a.rigo@virtualopensystems.com> writes:

> On Fri, Feb 19, 2016 at 12:44 PM, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> Alvise Rigo <a.rigo@virtualopensystems.com> writes:
>>
>>> This is the seventh iteration of the patch series which applies to the
>>> upstream branch of QEMU (v2.5.0-rc4).
>>>
>>> Changes versus previous versions are at the bottom of this cover letter.
>>>
>>> The code is also available at following repository:
>>> https://git.virtualopensystems.com/dev/qemu-mt.git
>>> branch:
>>> slowpath-for-atomic-v7-no-mttcg
>>
>> OK I'm done on this review pass. I think generally we are in pretty good
>> shape although I await to see what extra needs to be done for the MTTCG
>> case.
>
> Hi Alex,
>
> Thank you for this review. Regarding the extra needs and integration
> with the MTTCG code, I've made available at this address [1] a working
> branch with the two patch series merged together. The branch boots
> fine Linux on both aarch64 and arm architectures. There is still that
> known issue with virtio, that Fred should fix soon. Let me know your
> first impressions.

Does the virtio problem it go away if you drop the top patch (as per my last email)?

>
> [1] https://git.virtualopensystems.com/dev/qemu-mt.git (branch
> "merging-slowpath-v7-mttcg-v8-wip")

Thanks I'll have a look next week.

>
> Thank you,
> alvise
>
>>
>> We are coming up to soft-freeze on 1/3/16 and it would be nice to get
>> this merged by then. As it is a fairly major chunk of work it would need
>> to get the initial commit by that date.
>>
>> However before we can get to that stage we need some review from the
>> maintainers. For your next version can you please:
>>
>>   - Drop the RFC tag, I think we have had enough comment ;-)
>>   - Make sure you CC the TCG maintainers (Paolo, Peter C and Richard Henderson)
>>   - Also CC the ARM maintainers (Peter M)
>>   - Be ready for a fast turnaround
>>
>> Paolo/Richard,
>>
>> Do you have any comments on this iteration?
>>
>> --
>> Alex Bennée

--
Alex Bennée