* [PATCH] tracing: install trace events file only if necessary
@ 2023-03-26 21:04 casantos
2023-03-27 9:23 ` Daniel P. Berrangé
0 siblings, 1 reply; 6+ messages in thread
From: casantos @ 2023-03-26 21:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Carlos Santos
From: Carlos Santos <casantos@redhat.com>
It is required only if linux-user, bsd-user or system emulator is built.
Signed-off-by: Carlos Santos <casantos@redhat.com>
---
trace/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace/meson.build b/trace/meson.build
index 8e80be895c..3fb41c97a4 100644
--- a/trace/meson.build
+++ b/trace/meson.build
@@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
input: trace_events_files,
command: [ 'cat', '@INPUT@' ],
capture: true,
- install: true,
+ install: have_linux_user or have_bsd_user or have_system,
install_dir: qemu_datadir)
if 'ust' in get_option('trace_backends')
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: install trace events file only if necessary
2023-03-26 21:04 [PATCH] tracing: install trace events file only if necessary casantos
@ 2023-03-27 9:23 ` Daniel P. Berrangé
2023-03-27 14:28 ` Carlos Santos
0 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrangé @ 2023-03-27 9:23 UTC (permalink / raw)
To: casantos; +Cc: qemu-devel
On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> From: Carlos Santos <casantos@redhat.com>
>
> It is required only if linux-user, bsd-user or system emulator is built.
>
> Signed-off-by: Carlos Santos <casantos@redhat.com>
> ---
> trace/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace/meson.build b/trace/meson.build
> index 8e80be895c..3fb41c97a4 100644
> --- a/trace/meson.build
> +++ b/trace/meson.build
> @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> input: trace_events_files,
> command: [ 'cat', '@INPUT@' ],
> capture: true,
> - install: true,
> + install: have_linux_user or have_bsd_user or have_system,
Trace events are used by our command line tools too qemu-img, qemu-io,
qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
What build scenario are you seeing that does NOT want the trace events
to be present ? If there is any, then I might even call that situation
a bug, as we want trace events to be available as a debugging mechanism
for everything we build.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: install trace events file only if necessary
2023-03-27 9:23 ` Daniel P. Berrangé
@ 2023-03-27 14:28 ` Carlos Santos
2023-03-27 14:42 ` Daniel P. Berrangé
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Santos @ 2023-03-27 14:28 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel
On Mon, Mar 27, 2023 at 6:23 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> > From: Carlos Santos <casantos@redhat.com>
> >
> > It is required only if linux-user, bsd-user or system emulator is built.
> >
> > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > ---
> > trace/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/trace/meson.build b/trace/meson.build
> > index 8e80be895c..3fb41c97a4 100644
> > --- a/trace/meson.build
> > +++ b/trace/meson.build
> > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> > input: trace_events_files,
> > command: [ 'cat', '@INPUT@' ],
> > capture: true,
> > - install: true,
> > + install: have_linux_user or have_bsd_user or have_system,
>
> Trace events are used by our command line tools too qemu-img, qemu-io,
> qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
>
> What build scenario are you seeing that does NOT want the trace events
> to be present ? If there is any, then I might even call that situation
> a bug, as we want trace events to be available as a debugging mechanism
> for everything we build.
I'm aiming for an embedded system or a VM image that only needs
qemu-ga, in which qemu is built with --enable-trace-backends=nop.
--
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com T: +55-11-3534-6186
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: install trace events file only if necessary
2023-03-27 14:28 ` Carlos Santos
@ 2023-03-27 14:42 ` Daniel P. Berrangé
2023-03-27 14:44 ` Carlos Santos
0 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrangé @ 2023-03-27 14:42 UTC (permalink / raw)
To: Carlos Santos; +Cc: qemu-devel
On Mon, Mar 27, 2023 at 11:28:05AM -0300, Carlos Santos wrote:
> On Mon, Mar 27, 2023 at 6:23 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> > > From: Carlos Santos <casantos@redhat.com>
> > >
> > > It is required only if linux-user, bsd-user or system emulator is built.
> > >
> > > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > > ---
> > > trace/meson.build | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/trace/meson.build b/trace/meson.build
> > > index 8e80be895c..3fb41c97a4 100644
> > > --- a/trace/meson.build
> > > +++ b/trace/meson.build
> > > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> > > input: trace_events_files,
> > > command: [ 'cat', '@INPUT@' ],
> > > capture: true,
> > > - install: true,
> > > + install: have_linux_user or have_bsd_user or have_system,
> >
> > Trace events are used by our command line tools too qemu-img, qemu-io,
> > qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
> >
> > What build scenario are you seeing that does NOT want the trace events
> > to be present ? If there is any, then I might even call that situation
> > a bug, as we want trace events to be available as a debugging mechanism
> > for everything we build.
>
> I'm aiming for an embedded system or a VM image that only needs
> qemu-ga, in which qemu is built with --enable-trace-backends=nop.
How about
install: get_option('trace_backends') != 'nop'
?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: install trace events file only if necessary
2023-03-27 14:42 ` Daniel P. Berrangé
@ 2023-03-27 14:44 ` Carlos Santos
2023-03-27 17:31 ` Carlos Santos
0 siblings, 1 reply; 6+ messages in thread
From: Carlos Santos @ 2023-03-27 14:44 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel
On Mon, Mar 27, 2023 at 11:42 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Mon, Mar 27, 2023 at 11:28:05AM -0300, Carlos Santos wrote:
> > On Mon, Mar 27, 2023 at 6:23 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > >
> > > On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> > > > From: Carlos Santos <casantos@redhat.com>
> > > >
> > > > It is required only if linux-user, bsd-user or system emulator is built.
> > > >
> > > > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > > > ---
> > > > trace/meson.build | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/trace/meson.build b/trace/meson.build
> > > > index 8e80be895c..3fb41c97a4 100644
> > > > --- a/trace/meson.build
> > > > +++ b/trace/meson.build
> > > > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> > > > input: trace_events_files,
> > > > command: [ 'cat', '@INPUT@' ],
> > > > capture: true,
> > > > - install: true,
> > > > + install: have_linux_user or have_bsd_user or have_system,
> > >
> > > Trace events are used by our command line tools too qemu-img, qemu-io,
> > > qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
> > >
> > > What build scenario are you seeing that does NOT want the trace events
> > > to be present ? If there is any, then I might even call that situation
> > > a bug, as we want trace events to be available as a debugging mechanism
> > > for everything we build.
> >
> > I'm aiming for an embedded system or a VM image that only needs
> > qemu-ga, in which qemu is built with --enable-trace-backends=nop.
>
> How about
>
> install: get_option('trace_backends') != 'nop'
>
> ?
That would be perfect :-)
--
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com T: +55-11-3534-6186
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] tracing: install trace events file only if necessary
2023-03-27 14:44 ` Carlos Santos
@ 2023-03-27 17:31 ` Carlos Santos
0 siblings, 0 replies; 6+ messages in thread
From: Carlos Santos @ 2023-03-27 17:31 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel
On Mon, Mar 27, 2023 at 11:44 AM Carlos Santos <casantos@redhat.com> wrote:
>
> On Mon, Mar 27, 2023 at 11:42 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Mon, Mar 27, 2023 at 11:28:05AM -0300, Carlos Santos wrote:
> > > On Mon, Mar 27, 2023 at 6:23 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > > >
> > > > On Sun, Mar 26, 2023 at 06:04:46PM -0300, casantos@redhat.com wrote:
> > > > > From: Carlos Santos <casantos@redhat.com>
> > > > >
> > > > > It is required only if linux-user, bsd-user or system emulator is built.
> > > > >
> > > > > Signed-off-by: Carlos Santos <casantos@redhat.com>
> > > > > ---
> > > > > trace/meson.build | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/trace/meson.build b/trace/meson.build
> > > > > index 8e80be895c..3fb41c97a4 100644
> > > > > --- a/trace/meson.build
> > > > > +++ b/trace/meson.build
> > > > > @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all',
> > > > > input: trace_events_files,
> > > > > command: [ 'cat', '@INPUT@' ],
> > > > > capture: true,
> > > > > - install: true,
> > > > > + install: have_linux_user or have_bsd_user or have_system,
> > > >
> > > > Trace events are used by our command line tools too qemu-img, qemu-io,
> > > > qemu-nbd, qemu-pr-helper, qemu-storage-daemon.
> > > >
> > > > What build scenario are you seeing that does NOT want the trace events
> > > > to be present ? If there is any, then I might even call that situation
> > > > a bug, as we want trace events to be available as a debugging mechanism
> > > > for everything we build.
> > >
> > > I'm aiming for an embedded system or a VM image that only needs
> > > qemu-ga, in which qemu is built with --enable-trace-backends=nop.
> >
> > How about
> >
> > install: get_option('trace_backends') != 'nop'
> >
> > ?
>
> That would be perfect :-)
>
> --
> Carlos Santos
> Senior Software Maintenance Engineer
> Red Hat
> casantos@redhat.com T: +55-11-3534-6186
I submitted an updated patch. Thanks.
--
Carlos Santos
Senior Software Maintenance Engineer
Red Hat
casantos@redhat.com T: +55-11-3534-6186
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-03-27 17:32 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-26 21:04 [PATCH] tracing: install trace events file only if necessary casantos
2023-03-27 9:23 ` Daniel P. Berrangé
2023-03-27 14:28 ` Carlos Santos
2023-03-27 14:42 ` Daniel P. Berrangé
2023-03-27 14:44 ` Carlos Santos
2023-03-27 17:31 ` Carlos Santos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).