From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command
Date: Thu, 24 Oct 2019 17:07:37 +0200 [thread overview]
Message-ID: <a257d4e0-05ef-c6c9-ca32-e628bca8154a@redhat.com> (raw)
In-Reply-To: <20191009132252.17860-4-imammedo@redhat.com>
Hi Igor,
On 10/9/19 3:22 PM, Igor Mammedov wrote:
> Extend CPU hotplug interface to return architecture specific
> identifier for current CPU (in case of x86, it's APIC ID).
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> TODO:
> * cripple it to behave old way on old machine types so that
> new firmware started on new QEMU won't see a difference
> when migrated to an old QEMU (i.e. QEMU that doesn't support
> this command)
> ---
> docs/specs/acpi_cpu_hotplug.txt | 10 +++++++++-
> hw/acpi/cpu.c | 15 +++++++++++++++
> hw/acpi/trace-events | 1 +
> 3 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/docs/specs/acpi_cpu_hotplug.txt b/docs/specs/acpi_cpu_hotplug.txt
> index 43c5a193f0..0438678249 100644
> --- a/docs/specs/acpi_cpu_hotplug.txt
> +++ b/docs/specs/acpi_cpu_hotplug.txt
> @@ -32,7 +32,9 @@ Register block size:
>
> read access:
> offset:
> - [0x0-0x3] reserved
> + [0x0-0x3] Command data 2: (DWORD access)
> + upper 32 bit of 'Command data' if returned data value is 64 bit.
> + in case of error or unsupported command reads is 0x0
> [0x4] CPU device status fields: (1 byte access)
> bits:
> 0: Device is enabled and may be used by guest
> @@ -87,6 +89,8 @@ write access:
> 2: stores value into OST status register, triggers
> ACPI_DEVICE_OST QMP event from QEMU to external applications
> with current values of OST event and status registers.
> + 3: OSPM reads architecture specific value identifying CPU
> + (x86: APIC ID)
> other values: reserved
>
> Selecting CPU device beyond possible range has no effect on platform:
> @@ -115,3 +119,7 @@ Typical usecases:
> 5.2 if 'Command data' register has not changed, there is not CPU
> corresponding to iterator value and the last valid iterator value
> equals to 'max_cpus' + 1
> + - Get architecture specific id for a CPU
> + 1. pick a CPU to read from using 'CPU selector' register
> + 2. write 0x3 int0 'Command field' register
> + 3. read architecture specific id from 'Command data' register
> diff --git a/hw/acpi/cpu.c b/hw/acpi/cpu.c
> index 87f30a31d7..701542d860 100644
> --- a/hw/acpi/cpu.c
> +++ b/hw/acpi/cpu.c
> @@ -12,11 +12,13 @@
> #define ACPI_CPU_FLAGS_OFFSET_RW 4
> #define ACPI_CPU_CMD_OFFSET_WR 5
> #define ACPI_CPU_CMD_DATA_OFFSET_RW 8
> +#define ACPI_CPU_CMD_DATA2_OFFSET_RW 0
This part confuses me:
#define ACPI_CPU_SELECTOR_OFFSET_WR 0
#define ACPI_CPU_CMD_DATA2_OFFSET_RW 0
What about:
#define ACPI_CPU_SELECTOR_OFFSET_W 0
#define ACPI_CPU_CMD_DATA2_OFFSET_R 0
>
> enum {
> CPHP_GET_NEXT_CPU_WITH_EVENT_CMD = 0,
> CPHP_OST_EVENT_CMD = 1,
> CPHP_OST_STATUS_CMD = 2,
> + CPHP_GET_CPU_ID_CMD = 3,
> CPHP_CMD_MAX
> };
>
> @@ -74,11 +76,24 @@ static uint64_t cpu_hotplug_rd(void *opaque, hwaddr addr, unsigned size)
> case CPHP_GET_NEXT_CPU_WITH_EVENT_CMD:
> val = cpu_st->selector;
> break;
> + case CPHP_GET_CPU_ID_CMD:
> + val = cpu_to_le64(cdev->arch_id) & 0xFFFFFFFF;
> + break;
> default:
> break;
> }
> trace_cpuhp_acpi_read_cmd_data(cpu_st->selector, val);
> break;
> + case ACPI_CPU_CMD_DATA2_OFFSET_RW:
> + switch (cpu_st->command) {
> + case CPHP_GET_CPU_ID_CMD:
> + val = cpu_to_le64(cdev->arch_id) >> 32;
> + break;
> + default:
> + break;
> + }
> + trace_cpuhp_acpi_read_cmd_data2(cpu_st->selector, val);
> + break;
> default:
> break;
> }
> diff --git a/hw/acpi/trace-events b/hw/acpi/trace-events
> index 96b8273297..afbc77de1c 100644
> --- a/hw/acpi/trace-events
> +++ b/hw/acpi/trace-events
> @@ -23,6 +23,7 @@ cpuhp_acpi_read_flags(uint32_t idx, uint8_t flags) "idx[0x%"PRIx32"] flags: 0x%"
> cpuhp_acpi_write_idx(uint32_t idx) "set active cpu idx: 0x%"PRIx32
> cpuhp_acpi_write_cmd(uint32_t idx, uint8_t cmd) "idx[0x%"PRIx32"] cmd: 0x%"PRIx8
> cpuhp_acpi_read_cmd_data(uint32_t idx, uint32_t data) "idx[0x%"PRIx32"] data: 0x%"PRIx32
> +cpuhp_acpi_read_cmd_data2(uint32_t idx, uint32_t data) "idx[0x%"PRIx32"] data: 0x%"PRIx32
> cpuhp_acpi_cpu_has_events(uint32_t idx, bool ins, bool rm) "idx[0x%"PRIx32"] inserting: %d, removing: %d"
> cpuhp_acpi_clear_inserting_evt(uint32_t idx) "idx[0x%"PRIx32"]"
> cpuhp_acpi_clear_remove_evt(uint32_t idx) "idx[0x%"PRIx32"]"
>
next prev parent reply other threads:[~2019-10-24 16:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:22 [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface Igor Mammedov
2019-10-09 13:22 ` [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec Igor Mammedov
2019-10-10 12:33 ` Laszlo Ersek
2019-10-17 15:41 ` Igor Mammedov
2019-10-18 13:24 ` Laszlo Ersek
2019-10-10 13:31 ` Laszlo Ersek
2019-10-10 13:36 ` Laszlo Ersek
2019-10-22 17:17 ` Christophe de Dinechin
2019-10-22 17:37 ` Laszlo Ersek
2019-10-09 13:22 ` [RFC 2/3] acpi: cpuhp: add typical usecases into spec Igor Mammedov
2019-10-10 13:04 ` Laszlo Ersek
2019-10-10 13:15 ` Laszlo Ersek
2019-10-10 14:13 ` Laszlo Ersek
2019-10-18 14:45 ` Igor Mammedov
2019-10-09 13:22 ` [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Igor Mammedov
2019-10-10 14:56 ` Laszlo Ersek
2019-10-10 15:06 ` Michael S. Tsirkin
2019-10-10 17:23 ` Igor Mammedov
2019-10-10 17:53 ` Laszlo Ersek
2019-10-10 19:26 ` Eduardo Habkost
2019-10-11 8:07 ` Laszlo Ersek
2019-10-18 16:18 ` Igor Mammedov
2019-10-21 13:06 ` Laszlo Ersek
2019-10-22 12:39 ` Laszlo Ersek
2019-10-22 14:42 ` Igor Mammedov
2019-10-22 15:49 ` Laszlo Ersek
2019-10-23 14:59 ` Igor Mammedov
2019-10-24 15:07 ` Philippe Mathieu-Daudé [this message]
2019-10-10 9:56 ` [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface Michael S. Tsirkin
2019-10-10 13:39 ` Igor Mammedov
2019-10-10 13:59 ` Michael S. Tsirkin
2019-10-10 15:57 ` Igor Mammedov
2019-10-10 18:15 ` Michael S. Tsirkin
2019-10-11 7:41 ` Laszlo Ersek
2019-10-10 19:20 ` Eduardo Habkost
2019-10-11 8:01 ` Laszlo Ersek
2019-10-11 13:00 ` Michael S. Tsirkin
2019-10-11 16:13 ` Laszlo Ersek
2019-10-11 10:47 ` Igor Mammedov
2019-10-11 6:54 ` Laszlo Ersek
2019-10-10 14:16 ` Eduardo Habkost
2019-10-10 14:49 ` Michael S. Tsirkin
2019-10-10 17:09 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a257d4e0-05ef-c6c9-ca32-e628bca8154a@redhat.com \
--to=philmd@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).