From: Laszlo Ersek <lersek@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec
Date: Fri, 18 Oct 2019 15:24:46 +0200 [thread overview]
Message-ID: <ff1c3dad-061a-8aee-a15c-fc0215b43bef@redhat.com> (raw)
In-Reply-To: <20191017174106.5b2c59d0@redhat.com>
On 10/17/19 17:41, Igor Mammedov wrote:
> On Thu, 10 Oct 2019 14:33:19 +0200
> Laszlo Ersek <lersek@redhat.com> wrote:
>
>> On 10/09/19 15:22, Igor Mammedov wrote:
>>> QEMU returns 0, in case of erro or invalid value in 'Command field',
>>> make spec match reality, i.e.
>>
>> Unfinished thought?
> yep, I'll fix it up.
>
> [...]
>>> index ee219c8358..ac5903b2b1 100644
>>> --- a/docs/specs/acpi_cpu_hotplug.txt
>>> +++ b/docs/specs/acpi_cpu_hotplug.txt
>>> @@ -44,9 +44,10 @@ read access:
>>> 3-7: reserved and should be ignored by OSPM
>>> [0x5-0x7] reserved
>>> [0x8] Command data: (DWORD access)
>>
>> since we're fixing this dword field description, can you spell out the
>> endianness too?
> Since it's ACPI oriented interface (i.e. guest AML LE access implied),
> I'd prefer to spell it out once in spec so it would cover all integer
> fields vs doing it per filed. (less chance to make mistake later)
Makes sense, thanks!
Laszlo
>> (I think endianness is relevant here, because patch#2 suggests selectors
>> can be looped over. So selectors are actual integers, not just 32-bit
>> opaque blobs.)
>>
>>> - in case of error or unsupported command reads is 0xFFFFFFFF
>>> + in case of error or unsupported command reads is 0x0
>>> current 'Command field' value:
>>> - 0: returns PXM value corresponding to device
>>> + 0: returns CPU selector value corresponding to a CPU with
>>> + pending event.
>>>
>>> write access:
>>> offset:
>>>
>>
>> Thanks!
>> Laszlo
>>
>
next prev parent reply other threads:[~2019-10-18 13:25 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:22 [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface Igor Mammedov
2019-10-09 13:22 ` [RFC 1/3] acpi: cpuhp: fix 'Command data' description is spec Igor Mammedov
2019-10-10 12:33 ` Laszlo Ersek
2019-10-17 15:41 ` Igor Mammedov
2019-10-18 13:24 ` Laszlo Ersek [this message]
2019-10-10 13:31 ` Laszlo Ersek
2019-10-10 13:36 ` Laszlo Ersek
2019-10-22 17:17 ` Christophe de Dinechin
2019-10-22 17:37 ` Laszlo Ersek
2019-10-09 13:22 ` [RFC 2/3] acpi: cpuhp: add typical usecases into spec Igor Mammedov
2019-10-10 13:04 ` Laszlo Ersek
2019-10-10 13:15 ` Laszlo Ersek
2019-10-10 14:13 ` Laszlo Ersek
2019-10-18 14:45 ` Igor Mammedov
2019-10-09 13:22 ` [RFC 3/3] acpi: cpuhp: add CPHP_GET_CPU_ID_CMD command Igor Mammedov
2019-10-10 14:56 ` Laszlo Ersek
2019-10-10 15:06 ` Michael S. Tsirkin
2019-10-10 17:23 ` Igor Mammedov
2019-10-10 17:53 ` Laszlo Ersek
2019-10-10 19:26 ` Eduardo Habkost
2019-10-11 8:07 ` Laszlo Ersek
2019-10-18 16:18 ` Igor Mammedov
2019-10-21 13:06 ` Laszlo Ersek
2019-10-22 12:39 ` Laszlo Ersek
2019-10-22 14:42 ` Igor Mammedov
2019-10-22 15:49 ` Laszlo Ersek
2019-10-23 14:59 ` Igor Mammedov
2019-10-24 15:07 ` Philippe Mathieu-Daudé
2019-10-10 9:56 ` [RFC 0/3] acpi: cphp: add CPHP_GET_CPU_ID_CMD command to cpu hotplug MMIO interface Michael S. Tsirkin
2019-10-10 13:39 ` Igor Mammedov
2019-10-10 13:59 ` Michael S. Tsirkin
2019-10-10 15:57 ` Igor Mammedov
2019-10-10 18:15 ` Michael S. Tsirkin
2019-10-11 7:41 ` Laszlo Ersek
2019-10-10 19:20 ` Eduardo Habkost
2019-10-11 8:01 ` Laszlo Ersek
2019-10-11 13:00 ` Michael S. Tsirkin
2019-10-11 16:13 ` Laszlo Ersek
2019-10-11 10:47 ` Igor Mammedov
2019-10-11 6:54 ` Laszlo Ersek
2019-10-10 14:16 ` Eduardo Habkost
2019-10-10 14:49 ` Michael S. Tsirkin
2019-10-10 17:09 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff1c3dad-061a-8aee-a15c-fc0215b43bef@redhat.com \
--to=lersek@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).