* [Qemu-devel] [PATCH] modules-test: fix const cast
@ 2019-08-22 17:42 Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
` (3 more replies)
0 siblings, 4 replies; 13+ messages in thread
From: Paolo Bonzini @ 2019-08-22 17:42 UTC (permalink / raw)
To: qemu-devel; +Cc: marcandre.lureau, peter.maydell
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/modules-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/modules-test.c b/tests/modules-test.c
index 3aef0e5..a8118e9 100644
--- a/tests/modules-test.c
+++ b/tests/modules-test.c
@@ -4,7 +4,7 @@
static void test_modules_load(const void *data)
{
QTestState *qts;
- const char **args = data;
+ const char **args = (const char **)data;
qts = qtest_init(NULL);
qtest_module_load(qts, args[0], args[1]);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
@ 2019-08-23 7:13 ` Marc-André Lureau
2019-08-23 9:06 ` Thomas Huth
` (2 subsequent siblings)
3 siblings, 0 replies; 13+ messages in thread
From: Marc-André Lureau @ 2019-08-23 7:13 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Peter Maydell, QEMU
On Thu, Aug 22, 2019 at 9:42 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/modules-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index 3aef0e5..a8118e9 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -4,7 +4,7 @@
> static void test_modules_load(const void *data)
> {
> QTestState *qts;
> - const char **args = data;
> + const char **args = (const char **)data;
>
> qts = qtest_init(NULL);
> qtest_module_load(qts, args[0], args[1]);
> --
> 1.8.3.1
>
>
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
@ 2019-08-23 9:06 ` Thomas Huth
2019-08-23 9:11 ` Peter Maydell
2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
3 siblings, 1 reply; 13+ messages in thread
From: Thomas Huth @ 2019-08-23 9:06 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: marcandre.lureau, peter.maydell
On 8/22/19 7:42 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/modules-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index 3aef0e5..a8118e9 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -4,7 +4,7 @@
> static void test_modules_load(const void *data)
> {
> QTestState *qts;
> - const char **args = data;
> + const char **args = (const char **)data;
>
> qts = qtest_init(NULL);
> qtest_module_load(qts, args[0], args[1]);
Why did nobody notice this before? ... some additional words in the
patch description would be fine.
Anyway:
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 9:06 ` Thomas Huth
@ 2019-08-23 9:11 ` Peter Maydell
2019-08-23 12:04 ` Paolo Bonzini
0 siblings, 1 reply; 13+ messages in thread
From: Peter Maydell @ 2019-08-23 9:11 UTC (permalink / raw)
To: Thomas Huth; +Cc: Paolo Bonzini, QEMU Developers, Marc-André Lureau
On Fri, 23 Aug 2019 at 10:06, Thomas Huth <thuth@redhat.com> wrote:
>
> On 8/22/19 7:42 PM, Paolo Bonzini wrote:
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > tests/modules-test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/modules-test.c b/tests/modules-test.c
> > index 3aef0e5..a8118e9 100644
> > --- a/tests/modules-test.c
> > +++ b/tests/modules-test.c
> > @@ -4,7 +4,7 @@
> > static void test_modules_load(const void *data)
> > {
> > QTestState *qts;
> > - const char **args = data;
> > + const char **args = (const char **)data;
> >
> > qts = qtest_init(NULL);
> > qtest_module_load(qts, args[0], args[1]);
>
> Why did nobody notice this before? ... some additional words in the
> patch description would be fine.
It got into the tree because I don't have an --enable-modules
config in my set of things I run before merging. It's in
the Travis build set, but that only runs after the fact.
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 9:11 ` Peter Maydell
@ 2019-08-23 12:04 ` Paolo Bonzini
2019-08-23 12:07 ` Peter Maydell
0 siblings, 1 reply; 13+ messages in thread
From: Paolo Bonzini @ 2019-08-23 12:04 UTC (permalink / raw)
To: Peter Maydell, Thomas Huth; +Cc: Marc-André Lureau, QEMU Developers
On 23/08/19 11:11, Peter Maydell wrote:
> On Fri, 23 Aug 2019 at 10:06, Thomas Huth <thuth@redhat.com> wrote:
>>
>> On 8/22/19 7:42 PM, Paolo Bonzini wrote:
>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>> ---
>>> tests/modules-test.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tests/modules-test.c b/tests/modules-test.c
>>> index 3aef0e5..a8118e9 100644
>>> --- a/tests/modules-test.c
>>> +++ b/tests/modules-test.c
>>> @@ -4,7 +4,7 @@
>>> static void test_modules_load(const void *data)
>>> {
>>> QTestState *qts;
>>> - const char **args = data;
>>> + const char **args = (const char **)data;
>>>
>>> qts = qtest_init(NULL);
>>> qtest_module_load(qts, args[0], args[1]);
>>
>> Why did nobody notice this before? ... some additional words in the
>> patch description would be fine.
>
> It got into the tree because I don't have an --enable-modules
> config in my set of things I run before merging. It's in
> the Travis build set, but that only runs after the fact.
Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
not built as module" to qemu.git directly?
Thanks in advance,
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 12:04 ` Paolo Bonzini
@ 2019-08-23 12:07 ` Peter Maydell
2019-08-23 12:10 ` Paolo Bonzini
0 siblings, 1 reply; 13+ messages in thread
From: Peter Maydell @ 2019-08-23 12:07 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Marc-André Lureau, Thomas Huth, QEMU Developers
On Fri, 23 Aug 2019 at 13:04, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 23/08/19 11:11, Peter Maydell wrote:
> > On Fri, 23 Aug 2019 at 10:06, Thomas Huth <thuth@redhat.com> wrote:
> >>
> >> On 8/22/19 7:42 PM, Paolo Bonzini wrote:
> >>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> >>> ---
> >>> tests/modules-test.c | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/tests/modules-test.c b/tests/modules-test.c
> >>> index 3aef0e5..a8118e9 100644
> >>> --- a/tests/modules-test.c
> >>> +++ b/tests/modules-test.c
> >>> @@ -4,7 +4,7 @@
> >>> static void test_modules_load(const void *data)
> >>> {
> >>> QTestState *qts;
> >>> - const char **args = data;
> >>> + const char **args = (const char **)data;
> >>>
> >>> qts = qtest_init(NULL);
> >>> qtest_module_load(qts, args[0], args[1]);
> >>
> >> Why did nobody notice this before? ... some additional words in the
> >> patch description would be fine.
> >
> > It got into the tree because I don't have an --enable-modules
> > config in my set of things I run before merging. It's in
> > the Travis build set, but that only runs after the fact.
>
> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> not built as module" to qemu.git directly?
Is the other one also needed as a build fix ?
I was planning to apply this one directly, yes, but I was
waiting to see if you and Thomas wanted to agree any change
to the commit message.
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 12:07 ` Peter Maydell
@ 2019-08-23 12:10 ` Paolo Bonzini
2019-08-23 12:11 ` Thomas Huth
2019-08-27 12:00 ` Peter Maydell
0 siblings, 2 replies; 13+ messages in thread
From: Paolo Bonzini @ 2019-08-23 12:10 UTC (permalink / raw)
To: Peter Maydell; +Cc: Marc-André Lureau, Thomas Huth, QEMU Developers
On 23/08/19 14:07, Peter Maydell wrote:
>> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
>> not built as module" to qemu.git directly?
> Is the other one also needed as a build fix ?
Yes, otherwise the test fails (it didn't fail in the meson tree).
> I was planning to apply this one directly, yes, but I was
> waiting to see if you and Thomas wanted to agree any change
> to the commit message.
Just "Fix build failure with --enable-modules" would be as verbose as it
needs to be, I guess.
Paolo
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 12:10 ` Paolo Bonzini
@ 2019-08-23 12:11 ` Thomas Huth
2019-08-27 12:00 ` Peter Maydell
1 sibling, 0 replies; 13+ messages in thread
From: Thomas Huth @ 2019-08-23 12:11 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell; +Cc: Marc-André Lureau, QEMU Developers
On 8/23/19 2:10 PM, Paolo Bonzini wrote:
> On 23/08/19 14:07, Peter Maydell wrote:
>>> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
>>> not built as module" to qemu.git directly?
>> Is the other one also needed as a build fix ?
>
> Yes, otherwise the test fails (it didn't fail in the meson tree).
>
>> I was planning to apply this one directly, yes, but I was
>> waiting to see if you and Thomas wanted to agree any change
>> to the commit message.
>
> Just "Fix build failure with --enable-modules" would be as verbose as it
> needs to be, I guess.
Fine for me.
Thomas
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
2019-08-23 9:06 ` Thomas Huth
@ 2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
3 siblings, 0 replies; 13+ messages in thread
From: Miroslav Rezanina @ 2019-08-23 12:32 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: marcandre.lureau, qemu-devel, peter.maydell
On Thu, Aug 22, 2019 at 07:42:13PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/modules-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index 3aef0e5..a8118e9 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -4,7 +4,7 @@
> static void test_modules_load(const void *data)
> {
> QTestState *qts;
> - const char **args = data;
> + const char **args = (const char **)data;
>
> qts = qtest_init(NULL);
> qtest_module_load(qts, args[0], args[1]);
> --
> 1.8.3.1
>
>
Reviewed-by: Miroslav Rezanina <mrezanin@redhat.com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
` (2 preceding siblings ...)
2019-08-23 12:32 ` Miroslav Rezanina
@ 2019-08-23 14:13 ` Peter Maydell
3 siblings, 0 replies; 13+ messages in thread
From: Peter Maydell @ 2019-08-23 14:13 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Marc-André Lureau, QEMU Developers
On Thu, 22 Aug 2019 at 18:42, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/modules-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index 3aef0e5..a8118e9 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -4,7 +4,7 @@
> static void test_modules_load(const void *data)
> {
> QTestState *qts;
> - const char **args = data;
> + const char **args = (const char **)data;
>
> qts = qtest_init(NULL);
> qtest_module_load(qts, args[0], args[1]);
> --
> 1.8.3.1
Applied to master as a build fix, thanks.
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-23 12:10 ` Paolo Bonzini
2019-08-23 12:11 ` Thomas Huth
@ 2019-08-27 12:00 ` Peter Maydell
2019-08-27 13:38 ` Marc-André Lureau
1 sibling, 1 reply; 13+ messages in thread
From: Peter Maydell @ 2019-08-27 12:00 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Marc-André Lureau, Thomas Huth, QEMU Developers
On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 23/08/19 14:07, Peter Maydell wrote:
> >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> >> not built as module" to qemu.git directly?
> > Is the other one also needed as a build fix ?
>
> Yes, otherwise the test fails (it didn't fail in the meson tree).
Both this fix and the ui-spice-app one are now in master, but
the 'enable-modules' Travis build still seems to be consistently
failing -- could somebody take a look, please?
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-27 12:00 ` Peter Maydell
@ 2019-08-27 13:38 ` Marc-André Lureau
2019-08-27 14:26 ` Peter Maydell
0 siblings, 1 reply; 13+ messages in thread
From: Marc-André Lureau @ 2019-08-27 13:38 UTC (permalink / raw)
To: Peter Maydell; +Cc: Paolo Bonzini, Thomas Huth, QEMU Developers
Hi
On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> >
> > On 23/08/19 14:07, Peter Maydell wrote:
> > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> > >> not built as module" to qemu.git directly?
> > > Is the other one also needed as a build fix ?
> >
> > Yes, otherwise the test fails (it didn't fail in the meson tree).
>
> Both this fix and the ui-spice-app one are now in master, but
> the 'enable-modules' Travis build still seems to be consistently
> failing -- could somebody take a look, please?
>
I am looking at, it seems to be related to default machine
MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64
QTEST_QEMU_IMG=qemu-img tests/modules-test -m=quick -k --tap <
/dev/null | ./scripts/tap-driver.pl --test-name="modules-test"
qemu-system-aarch64: -machine accel=qtest: No machine specified, and
there is no default
Use -machine help to list supported machines
TEST iotest-qcow2: 159
socket_accept failed: Resource temporarily unavailable
**
ERROR:tests/libqtest.c:268:qtest_init_without_qmp_handshake: assertion
failed: (s->fd >= 0 && s->qmp_fd >= 0)
tests/libqtest.c:137: kill_qemu() tried to terminate QEMU process but
encountered exit status 1
Aborted (core dumped)
ERROR - too few tests run (expected 9, got 0)
/home/travis/build/elmarco/qemu/tests/Makefile.include:900: recipe for
target 'check-qtest-arm' failed
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Qemu-devel] [PATCH] modules-test: fix const cast
2019-08-27 13:38 ` Marc-André Lureau
@ 2019-08-27 14:26 ` Peter Maydell
0 siblings, 0 replies; 13+ messages in thread
From: Peter Maydell @ 2019-08-27 14:26 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: Paolo Bonzini, Thomas Huth, QEMU Developers
On Tue, 27 Aug 2019 at 14:39, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
>
> Hi
>
> On Tue, Aug 27, 2019 at 4:02 PM Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > On Fri, 23 Aug 2019 at 13:10, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > >
> > > On 23/08/19 14:07, Peter Maydell wrote:
> > > >> Are you going to apply this and "[PATCH] modules-test: ui-spice-app is
> > > >> not built as module" to qemu.git directly?
> > > > Is the other one also needed as a build fix ?
> > >
> > > Yes, otherwise the test fails (it didn't fail in the meson tree).
> >
> > Both this fix and the ui-spice-app one are now in master, but
> > the 'enable-modules' Travis build still seems to be consistently
> > failing -- could somebody take a look, please?
> >
>
> I am looking at, it seems to be related to default machine
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64
> QTEST_QEMU_IMG=qemu-img tests/modules-test -m=quick -k --tap <
> /dev/null | ./scripts/tap-driver.pl --test-name="modules-test"
>
> qemu-system-aarch64: -machine accel=qtest: No machine specified, and
> there is no default
>
> Use -machine help to list supported machines
Yeah, you need a machine type. If you need to run code on the
QEMU instance you need to know what machine type you're expecting;
if you aren't and you're just doing qtest stuff then -machine none
may be appropriate.
thanks
-- PMM
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2019-08-27 14:27 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-22 17:42 [Qemu-devel] [PATCH] modules-test: fix const cast Paolo Bonzini
2019-08-23 7:13 ` Marc-André Lureau
2019-08-23 9:06 ` Thomas Huth
2019-08-23 9:11 ` Peter Maydell
2019-08-23 12:04 ` Paolo Bonzini
2019-08-23 12:07 ` Peter Maydell
2019-08-23 12:10 ` Paolo Bonzini
2019-08-23 12:11 ` Thomas Huth
2019-08-27 12:00 ` Peter Maydell
2019-08-27 13:38 ` Marc-André Lureau
2019-08-27 14:26 ` Peter Maydell
2019-08-23 12:32 ` Miroslav Rezanina
2019-08-23 14:13 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).