All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: linux-kernel@vger.kernel.org
Cc: intel-gfx@lists.freedesktop.org,
	Chris Wilson <chris@chris-wilson.co.uk>,
	Shawn Starr <shawn.starr@rogers.com>,
	Jiri Kosina <jkosina@suse.cz>,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: [PATCH] drm/i915: Flush writes to GMBUS registers
Date: Mon, 18 Mar 2013 11:13:05 +0000	[thread overview]
Message-ID: <1363605185-4030-1-git-send-email-chris@chris-wilson.co.uk> (raw)
In-Reply-To: <alpine.LNX.2.00.1303151424140.9529@pobox.suse.cz>

If we do not complete the writes to the GMBUS registers, they remain
active for an indefinite period of time afterwards, even causing
spurious interrupts on gm45.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://lkml.kernel.org/r/alpine.LNX.2.00.1303151424140.9529@pobox.suse.cz
Cc: Shawn Starr <shawn.starr@rogers.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/i915/intel_i2c.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c
index acf8aec..ca6c17e 100644
--- a/drivers/gpu/drm/i915/intel_i2c.c
+++ b/drivers/gpu/drm/i915/intel_i2c.c
@@ -64,6 +64,7 @@ intel_i2c_reset(struct drm_device *dev)
 	struct drm_i915_private *dev_priv = dev->dev_private;
 	I915_WRITE(dev_priv->gpio_mmio_base + GMBUS0, 0);
 	I915_WRITE(dev_priv->gpio_mmio_base + GMBUS4, 0);
+	POSTING_READ(dev_priv->gpio_mmio_base + GMBUS4);
 }
 
 static void intel_i2c_quirk_set(struct drm_i915_private *dev_priv, bool enable)
@@ -232,6 +233,7 @@ gmbus_wait_hw_status(struct drm_i915_private *dev_priv,
 	finish_wait(&dev_priv->gmbus_wait_queue, &wait);
 
 	I915_WRITE(GMBUS4 + reg_offset, 0);
+	POSTING_READ(GMBUS4 + reg_offset);
 
 	if (gmbus2 & GMBUS_SATOER)
 		return -ENXIO;
@@ -257,6 +259,7 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)
 	ret = wait_event_timeout(dev_priv->gmbus_wait_queue, C, 10);
 
 	I915_WRITE(GMBUS4 + reg_offset, 0);
+	POSTING_READ(GMBUS4 + reg_offset);
 
 	if (ret)
 		return 0;
@@ -486,6 +489,7 @@ timeout:
 	ret = i2c_bit_algo.master_xfer(adapter, msgs, num);
 
 out:
+	POSTING_READ(GMBUS0 + dev_priv->gpio_mmio_base);
 	mutex_unlock(&dev_priv->gmbus_mutex);
 	return ret;
 }
-- 
1.7.10.4


  parent reply	other threads:[~2013-03-18 11:13 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-08 19:12 [3.9-rc1] very poor interrupt responses Shawn Starr
2013-03-08 21:33 ` [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses) Peter Hurley
2013-03-09  2:19   ` Alan Stern
2013-03-09  8:53     ` Thomas Meyer
2013-03-09 13:07       ` Peter Hurley
2013-03-13 21:35         ` Jiri Kosina
2013-03-14 14:51           ` Alan Stern
2013-03-14 14:51             ` Alan Stern
2013-03-14 14:56             ` Jiri Kosina
2013-03-14 15:18               ` Alan Stern
2013-03-14 15:18                 ` Alan Stern
2013-03-14 15:39                 ` Jiri Kosina
2013-03-14 15:47                   ` Jiri Kosina
2013-03-14 16:10                   ` Alan Stern
2013-03-14 16:10                     ` Alan Stern
2013-03-14 16:13                   ` Alan Stern
2013-03-14 16:13                     ` Alan Stern
2013-03-14 16:09               ` Jiri Kosina
2013-03-14 16:42                 ` Peter Hurley
2013-03-14 16:46                 ` Rafael J. Wysocki
2013-03-14 17:06                   ` Peter Hurley
2013-03-14 17:22                     ` Rafael J. Wysocki
2013-03-14 17:26                       ` Peter Hurley
2013-03-15  7:59                       ` Jiri Kosina
2013-03-15  9:20                         ` Harald Arnesen
2013-03-15 13:33                           ` Jiri Kosina
2013-03-15 13:33                             ` Jiri Kosina
2013-03-15 15:14                             ` Jiri Kosina
2013-03-15 19:14                               ` Yinghai Lu
2013-03-18  2:41                                 ` Shawn Starr
2013-03-18  9:12                                 ` Jiri Kosina
2013-03-18 18:57                                   ` Yinghai Lu
2013-03-18 22:05                                     ` Jiri Kosina
2013-03-18 22:50                                       ` Yinghai Lu
     [not found]                                   ` <alpine.LNX.2.00.1303181010080.9529-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2013-03-18 19:19                                     ` Daniel Vetter
2013-03-18 19:19                                       ` Daniel Vetter
2013-03-18 19:57                                       ` Chris Wilson
2013-03-18 22:04                                       ` Jiri Kosina
2013-03-15 15:32                             ` Greg KH
2013-03-15 15:37                               ` Jiri Kosina
2013-03-15 15:47                                 ` Greg KH
2013-03-15 16:21                                   ` Jiri Kosina
2013-03-18  8:21                                   ` Daniel Vetter
2013-03-18 15:56                                     ` [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses)) Jiri Kosina
2013-03-18 17:04                                       ` Chris Wilson
2013-03-19  8:56                                         ` Jiri Kosina
2013-03-19  9:03                                           ` Chris Wilson
2013-03-18 19:21                                       ` Daniel Vetter
2013-03-18 11:13                             ` Chris Wilson [this message]
2013-03-18 11:51                               ` [PATCH] drm/i915: Flush writes to GMBUS registers Jiri Kosina
2013-03-18 12:48                                 ` Chris Wilson
2013-03-14 18:48           ` [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses) Yinghai Lu
2013-03-11  3:38 ` [3.9-rc1] very poor interrupt responses Rafael J. Wysocki
2013-03-11 10:09   ` Harald Arnesen
2013-03-11 14:55     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1363605185-4030-1-git-send-email-chris@chris-wilson.co.uk \
    --to=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn.starr@rogers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.