[PATCH 03/10] arm: perf: add additional validation to set_event_filter

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Andrew Murray <andrew.murray@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org
Cc: linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 03/10] arm: perf: add additional validation to set_event_filter
Date: Fri, 16 Nov 2018 10:24:06 +0000	[thread overview]
Message-ID: <1542363853-13849-4-git-send-email-andrew.murray@arm.com> (raw)
In-Reply-To: <1542363853-13849-1-git-send-email-andrew.murray@arm.com>

The armv7pmu driver doesn't support host/guest mode exclusion so
let's report this when set_event_filter is called with these
exclusion flags set.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 arch/arm/kernel/perf_event_v7.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
index a4fb0f8..c4c9fbb 100644
--- a/arch/arm/kernel/perf_event_v7.c
+++ b/arch/arm/kernel/perf_event_v7.c
@@ -1074,6 +1074,8 @@ static int armv7pmu_set_event_filter(struct hw_perf_event *event,
 
 	if (attr->exclude_idle)
 		return -EPERM;
+	if (attr->exclude_host || attr->exclude_guest)
+		return -EPERM;
 	if (attr->exclude_user)
 		config_base |= ARMV7_EXCLUDE_USER;
 	if (attr->exclude_kernel)
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)

From: Andrew Murray <andrew.murray@arm.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Will Deacon <will.deacon@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	x86@kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-alpha@vger.kernel.org
Subject: [PATCH 03/10] arm: perf: add additional validation to set_event_filter
Date: Fri, 16 Nov 2018 10:24:06 +0000	[thread overview]
Message-ID: <1542363853-13849-4-git-send-email-andrew.murray@arm.com> (raw)
In-Reply-To: <1542363853-13849-1-git-send-email-andrew.murray@arm.com>

The armv7pmu driver doesn't support host/guest mode exclusion so
let's report this when set_event_filter is called with these
exclusion flags set.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 arch/arm/kernel/perf_event_v7.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
index a4fb0f8..c4c9fbb 100644
--- a/arch/arm/kernel/perf_event_v7.c
+++ b/arch/arm/kernel/perf_event_v7.c
@@ -1074,6 +1074,8 @@ static int armv7pmu_set_event_filter(struct hw_perf_event *event,
 
 	if (attr->exclude_idle)
 		return -EPERM;
+	if (attr->exclude_host || attr->exclude_guest)
+		return -EPERM;
 	if (attr->exclude_user)
 		config_base |= ARMV7_EXCLUDE_USER;
 	if (attr->exclude_kernel)
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)

From: andrew.murray@arm.com (Andrew Murray)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/10] arm: perf: add additional validation to set_event_filter
Date: Fri, 16 Nov 2018 10:24:06 +0000	[thread overview]
Message-ID: <1542363853-13849-4-git-send-email-andrew.murray@arm.com> (raw)
In-Reply-To: <1542363853-13849-1-git-send-email-andrew.murray@arm.com>

The armv7pmu driver doesn't support host/guest mode exclusion so
let's report this when set_event_filter is called with these
exclusion flags set.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 arch/arm/kernel/perf_event_v7.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/kernel/perf_event_v7.c b/arch/arm/kernel/perf_event_v7.c
index a4fb0f8..c4c9fbb 100644
--- a/arch/arm/kernel/perf_event_v7.c
+++ b/arch/arm/kernel/perf_event_v7.c
@@ -1074,6 +1074,8 @@ static int armv7pmu_set_event_filter(struct hw_perf_event *event,
 
 	if (attr->exclude_idle)
 		return -EPERM;
+	if (attr->exclude_host || attr->exclude_guest)
+		return -EPERM;
 	if (attr->exclude_user)
 		config_base |= ARMV7_EXCLUDE_USER;
 	if (attr->exclude_kernel)
-- 
2.7.4

next prev parent reply	other threads:[~2018-11-16 10:24 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 10:24 [PATCH 00/10] perf/core: Generalise event exclusion checking Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray
2018-11-16 10:24 ` [PATCH 01/10] perf/core: Add macro to test for event exclusion flags Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-19 12:58   ` Peter Zijlstra
2018-11-19 12:58     ` Peter Zijlstra
2018-11-19 12:58     ` Peter Zijlstra
2018-11-19 12:58     ` Peter Zijlstra
2018-11-19 16:01   ` Mark Rutland
2018-11-19 16:01     ` Mark Rutland
2018-11-19 16:01     ` Mark Rutland
2018-11-20 11:28   ` Michael Ellerman
2018-11-20 11:28     ` Michael Ellerman
2018-11-20 11:28     ` Michael Ellerman
2018-11-23 14:32     ` Andrew Murray
2018-11-23 14:32       ` Andrew Murray
2018-11-23 14:32       ` Andrew Murray
2018-11-16 10:24 ` [PATCH 02/10] arm: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` Andrew Murray [this message]
2018-11-16 10:24   ` [PATCH 03/10] arm: perf: add additional validation to set_event_filter Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` [PATCH 04/10] powerpc: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-20 11:21   ` Michael Ellerman
2018-11-20 11:21     ` Michael Ellerman
2018-11-20 11:21     ` Michael Ellerman
2018-11-16 10:24 ` [PATCH 05/10] powerpc/pmu/fsl: add additional validation to event_init Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` [PATCH 06/10] alpha: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` [PATCH 07/10] x86: " Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` [PATCH 08/10] perf/core: Remove unused perf_flags Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24 ` [PATCH 09/10] drivers/perf: perf/core: generalise event exclusion checking with perf macro Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-19 16:03   ` Mark Rutland
2018-11-19 16:03     ` Mark Rutland
2018-11-19 16:03     ` Mark Rutland
2018-11-23 14:31     ` Andrew Murray
2018-11-23 14:31       ` Andrew Murray
2018-11-23 14:31       ` Andrew Murray
2018-11-16 10:24 ` [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-16 10:24   ` Andrew Murray
2018-11-20 11:31   ` Michael Ellerman
2018-11-20 11:31     ` Michael Ellerman
2018-11-20 11:31     ` Michael Ellerman
2018-11-20 13:32     ` Andrew Murray
2018-11-20 13:32       ` Andrew Murray
2018-11-20 13:32       ` Andrew Murray
2018-12-11 11:06       ` Michael Ellerman
2018-12-11 11:06         ` Michael Ellerman
2018-12-11 11:06         ` Michael Ellerman
2018-12-11 11:06         ` Michael Ellerman
2018-12-11 13:59         ` Andrew Murray
2018-12-11 13:59           ` Andrew Murray
2018-12-11 13:59           ` Andrew Murray
2018-12-12  4:48           ` Michael Ellerman
2018-12-12  4:48             ` Michael Ellerman
2018-12-12  4:48             ` Michael Ellerman
2018-12-12  4:48             ` Michael Ellerman
2018-12-12  8:07           ` Christoffer Dall
2018-12-12  8:07             ` Christoffer Dall
2018-12-12  8:07             ` Christoffer Dall
2018-12-12 17:08             ` Andrew Murray
2018-12-12 17:08               ` Andrew Murray
2018-12-12 17:08               ` Andrew Murray
2018-11-19 13:08 ` [PATCH 00/10] perf/core: Generalise event exclusion checking Peter Zijlstra
2018-11-19 13:08   ` Peter Zijlstra
2018-11-19 13:08   ` Peter Zijlstra
2018-11-19 13:08   ` Peter Zijlstra
2018-11-22 12:21   ` Andrew Murray
2018-11-22 12:21     ` Andrew Murray
2018-11-22 12:21     ` Andrew Murray
2018-11-22 12:26     ` Peter Zijlstra
2018-11-22 12:26       ` Peter Zijlstra
2018-11-22 12:26       ` Peter Zijlstra
2018-11-22 12:26       ` Peter Zijlstra
2018-11-22 12:59       ` Andrew Murray
2018-11-22 12:59         ` Andrew Murray
2018-11-22 12:59         ` Andrew Murray

find likely ancestor, descendant, or conflicting patches for this message:
dfblob:a4fb0f8 dfblob:a4fb0f8 dfblob:a4fb0f8 dfblob:c4c9fbb
dfblob:c4c9fbb dfblob:c4c9fbb
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1542363853-13849-4-git-send-email-andrew.murray@arm.com \
    --to=andrew.murray@arm.com \
    --cc=acme@kernel.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.