From: "Heiko Stübner" <heiko@sntech.de> To: Linus Walleij <linus.walleij@linaro.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Grant Likely <grant.likely@linaro.org>, rob.herring@calxeda.com, devicetree-discuss@lists.ozlabs.org, James Hogan <james.hogan@imgtec.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com> Subject: [PATCH 3/5] pinctrl: handle zero found dt pinconfig properties better Date: Fri, 14 Jun 2013 17:43:21 +0200 [thread overview] Message-ID: <201306141743.21365.heiko@sntech.de> (raw) In-Reply-To: <201306141741.46077.heiko@sntech.de> This adds a shortcut when no valid pinconf properties are found in the parsed dt node, to set the values immediately and return. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/pinctrl/pinconf-generic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index dcf0371..ea9da17 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -208,6 +208,13 @@ int pinconf_generic_parse_dt_config(struct device_node *np, ncfg++; } + /* no configs found at all */ + if (ncfg == 0) { + *configs = NULL; + *nconfigs = 0; + return 0; + } + /* * Now limit the number of configs to the real number of * found properties. -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/5] pinctrl: handle zero found dt pinconfig properties better Date: Fri, 14 Jun 2013 17:43:21 +0200 [thread overview] Message-ID: <201306141743.21365.heiko@sntech.de> (raw) In-Reply-To: <201306141741.46077.heiko@sntech.de> This adds a shortcut when no valid pinconf properties are found in the parsed dt node, to set the values immediately and return. Suggested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/pinctrl/pinconf-generic.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index dcf0371..ea9da17 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c @@ -208,6 +208,13 @@ int pinconf_generic_parse_dt_config(struct device_node *np, ncfg++; } + /* no configs found at all */ + if (ncfg == 0) { + *configs = NULL; + *nconfigs = 0; + return 0; + } + /* * Now limit the number of configs to the real number of * found properties. -- 1.7.10.4
next prev parent reply other threads:[~2013-06-14 15:43 UTC|newest] Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-06-14 15:41 [PATCH 0/5] pinctrl: fix some issues with new pinconfig dt parsing Heiko Stübner 2013-06-14 15:41 ` Heiko Stübner 2013-06-14 15:41 ` Heiko Stübner 2013-06-14 15:42 ` [PATCH 1/5] pinctrl: update the documentation for some pinconfig params Heiko Stübner 2013-06-14 15:42 ` Heiko Stübner 2013-06-14 15:42 ` Heiko Stübner 2013-06-16 10:26 ` Linus Walleij 2013-06-16 10:26 ` Linus Walleij 2013-06-16 10:26 ` Linus Walleij 2013-06-16 10:45 ` Heiko Stübner 2013-06-16 10:45 ` Heiko Stübner 2013-06-16 10:45 ` Heiko Stübner 2013-06-16 12:26 ` Linus Walleij 2013-06-16 12:26 ` Linus Walleij 2013-06-16 12:26 ` Linus Walleij 2013-06-14 15:42 ` [PATCH 2/5] pinctrl: clarify some dt pinconfig options Heiko Stübner 2013-06-14 15:42 ` Heiko Stübner 2013-06-14 15:42 ` Heiko Stübner 2013-06-16 10:28 ` Linus Walleij 2013-06-16 10:28 ` Linus Walleij 2013-06-16 10:28 ` Linus Walleij 2013-06-19 22:10 ` Stephen Warren 2013-06-19 22:10 ` Stephen Warren 2013-06-19 22:10 ` Stephen Warren 2013-06-24 9:51 ` Linus Walleij 2013-06-24 9:51 ` Linus Walleij 2013-06-14 15:43 ` Heiko Stübner [this message] 2013-06-14 15:43 ` [PATCH 3/5] pinctrl: handle zero found dt pinconfig properties better Heiko Stübner 2013-06-14 15:43 ` Heiko Stübner 2013-06-16 10:29 ` Linus Walleij 2013-06-16 10:29 ` Linus Walleij 2013-06-16 10:29 ` Linus Walleij 2013-06-14 15:43 ` [PATCH 4/5] pinctrl: dynamically alloc temp array when parsing dt pinconf options Heiko Stübner 2013-06-14 15:43 ` Heiko Stübner 2013-06-14 15:43 ` Heiko Stübner 2013-06-16 10:31 ` Linus Walleij 2013-06-16 10:31 ` Linus Walleij 2013-06-16 10:31 ` Linus Walleij 2013-06-14 15:44 ` [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of " Heiko Stübner 2013-06-14 15:44 ` Heiko Stübner 2013-06-14 15:44 ` Heiko Stübner 2013-06-16 10:35 ` Linus Walleij 2013-06-16 10:35 ` Linus Walleij 2013-06-16 10:35 ` Linus Walleij 2013-06-16 11:02 ` Heiko Stübner 2013-06-16 11:02 ` Heiko Stübner 2013-06-16 11:02 ` Heiko Stübner 2013-06-16 12:35 ` Linus Walleij 2013-06-16 12:35 ` Linus Walleij 2013-06-16 12:35 ` Linus Walleij 2013-06-16 15:41 ` [PATCH v2] " Heiko Stübner 2013-06-16 15:41 ` Heiko Stübner 2013-06-16 15:41 ` Heiko Stübner 2013-06-17 15:48 ` Linus Walleij 2013-06-17 15:48 ` Linus Walleij 2013-06-17 15:48 ` Linus Walleij 2013-06-14 15:53 ` [PATCH 0/5] pinctrl: fix some issues with new pinconfig dt parsing James Hogan 2013-06-14 15:53 ` James Hogan 2013-06-14 15:53 ` James Hogan 2013-06-17 3:03 ` Laurent Pinchart 2013-06-17 3:03 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201306141743.21365.heiko@sntech.de \ --to=heiko@sntech.de \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@linaro.org \ --cc=james.hogan@imgtec.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rob.herring@calxeda.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.