* [RFA] A-MPDU EOF bit
@ 2018-01-26 10:50 Johannes Berg
[not found] ` <1516963842.2189.27.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2018-01-26 10:50 UTC (permalink / raw)
To: radiotap-S783fYmB3Ccdnm+yROfE0A
Hi all,
As previously mentioned, here's my RFA for the EOF bit in the A-MPDU
field.
For HE in particular, we need to be able to capture the EOF bit in an
A-MPDU, but it also applies in VHT where single frames are really A-
MPDUs with just a single frame inside.
The change to make is the following:
| **0x0010** | delimiter CRC error |
| **0x0020** | delimiter CRC value known: the delimiter CRC value field is valid |
-| **0xffc0** | reserved |
+| **0x0040** | EOF value |
+| **0x0080** | EOF value known |
+| **0xff00** | reserved |
I have a patch to implement it in a generator here:
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=55269b3861b4fbe21fdc6d7392cbe9c5bef98374
(I'll follow up with a driver patch, we have it but not pushed out yet)
Richard has a change for wireshark here:
https://code.wireshark.org/review/#/c/25472/
Hereby starting the 3-week discussion period :-)
Thanks,
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFA] A-MPDU EOF bit
[not found] ` <1516963842.2189.27.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
@ 2018-01-30 8:28 ` Johannes Berg
2018-02-20 9:29 ` [ADOPTION] " Johannes Berg
1 sibling, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2018-01-30 8:28 UTC (permalink / raw)
To: radiotap-S783fYmB3Ccdnm+yROfE0A
On Fri, 2018-01-26 at 11:50 +0100, Johannes Berg wrote:
>
> I have a patch to implement it in a generator here:
> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=55269b3861b4fbe21fdc6d7392cbe9c5bef98374
> (I'll follow up with a driver patch, we have it but not pushed out yet)
https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=0c460de6c847e5cef421dfde368e010c1e0f906f
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ADOPTION] A-MPDU EOF bit
[not found] ` <1516963842.2189.27.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-01-30 8:28 ` Johannes Berg
@ 2018-02-20 9:29 ` Johannes Berg
[not found] ` <1519118967.16723.23.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
1 sibling, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2018-02-20 9:29 UTC (permalink / raw)
To: radiotap-S783fYmB3Ccdnm+yROfE0A
On Fri, 2018-01-26 at 11:50 +0100, Johannes Berg wrote:
> Hi all,
>
> As previously mentioned, here's my RFA for the EOF bit in the A-MPDU
> field.
>
> For HE in particular, we need to be able to capture the EOF bit in an
> A-MPDU, but it also applies in VHT where single frames are really A-
> MPDUs with just a single frame inside.
>
> The change to make is the following:
>
> | **0x0010** | delimiter CRC error |
> | **0x0020** | delimiter CRC value known: the delimiter CRC value field is valid |
> -| **0xffc0** | reserved |
> +| **0x0040** | EOF value |
> +| **0x0080** | EOF value known |
> +| **0xff00** | reserved |
>
>
> I have a patch to implement it in a generator here:
> https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=55269b3861b4fbe21fdc6d7392cbe9c5bef98374
> (I'll follow up with a driver patch, we have it but not pushed out yet)
>
> Richard has a change for wireshark here:
> https://code.wireshark.org/review/#/c/25472/
>
>
> Hereby starting the 3-week discussion period :-)
Reminder - going to adopt next week.
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ADOPTION] A-MPDU EOF bit
[not found] ` <1519118967.16723.23.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
@ 2018-06-18 13:59 ` Johannes Berg
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2018-06-18 13:59 UTC (permalink / raw)
To: radiotap-S783fYmB3Ccdnm+yROfE0A
On Tue, 2018-02-20 at 10:29 +0100, Johannes Berg wrote:
> On Fri, 2018-01-26 at 11:50 +0100, Johannes Berg wrote:
> > Hi all,
> >
> > As previously mentioned, here's my RFA for the EOF bit in the A-MPDU
> > field.
> >
> > For HE in particular, we need to be able to capture the EOF bit in an
> > A-MPDU, but it also applies in VHT where single frames are really A-
> > MPDUs with just a single frame inside.
> >
> > The change to make is the following:
> >
> > | **0x0010** | delimiter CRC error |
> > | **0x0020** | delimiter CRC value known: the delimiter CRC value field is valid |
> > -| **0xffc0** | reserved |
> > +| **0x0040** | EOF value |
> > +| **0x0080** | EOF value known |
> > +| **0xff00** | reserved |
> >
> >
> > I have a patch to implement it in a generator here:
> > https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/backport-iwlwifi.git/commit/?id=55269b3861b4fbe21fdc6d7392cbe9c5bef98374
> > (I'll follow up with a driver patch, we have it but not pushed out yet)
> >
> > Richard has a change for wireshark here:
> > https://code.wireshark.org/review/#/c/25472/
> >
> >
> > Hereby starting the 3-week discussion period :-)
>
> Reminder - going to adopt next week.
Forgot this also, but pushed it now ...
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-18 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-26 10:50 [RFA] A-MPDU EOF bit Johannes Berg
[not found] ` <1516963842.2189.27.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-01-30 8:28 ` Johannes Berg
2018-02-20 9:29 ` [ADOPTION] " Johannes Berg
[not found] ` <1519118967.16723.23.camel-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
2018-06-18 13:59 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).