* [PATCH] selinux: Fix typo in filesystem name
@ 2020-02-02 1:46 Hridya Valsaraju
2020-02-03 13:38 ` Stephen Smalley
2020-02-05 23:28 ` Paul Moore
0 siblings, 2 replies; 4+ messages in thread
From: Hridya Valsaraju @ 2020-02-02 1:46 UTC (permalink / raw)
To: Paul Moore, Stephen Smalley, Eric Paris, Jeff Vander Stoep,
Mark Salyzyn, Hridya Valsaraju, selinux, linux-kernel
Cc: kernel-team
Correct the filesystem name to "binder" to enable
genfscon per-file labelling for binderfs.
Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
Signed-off-by: Hridya Valsaraju <hridya@google.com>
---
Hello,
I seem to have made the typo/mistake during a rebase. Sorry about that
:(
Thanks,
Hridya
security/selinux/hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index 89fe3a805129..d67a80b0d8a8 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
if (!strcmp(sb->s_type->name, "debugfs") ||
!strcmp(sb->s_type->name, "tracefs") ||
- !strcmp(sb->s_type->name, "binderfs") ||
+ !strcmp(sb->s_type->name, "binder") ||
!strcmp(sb->s_type->name, "pstore"))
sbsec->flags |= SE_SBGENFS;
--
2.25.0.341.g760bfbb309-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] selinux: Fix typo in filesystem name
2020-02-02 1:46 [PATCH] selinux: Fix typo in filesystem name Hridya Valsaraju
@ 2020-02-03 13:38 ` Stephen Smalley
2020-02-05 23:28 ` Paul Moore
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Smalley @ 2020-02-03 13:38 UTC (permalink / raw)
To: Hridya Valsaraju, Paul Moore, Eric Paris, Jeff Vander Stoep,
Mark Salyzyn, selinux, linux-kernel
Cc: kernel-team
On 2/1/20 8:46 PM, Hridya Valsaraju wrote:
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <hridya@google.com>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
> if (!strcmp(sb->s_type->name, "debugfs") ||
> !strcmp(sb->s_type->name, "tracefs") ||
> - !strcmp(sb->s_type->name, "binderfs") ||
> + !strcmp(sb->s_type->name, "binder") ||
> !strcmp(sb->s_type->name, "pstore"))
> sbsec->flags |= SE_SBGENFS;
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selinux: Fix typo in filesystem name
2020-02-02 1:46 [PATCH] selinux: Fix typo in filesystem name Hridya Valsaraju
2020-02-03 13:38 ` Stephen Smalley
@ 2020-02-05 23:28 ` Paul Moore
2020-02-05 23:52 ` Hridya Valsaraju
1 sibling, 1 reply; 4+ messages in thread
From: Paul Moore @ 2020-02-05 23:28 UTC (permalink / raw)
To: Hridya Valsaraju
Cc: Stephen Smalley, Eric Paris, Jeff Vander Stoep, Mark Salyzyn,
selinux, linux-kernel, kernel-team
On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote:
>
> Correct the filesystem name to "binder" to enable
> genfscon per-file labelling for binderfs.
>
> Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> Signed-off-by: Hridya Valsaraju <hridya@google.com>
> ---
>
> Hello,
>
> I seem to have made the typo/mistake during a rebase. Sorry about that
> :(
>
> Thanks,
> Hridya
>
> security/selinux/hooks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ooops :/
Thanks for the fix. I've merged this into selinux/stable-5.6, but due
to some personal scheduling issues on my end I'm going to refrain from
sending this to Linus until next week.
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 89fe3a805129..d67a80b0d8a8 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
>
> if (!strcmp(sb->s_type->name, "debugfs") ||
> !strcmp(sb->s_type->name, "tracefs") ||
> - !strcmp(sb->s_type->name, "binderfs") ||
> + !strcmp(sb->s_type->name, "binder") ||
> !strcmp(sb->s_type->name, "pstore"))
> sbsec->flags |= SE_SBGENFS;
>
> --
> 2.25.0.341.g760bfbb309-goog
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] selinux: Fix typo in filesystem name
2020-02-05 23:28 ` Paul Moore
@ 2020-02-05 23:52 ` Hridya Valsaraju
0 siblings, 0 replies; 4+ messages in thread
From: Hridya Valsaraju @ 2020-02-05 23:52 UTC (permalink / raw)
To: Paul Moore
Cc: Stephen Smalley, Eric Paris, Jeff Vander Stoep, Mark Salyzyn,
selinux, LKML, Android Kernel Team
On Wed, Feb 5, 2020 at 3:28 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Sat, Feb 1, 2020 at 8:46 PM Hridya Valsaraju <hridya@google.com> wrote:
> >
> > Correct the filesystem name to "binder" to enable
> > genfscon per-file labelling for binderfs.
> >
> > Fixes: 7a4b5194747 ("selinux: allow per-file labelling for binderfs")
> > Signed-off-by: Hridya Valsaraju <hridya@google.com>
> > ---
> >
> > Hello,
> >
> > I seem to have made the typo/mistake during a rebase. Sorry about that
> > :(
> >
> > Thanks,
> > Hridya
> >
> > security/selinux/hooks.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Ooops :/
>
> Thanks for the fix. I've merged this into selinux/stable-5.6, but due
> to some personal scheduling issues on my end I'm going to refrain from
> sending this to Linus until next week.
Thank you Paul and Stephen!
Regards,
Hridya
>
> > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> > index 89fe3a805129..d67a80b0d8a8 100644
> > --- a/security/selinux/hooks.c
> > +++ b/security/selinux/hooks.c
> > @@ -699,7 +699,7 @@ static int selinux_set_mnt_opts(struct super_block *sb,
> >
> > if (!strcmp(sb->s_type->name, "debugfs") ||
> > !strcmp(sb->s_type->name, "tracefs") ||
> > - !strcmp(sb->s_type->name, "binderfs") ||
> > + !strcmp(sb->s_type->name, "binder") ||
> > !strcmp(sb->s_type->name, "pstore"))
> > sbsec->flags |= SE_SBGENFS;
> >
> > --
> > 2.25.0.341.g760bfbb309-goog
>
> --
> paul moore
> www.paul-moore.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-05 23:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-02 1:46 [PATCH] selinux: Fix typo in filesystem name Hridya Valsaraju
2020-02-03 13:38 ` Stephen Smalley
2020-02-05 23:28 ` Paul Moore
2020-02-05 23:52 ` Hridya Valsaraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).