From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Juergen Gross <jgross@suse.com>,
Jan Beulich <jbeulich@suse.com>
Subject: [PATCH 4.9 36/38] xen: remove gnttab_query_foreign_access()
Date: Thu, 10 Mar 2022 15:13:49 +0100 [thread overview]
Message-ID: <20220310140809.185890974@linuxfoundation.org> (raw)
In-Reply-To: <20220310140808.136149678@linuxfoundation.org>
From: Juergen Gross <jgross@suse.com>
Commit 1dbd11ca75fe664d3e54607547771d021f531f59 upstream.
Remove gnttab_query_foreign_access(), as it is unused and unsafe to
use.
All previous use cases assumed a grant would not be in use after
gnttab_query_foreign_access() returned 0. This information is useless
in best case, as it only refers to a situation in the past, which could
have changed already.
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/xen/grant-table.c | 19 -------------------
include/xen/grant_table.h | 2 --
2 files changed, 21 deletions(-)
--- a/drivers/xen/grant-table.c
+++ b/drivers/xen/grant-table.c
@@ -113,13 +113,6 @@ struct gnttab_ops {
* return the frame.
*/
unsigned long (*end_foreign_transfer_ref)(grant_ref_t ref);
- /*
- * Query the status of a grant entry. Ref parameter is reference of
- * queried grant entry, return value is the status of queried entry.
- * Detailed status(writing/reading) can be gotten from the return value
- * by bit operations.
- */
- int (*query_foreign_access)(grant_ref_t ref);
};
struct unmap_refs_callback_data {
@@ -254,17 +247,6 @@ int gnttab_grant_foreign_access(domid_t
}
EXPORT_SYMBOL_GPL(gnttab_grant_foreign_access);
-static int gnttab_query_foreign_access_v1(grant_ref_t ref)
-{
- return gnttab_shared.v1[ref].flags & (GTF_reading|GTF_writing);
-}
-
-int gnttab_query_foreign_access(grant_ref_t ref)
-{
- return gnttab_interface->query_foreign_access(ref);
-}
-EXPORT_SYMBOL_GPL(gnttab_query_foreign_access);
-
static int gnttab_end_foreign_access_ref_v1(grant_ref_t ref, int readonly)
{
u16 flags, nflags;
@@ -1028,7 +1010,6 @@ static const struct gnttab_ops gnttab_v1
.update_entry = gnttab_update_entry_v1,
.end_foreign_access_ref = gnttab_end_foreign_access_ref_v1,
.end_foreign_transfer_ref = gnttab_end_foreign_transfer_ref_v1,
- .query_foreign_access = gnttab_query_foreign_access_v1,
};
static void gnttab_request_version(void)
--- a/include/xen/grant_table.h
+++ b/include/xen/grant_table.h
@@ -118,8 +118,6 @@ int gnttab_grant_foreign_transfer(domid_
unsigned long gnttab_end_foreign_transfer_ref(grant_ref_t ref);
unsigned long gnttab_end_foreign_transfer(grant_ref_t ref);
-int gnttab_query_foreign_access(grant_ref_t ref);
-
/*
* operations on reserved batches of grant references
*/
next prev parent reply other threads:[~2022-03-10 14:21 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 14:13 [PATCH 4.9 00/38] 4.9.306-rc2 review Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 01/38] x86/speculation: Add RETPOLINE_AMD support to the inline asm CALL_NOSPEC variant Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 02/38] x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 03/38] x86/retpoline: Remove minimal retpoline support Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 04/38] Documentation: Add section about CPU vulnerabilities for Spectre Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 05/38] Documentation: Add swapgs description to the Spectre v1 documentation Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 06/38] Documentation: refer to config RANDOMIZE_BASE for kernel address-space randomization Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 07/38] x86/speculation: Merge one test in spectre_v2_user_select_mitigation() Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 08/38] x86,bugs: Unconditionally allow spectre_v2=retpoline,amd Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 09/38] x86/speculation: Rename RETPOLINE_AMD to RETPOLINE_LFENCE Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 10/38] x86/speculation: Add eIBRS + Retpoline options Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 11/38] Documentation/hw-vuln: Update spectre doc Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 12/38] x86/speculation: Include unprivileged eBPF status in Spectre v2 mitigation reporting Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 13/38] x86/speculation: Use generic retpoline by default on AMD Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 14/38] x86/speculation: Update link to AMD speculation whitepaper Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 15/38] x86/speculation: Warn about Spectre v2 LFENCE mitigation Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 16/38] x86/speculation: Warn about eIBRS + LFENCE + Unprivileged eBPF + SMT Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 17/38] arm/arm64: Provide a wrapper for SMCCC 1.1 calls Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 18/38] arm/arm64: smccc/psci: add arm_smccc_1_1_get_conduit() Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 19/38] ARM: report Spectre v2 status through sysfs Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 20/38] ARM: early traps initialisation Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 21/38] ARM: use LOADADDR() to get load address of sections Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 22/38] ARM: Spectre-BHB workaround Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 23/38] ARM: include unprivileged BPF status in Spectre V2 reporting Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 24/38] ARM: fix build error when BPF_SYSCALL is disabled Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 25/38] ARM: fix co-processor register typo Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 26/38] ARM: Do not use NOCROSSREFS directive with ld.lld Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 27/38] x86/build: Fix compiler support check for CONFIG_RETPOLINE Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 28/38] x86, modpost: Replace last remnants of RETPOLINE with CONFIG_RETPOLINE Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 29/38] ARM: fix build warning in proc-v7-bugs.c Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 30/38] xen/xenbus: dont let xenbus_grant_ring() remove grants in error case Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 31/38] xen/grant-table: add gnttab_try_end_foreign_access() Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 32/38] xen/blkfront: dont use gnttab_query_foreign_access() for mapped status Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 33/38] xen/netfront: " Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 34/38] xen/scsifront: " Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 35/38] xen/gntalloc: dont use gnttab_query_foreign_access() Greg Kroah-Hartman
2022-03-10 14:13 ` Greg Kroah-Hartman [this message]
2022-03-10 14:13 ` [PATCH 4.9 37/38] xen/gnttab: fix gnttab_end_foreign_access() without page specified Greg Kroah-Hartman
2022-03-10 14:13 ` [PATCH 4.9 38/38] xen/netfront: react properly to failing gnttab_end_foreign_access_ref() Greg Kroah-Hartman
2022-03-10 18:00 ` [PATCH 4.9 00/38] 4.9.306-rc2 review Pavel Machek
2022-03-10 18:48 ` Jon Hunter
2022-03-10 19:35 ` Shuah Khan
2022-03-10 20:14 ` Florian Fainelli
2022-03-11 1:13 ` Guenter Roeck
2022-03-11 13:35 ` Naresh Kamboju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310140809.185890974@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).