u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
Cc: ryan_chen@aspeedtech.com, BMC-SW@aspeedtech.com, joel@jms.id.au,
	u-boot@lists.denx.de
Subject: Re: [PATCH] configs: ast2600: Move SPL bss section to DRAM space
Date: Thu, 23 Jun 2022 08:19:28 -0400	[thread overview]
Message-ID: <20220623121928.GI2484912@bill-the-cat> (raw)
In-Reply-To: <20220601082115.10799-1-chiawei_wang@aspeedtech.com>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

On Wed, Jun 01, 2022 at 04:21:15PM +0800, Chia-Wei Wang wrote:

> The commit b583348ca8c8 ("image: fit: Align hash output buffers") places
> the hash output buffer at the .bss section. However, AST2600 by default
> executes SPL in the NOR flash XIP way. This results in the hash output
> cannot be written to the buffer as it is located at the R/X only region.
> 
> We need to move the .bss section out of the SPL body to the DRAM space,
> where hash output can be written to. This patch includes:
>  - Define the .bss section base and size
>  - A new SPL linker script is added with a separate .bss region specified
>  - Enable CONFIG_SPL_SEPARATE_BSS kconfig option
> 
> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> Reviewed-by: Neal Liu <neal_liu@aspeedtech.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2022-06-23 12:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  8:21 [PATCH] configs: ast2600: Move SPL bss section to DRAM space Chia-Wei Wang
2022-06-02  2:05 ` Neal Liu
2022-06-23 12:19 ` Tom Rini [this message]
2022-06-28  4:23 ` Joel Stanley
2022-06-28  4:57   ` Sean Anderson
2022-06-29  0:39     ` ChiaWei Wang
2022-06-29  0:36   ` ChiaWei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220623121928.GI2484912@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=chiawei_wang@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=ryan_chen@aspeedtech.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).