u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: ChiaWei Wang <chiawei_wang@aspeedtech.com>
To: Sean Anderson <sean.anderson@seco.com>,
	Joel Stanley <joel@jms.id.au>, Tom Rini <trini@konsulko.com>
Cc: "Ryan Chen" <ryan_chen@aspeedtech.com>,
	BMC-SW <BMC-SW@aspeedtech.com>,
	"U-Boot Mailing List" <u-boot@lists.denx.de>,
	"Cédric Le Goater" <clg@kaod.org>
Subject: RE: [PATCH] configs: ast2600: Move SPL bss section to DRAM space
Date: Wed, 29 Jun 2022 00:39:25 +0000	[thread overview]
Message-ID: <HK0PR06MB37790F2397F0B08715FDB75191BB9@HK0PR06MB3779.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <8366b96e-c0c9-f5db-e5c0-c4128b6ea539@seco.com>

Hi Sean,

> From: Sean Anderson <sean.anderson@seco.com>
> Sent: Tuesday, June 28, 2022 12:57 PM
> 
> Hi Chai,
> 
> On 6/28/22 12:23 AM, Joel Stanley wrote:
> > Hi Chai Wei,
> >
> > On Wed, 1 Jun 2022 at 08:21, Chia-Wei Wang
> <chiawei_wang@aspeedtech.com> wrote:
> >>
> >> The commit b583348ca8c8 ("image: fit: Align hash output buffers")
> >> places the hash output buffer at the .bss section. However, AST2600
> >> by default executes SPL in the NOR flash XIP way. This results in the
> >> hash output cannot be written to the buffer as it is located at the R/X only
> region.
> >>
> >> We need to move the .bss section out of the SPL body to the DRAM
> >> space, where hash output can be written to. This patch includes:
> >>   - Define the .bss section base and size
> >>   - A new SPL linker script is added with a separate .bss region specified
> >>   - Enable CONFIG_SPL_SEPARATE_BSS kconfig option
> >>
> >> Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> >
> > This patch breaks booting for me.
> 
> Does the patch Joel posted [1] fix your issue? It seems like I used the wrong
> macro in the first place, so hopefully this patch shouldn't be necessary.
> 
> --Sean
> 
> [1] https://lore.kernel.org/u-boot/20220620070117.3443066-1-joel@jms.id.au/

Yes. Joel's patch also solved that issue.

Relocating .bss to DRAM space can avoid similar issues.
But it do create additional maintenance work.

Chiawei


  reply	other threads:[~2022-06-29  0:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-01  8:21 [PATCH] configs: ast2600: Move SPL bss section to DRAM space Chia-Wei Wang
2022-06-02  2:05 ` Neal Liu
2022-06-23 12:19 ` Tom Rini
2022-06-28  4:23 ` Joel Stanley
2022-06-28  4:57   ` Sean Anderson
2022-06-29  0:39     ` ChiaWei Wang [this message]
2022-06-29  0:36   ` ChiaWei Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=HK0PR06MB37790F2397F0B08715FDB75191BB9@HK0PR06MB3779.apcprd06.prod.outlook.com \
    --to=chiawei_wang@aspeedtech.com \
    --cc=BMC-SW@aspeedtech.com \
    --cc=clg@kaod.org \
    --cc=joel@jms.id.au \
    --cc=ryan_chen@aspeedtech.com \
    --cc=sean.anderson@seco.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).