[PATCH 1/1] efi_loader: remove duplicate assignment

[PATCH 1/1] efi_loader: remove duplicate assignment

[Heinrich Schuchardt]

Assigning the value of a variable to itself should be avoided.

Addresses-Coverity-ID: 451089 ("Evaluation order violation")
Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 lib/efi_loader/efi_device_path.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/efi_loader/efi_device_path.c b/lib/efi_loader/efi_device_path.c
index b6dd575b13..39e301450c 100644
--- a/lib/efi_loader/efi_device_path.c
+++ b/lib/efi_loader/efi_device_path.c
@@ -749,7 +749,7 @@ __maybe_unused static void *dp_fill(void *buf, struct udevice *dev)
 #endif
 #if defined(CONFIG_USB)
 		case UCLASS_MASS_STORAGE: {
-			struct blk_desc *desc = desc = dev_get_uclass_plat(dev);
+			struct blk_desc *desc = dev_get_uclass_plat(dev);
 			struct efi_device_path_controller *dp =
 				dp_fill(buf, dev->parent);
 
-- 
2.39.2

Re: [PATCH 1/1] efi_loader: remove duplicate assignment

[Simon Glass]

On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> Assigning the value of a variable to itself should be avoided.
>
> Addresses-Coverity-ID: 451089 ("Evaluation order violation")
> Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  lib/efi_loader/efi_device_path.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH 1/1] efi_loader: remove duplicate assignment

[Ilias Apalodimas]

On Sun, 2 Apr 2023 at 05:38, Simon Glass <sjg@chromium.org> wrote:
>
> On Sat, 1 Apr 2023 at 18:31, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote:
> >
> > Assigning the value of a variable to itself should be avoided.
> >
> > Addresses-Coverity-ID: 451089 ("Evaluation order violation")
> > Fixes: 180b7118bed8 ("efi_loader: fix device-path for USB devices")
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> >  lib/efi_loader/efi_device_path.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>