[PATCH 1/1] cmd: convert fallthrough comment.

[PATCH 1/1] cmd: convert fallthrough comment.

[Heinrich Schuchardt]

gcc does not understand /* FALL TROUGH */ and emits a warning:

    cmd/date.c: In function ‘do_date’:
    cmd/date.c:62:20: warning:
    this statement may fall through [-Wimplicit-fallthrough=]
       62 |                 if (strcmp(argv[1],"reset") == 0) {
          |                    ^
    cmd/date.c:102:9: note: here
      102 |         case 1:                 /* get date & time */
          |         ^~~~

Use the fallthrough macro instead.

Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 cmd/date.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/date.c b/cmd/date.c
index 58505e6e1d..fe9c8c6534 100644
--- a/cmd/date.c
+++ b/cmd/date.c
@@ -98,7 +98,7 @@ static int do_date(struct cmd_tbl *cmdtp, int flag, int argc,
 				puts("## Get date failed\n");
 			}
 		}
-		/* FALL TROUGH */
+		fallthrough;
 	case 1:			/* get date & time */
 #ifdef CONFIG_DM_RTC
 		rcode = dm_rtc_get(dev, &tm);
-- 
2.39.2

Re: [PATCH 1/1] cmd: convert fallthrough comment.

[Simon Glass]

On Sat, 1 Apr 2023 at 20:14, Heinrich Schuchardt <
heinrich.schuchardt@canonical.com> wrote:
>
> gcc does not understand /* FALL TROUGH */ and emits a warning:
>
>     cmd/date.c: In function ‘do_date’:
>     cmd/date.c:62:20: warning:
>     this statement may fall through [-Wimplicit-fallthrough=]
>        62 |                 if (strcmp(argv[1],"reset") == 0) {
>           |                    ^
>     cmd/date.c:102:9: note: here
>       102 |         case 1:                 /* get date & time */
>           |         ^~~~
>
> Use the fallthrough macro instead.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  cmd/date.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH 1/1] cmd: convert fallthrough comment.

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 739 bytes --]

On Sat, Apr 01, 2023 at 09:14:11AM +0200, Heinrich Schuchardt wrote:

> gcc does not understand /* FALL TROUGH */ and emits a warning:
> 
>     cmd/date.c: In function ‘do_date’:
>     cmd/date.c:62:20: warning:
>     this statement may fall through [-Wimplicit-fallthrough=]
>        62 |                 if (strcmp(argv[1],"reset") == 0) {
>           |                    ^
>     cmd/date.c:102:9: note: here
>       102 |         case 1:                 /* get date & time */
>           |         ^~~~
> 
> Use the fallthrough macro instead.
> 
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]