From: <Tudor.Ambarus@microchip.com>
To: <jagan@amarulasolutions.com>
Cc: <vigneshr@ti.com>, <p.yadav@ti.com>, <u-boot@lists.denx.de>,
<Nicolas.Ferre@microchip.com>
Subject: Re: [PATCH v2 2/4] mtd: spi-nor-core: macronix: Add support for mx66lm1g45g
Date: Mon, 15 Nov 2021 05:25:15 +0000 [thread overview]
Message-ID: <f56c507f-56ec-b033-e63e-a1cce22444b1@microchip.com> (raw)
In-Reply-To: <CAMty3ZCxqtTqDW++kO_+dzMqwD_bUNmyEbZVCkTVaV7V222fUQ@mail.gmail.com>
On 11/13/21 3:48 PM, Jagan Teki wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Nov 4, 2021 at 5:20 AM Tudor Ambarus
> <tudor.ambarus@microchip.com> wrote:
>>
>> mx66lm1g45g supports just 1-1-1, 8-8-8 and 8d-8d-8d modes.
>> Tested in 1-1-1 and 8d-8d-8d modes using microchip's Octal SPI IP.
>>
>> Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
>> ---
>> drivers/mtd/spi/Kconfig | 8 ++++
>> drivers/mtd/spi/spi-nor-core.c | 74 ++++++++++++++++++++++++++++++++++
>> drivers/mtd/spi/spi-nor-ids.c | 6 +++
>> include/linux/mtd/spi-nor.h | 8 ++++
>> 4 files changed, 96 insertions(+)
>>
>> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
>> index 408a53f861..2d2b71c52d 100644
>> --- a/drivers/mtd/spi/Kconfig
>> +++ b/drivers/mtd/spi/Kconfig
>> @@ -160,6 +160,14 @@ config SPI_FLASH_MACRONIX
>> help
>> Add support for various Macronix SPI flash chips (MX25Lxxx)
>>
>> +config SPI_FLASH_MX66LM1G45G
>> + bool "Macronix MX66LM1G45G chip support"
>
> Apart from actual code, I don't like to have specific part configs,
> look like list is increasing like anything. Better use existing
> macronix.
>
I don't like it either, I just followed the u-boot code. Will come up
with something.
Cheers,
ta
next prev parent reply other threads:[~2021-11-15 5:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 23:49 [PATCH v2 0/4] mtd: spi-nor: Fix software reset; add mx66lm1g45g Tudor Ambarus
2021-11-03 23:49 ` [PATCH v2 1/4] mtd: spi-nor-core: Introduce SPI_NOR_SOFT_RESET flash_info flag Tudor Ambarus
2021-11-09 19:31 ` Pratyush Yadav
2021-11-03 23:49 ` [PATCH v2 2/4] mtd: spi-nor-core: macronix: Add support for mx66lm1g45g Tudor Ambarus
2021-11-12 21:50 ` Pratyush Yadav
2021-11-13 13:48 ` Jagan Teki
2021-11-15 5:25 ` Tudor.Ambarus [this message]
2021-11-03 23:49 ` [PATCH v2 3/4] Revert "mtd: spi-nor-core: Perform a Soft Reset on boot" Tudor Ambarus
2021-11-09 19:26 ` Pratyush Yadav
2021-11-10 8:44 ` Tudor.Ambarus
2021-11-12 13:13 ` Pratyush Yadav
2021-11-15 5:44 ` Tudor.Ambarus
2021-12-16 18:45 ` Pratyush Yadav
2021-12-17 6:27 ` Tudor.Ambarus
2021-12-17 10:40 ` Pratyush Yadav
2021-11-03 23:49 ` [PATCH v2 4/4] mtd: spi-nor-core: Fix the opcode extension for the software reset sequence Tudor Ambarus
2021-11-09 19:29 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f56c507f-56ec-b033-e63e-a1cce22444b1@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=jagan@amarulasolutions.com \
--cc=p.yadav@ti.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).