Re: ready for v2.32 ?

Re: ready for v2.32 ?

[Thomas Deutschmann]

Hi,

util-linux v2.32 looks ready for us, passed all tests on Gentoo Linux
(tested against commit 2e20500a449955a69ea0b8381453079e8b57e9d3).


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5

Re: ready for v2.32 ?

[Karel Zak]

On Mon, Feb 26, 2018 at 10:16:01PM +0100, Ruediger Meier wrote:
> There is one test failure on big endian (ppc/ppc64)
> 
> [...]
>   blkid: superblocks probing: [37] mpool               ... FAILED 
> (blkid/low-probe-mpool)
> [...]
> ---------------------------------------------------------------------
>   1 tests of 199 FAILED
> ---------------------------------------------------------------------

I guess we have to use le32_to_cpu() osd->osb_cksum1. 

John, is mpool little endian, big endian, or both?

    Karel

> 
> --- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool       
> 2018-02-26 20:14:24.265703542 +0000
> +++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool 
> 2018-02-26 
> 20:38:14.300022547 +0000
> @@ -1,6 +0,0 @@
> -ID_FS_LABEL=mp1
> -ID_FS_LABEL_ENC=mp1
> -ID_FS_TYPE=mpool
> -ID_FS_USAGE=filesystem
> -ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
> -ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83
> --
> To unsubscribe from this list: send the line "unsubscribe util-linux" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: ready for v2.32 ?

[Ruediger Meier]

There is one test failure on big endian (ppc/ppc64)

[...]
  blkid: superblocks probing: [37] mpool               ... FAILED 
(blkid/low-probe-mpool)
[...]
---------------------------------------------------------------------
  1 tests of 199 FAILED
---------------------------------------------------------------------

--- /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/expected/blkid/low-probe-mpool       
2018-02-26 20:14:24.265703542 +0000
+++ /home/abuild/rpmbuild/BUILD/util-linux-2.32-rc1-31-79bd1/tests/output/blkid/low-probe-mpool 
2018-02-26 
20:38:14.300022547 +0000
@@ -1,6 +0,0 @@
-ID_FS_LABEL=mp1
-ID_FS_LABEL_ENC=mp1
-ID_FS_TYPE=mpool
-ID_FS_USAGE=filesystem
-ID_FS_UUID=2dfca1ea-651e-4694-976f-14654b0a8a83
-ID_FS_UUID_ENC=2dfca1ea-651e-4694-976f-14654b0a8a83

Re: ready for v2.32 ?

[Ruediger Meier]

On Wednesday 07 February 2018, Karel Zak wrote:

>  The regression tests improvements (for example faketime for cal(1))
>  we can merge during -rc1.

I think the faketime tests can wait. I will do this later one day when I 
feel really boring. Could be that we have to check carefully for the 
case that faketime(1) is available (and works) but ul is built against 
an exotic libc which does not work with the installed faketime.

BTW as we have talked about some months ago I still check the build 
for -m32 and different compilers with -Werror on travis from time to 
time. Still not automated because the repo dependencies are broken 
sometimes. But if it runs it runs :)

See here on top of v2.32-rc1-31-g79bd13842

# clang 3.9...5, gcc 4.8..7, xcode 6.4...9
https://travis-ci.org/rudimeier/util-linux/builds/346431564
# -m32 with clang and gcc
https://travis-ci.org/rudimeier/util-linux/builds/346431659

cu,
Rudi

Re: ready for v2.32 ?

[Karel Zak]

On Sat, Feb 10, 2018 at 07:13:44PM +0100, Samuel Thibault wrote:
> Here is a small build fix for the case where USE_PTY is not defined.

Applied, thanks.

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com

Re: ready for v2.32 ?

[Samuel Thibault]

[-- Attachment #1: Type: text/plain, Size: 85 bytes --]

Hello,

Here is a small build fix for the case where USE_PTY is not defined.

Samuel

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 410 bytes --]

diff --git a/login-utils/su-common.c b/login-utils/su-common.c
index afd75a1f1..9c6267f25 100644
--- a/login-utils/su-common.c
+++ b/login-utils/su-common.c
@@ -1417,8 +1417,10 @@ int su_main(int argc, char **argv, int mode)
 		setsid();
 	}
 
+#ifdef USE_PTY
 	if (su->pty)
 		pty_init_slave(su);
+#endif
 
 	/* Set environment after pam_open_session, which may put KRB5CCNAME
 	   into the pam_env, etc.  */

ready for v2.32 ?

[Karel Zak]

 Hi,

 I'd like to release v2.32-rc1 on Friday (or Monday). Do you see any
 unwanted or missing patches in the master branch?

 For now the last missing thing is William's "calendar system header"
 option and switch for cal(1), but I think we can postpone this
 until v2.33. We have enough changes for cal(1) in v2.32 ;-)

 The regression tests improvements (for example faketime for cal(1))
 we can merge during -rc1.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com