From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com,
Satananda Burla <sburla@marvell.com>
Subject: [virtio-dev] Re: [PATCH 02/11] transport-pci: Move transitional device id to legacy section
Date: Fri, 31 Mar 2023 02:43:56 -0400 [thread overview]
Message-ID: <20230331024233-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230330225834.506969-3-parav@nvidia.com>
On Fri, Mar 31, 2023 at 01:58:25AM +0300, Parav Pandit wrote:
> Currently PCI device discovery details for the transitional device
> are documented in two different sections.
>
> For example, PCI device and vendor ID registers are documented in
> 'Device Requirements: PCI Device Discovery' section, while PCI
> revision id is documented in 'Legacy Interfaces: A Note on PCI
> Device Discovery' section.
>
> Transitional devices requirements should be documented in "legacy
> interfaces" section as clearly mentioned in
> 'Legacy Interface: A Note on Feature Bits'.
I already commented on this, I disagree.
Modern drivers must be able
to completely ignore legacy interface sections, but they
do bind to transitional device IDs.
This change breaks this assumption.
> Hence,
> 1. Move transitional device requirements to its designated Legacy
> interface section
> 2. Describe regular device requirements without quoting it as "non
> transitional device"
>
> While at it, write the description using a singular object definition.
>
> Reviewed-by: Satananda Burla <sburla@marvell.com>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
> ---
> transport-pci.tex | 70 ++++++++++++++++++++++++-----------------------
> 1 file changed, 36 insertions(+), 34 deletions(-)
>
> diff --git a/transport-pci.tex b/transport-pci.tex
> index 7f27107..1f74c6f 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -28,46 +28,24 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
>
> \devicenormative{\subsubsection}{PCI Device Discovery}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery}
>
> -Devices MUST have the PCI Vendor ID 0x1af4.
> -Devices MUST either have the PCI Device ID calculated by adding 0x1040
> +The device MUST have the PCI Vendor ID 0x1af4.
> +The device MUST calculate PCI Device ID by adding 0x1040
> to the Virtio Device ID, as indicated in section \ref{sec:Device
> -Types} or have the Transitional PCI Device ID depending on the device type,
> -as follows:
> -
> -\begin{tabular}{|l|c|}
> -\hline
> -Transitional PCI Device ID & Virtio Device \\
> -\hline \hline
> -0x1000 & network device \\
> -\hline
> -0x1001 & block device \\
> -\hline
> -0x1002 & memory ballooning (traditional) \\
> -\hline
> -0x1003 & console \\
> -\hline
> -0x1004 & SCSI host \\
> -\hline
> -0x1005 & entropy source \\
> -\hline
> -0x1009 & 9P transport \\
> -\hline
> -\end{tabular}
> +Types}.
>
> For example, the network device with the Virtio Device ID 1
> -has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
> -
> -The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> -the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
> +has the PCI Device ID 0x1041.
>
> -Non-transitional devices SHOULD have a PCI Device ID in the range
> -0x1040 to 0x107f.
> -Non-transitional devices SHOULD have a PCI Revision ID of 1 or higher.
> -Non-transitional devices SHOULD have a PCI Subsystem Device ID of 0x40 or higher.
> +The device SHOULD have a PCI Device ID in the range 0x1040 to 0x107f.
> +The device SHOULD have a PCI Revision ID of 1 or higher.
> +The device SHOULD have a PCI Subsystem Device ID of 0x40 or higher.
>
> This is to reduce the chance of a legacy driver attempting
> to drive the device.
>
> +The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
> +the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
> +
> \drivernormative{\subsubsection}{PCI Device Discovery}{Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery}
> Drivers MUST match devices with the PCI Vendor ID 0x1af4 and
> the PCI Device ID in the range 0x1040 to 0x107f,
> @@ -85,8 +63,32 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
> PCI Subsystem Device ID value.
>
> \subsubsection{Legacy Interfaces: A Note on PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Over PCI Bus / PCI Device Discovery / Legacy Interfaces: A Note on PCI Device Discovery}
> -Transitional devices MUST have a PCI Revision ID of 0.
> -Transitional devices MUST have the PCI Subsystem Device ID
> +
> +The transitional device has one of the following PCI Device ID
> +depending on the device type:
> +
> +\begin{tabular}{|l|c|}
> +\hline
> +Transitional PCI Device ID & Virtio Device \\
> +\hline \hline
> +0x1000 & network device \\
> +\hline
> +0x1001 & block device \\
> +\hline
> +0x1002 & memory ballooning (traditional) \\
> +\hline
> +0x1003 & console \\
> +\hline
> +0x1004 & SCSI host \\
> +\hline
> +0x1005 & entropy source \\
> +\hline
> +0x1009 & 9P transport \\
> +\hline
> +\end{tabular}
> +
> +The transitional device MUST have a PCI Revision ID of 0.
> +The transitional device MUST have the PCI Subsystem Device ID
> matching the Virtio Device ID, as indicated in section \ref{sec:Device Types}.
> Transitional devices MUST have the Transitional PCI Device ID in
> the range 0x1000 to 0x103f.
> --
> 2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-03-31 6:44 UTC|newest]
Thread overview: 200+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 22:58 [virtio-dev] [PATCH 00/11] Introduce transitional mmr pci device Parav Pandit
2023-03-30 22:58 ` [virtio-dev] [PATCH 01/11] transport-pci: Use lowecase alphabets Parav Pandit
2023-03-30 22:58 ` [virtio-dev] [PATCH 02/11] transport-pci: Move transitional device id to legacy section Parav Pandit
2023-03-31 6:43 ` Michael S. Tsirkin [this message]
2023-03-31 21:24 ` [virtio-dev] " Parav Pandit
2023-04-02 7:54 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 14:42 ` [virtio-dev] " Parav Pandit
2023-04-03 14:50 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 14:58 ` [virtio-dev] " Parav Pandit
2023-04-03 15:14 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 03/11] transport-pci: Split notes of PCI Device Layout Parav Pandit
2023-03-30 22:58 ` [virtio-dev] [PATCH 04/11] transport-pci: Rename and move legacy PCI Device layout section Parav Pandit
2023-03-30 22:58 ` [virtio-dev] [PATCH 05/11] introduction: Add missing helping verb Parav Pandit
2023-03-30 22:58 ` [virtio-dev] [PATCH 06/11] introduction: Introduce transitional MMR interface Parav Pandit
2023-04-07 9:17 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 07/11] transport-pci: Introduce transitional MMR device id Parav Pandit
2023-04-04 7:28 ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 16:08 ` Parav Pandit
2023-04-07 12:03 ` [virtio-dev] Re: [virtio-comment] " Michael S. Tsirkin
2023-04-07 15:18 ` [virtio-dev] " Parav Pandit
2023-04-07 15:51 ` [virtio-dev] " Michael S. Tsirkin
2023-04-09 3:15 ` [virtio-dev] " Parav Pandit
2023-04-10 10:18 ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 14:34 ` Parav Pandit
2023-04-10 19:58 ` Michael S. Tsirkin
2023-04-10 20:16 ` Parav Pandit
2023-04-07 8:37 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 08/11] transport-pci: Introduce virtio extended capability Parav Pandit
2023-04-04 7:35 ` [virtio-dev] " Michael S. Tsirkin
2023-04-04 7:54 ` Cornelia Huck
2023-04-04 12:43 ` Michael S. Tsirkin
2023-04-04 13:19 ` Cornelia Huck
2023-04-04 14:37 ` Michael S. Tsirkin
2023-04-10 16:21 ` Parav Pandit
2023-04-10 19:49 ` Michael S. Tsirkin
2023-04-10 19:57 ` [virtio-dev] " Parav Pandit
2023-04-10 20:02 ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 8:39 ` Cornelia Huck
2023-04-04 21:18 ` [virtio-dev] " Parav Pandit
2023-04-05 5:10 ` [virtio-dev] " Michael S. Tsirkin
2023-04-05 13:16 ` [virtio-dev] " Parav Pandit
2023-04-07 8:15 ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 1:36 ` [virtio-dev] " Jason Wang
2023-04-10 6:24 ` Michael S. Tsirkin
2023-04-10 7:16 ` Jason Wang
2023-04-10 10:04 ` Michael S. Tsirkin
2023-04-11 2:19 ` Jason Wang
2023-04-11 7:00 ` Michael S. Tsirkin
2023-04-11 9:07 ` Jason Wang
2023-04-11 10:43 ` Michael S. Tsirkin
2023-04-11 13:59 ` Parav Pandit
2023-04-11 14:11 ` Michael S. Tsirkin
2023-04-11 13:47 ` Parav Pandit
2023-04-11 14:02 ` Michael S. Tsirkin
2023-04-11 14:07 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-04-11 14:10 ` [virtio-dev] " Michael S. Tsirkin
2023-04-11 14:30 ` [virtio-dev] " Parav Pandit
2023-04-10 17:54 ` Parav Pandit
2023-04-10 17:58 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-04-11 3:28 ` Jason Wang
2023-04-11 19:01 ` Parav Pandit
2023-04-11 21:25 ` Michael S. Tsirkin
2023-04-12 0:40 ` Parav Pandit
2023-04-12 2:56 ` Michael S. Tsirkin
2023-04-12 4:07 ` Jason Wang
2023-04-12 4:20 ` Michael S. Tsirkin
2023-04-12 4:53 ` [virtio-dev] Re: [virtio-comment] " Jason Wang
2023-04-12 5:25 ` Michael S. Tsirkin
2023-04-12 5:37 ` Jason Wang
2023-04-13 17:03 ` Michael S. Tsirkin
2023-04-12 4:04 ` Jason Wang
2023-04-12 4:13 ` Parav Pandit
2023-04-12 4:20 ` Michael S. Tsirkin
2023-04-12 4:55 ` Jason Wang
2023-05-19 6:10 ` [virtio-dev] " Michael S. Tsirkin
2023-05-19 21:02 ` [virtio-dev] " Parav Pandit
2023-05-21 5:57 ` [virtio-dev] " Michael S. Tsirkin
2023-05-21 13:24 ` [virtio-dev] " Parav Pandit
2023-05-21 14:34 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 09/11] transport-pci: Describe PCI MMR dev config registers Parav Pandit
2023-04-07 8:55 ` [virtio-dev] " Michael S. Tsirkin
2023-04-10 1:33 ` [virtio-dev] Re: [virtio-comment] " Jason Wang
2023-04-10 6:14 ` Michael S. Tsirkin
2023-04-10 6:20 ` Jason Wang
2023-04-10 6:39 ` Michael S. Tsirkin
2023-04-10 7:20 ` Jason Wang
2023-04-10 10:06 ` Michael S. Tsirkin
2023-04-11 2:13 ` Jason Wang
2023-04-11 7:04 ` Michael S. Tsirkin
2023-04-11 9:01 ` Jason Wang
[not found] ` <CALBs2cXURMEzCGnULicXbsBfwnKE5cZOz=M-_hhFCXZ=Lqb9Nw@mail.gmail.com>
2023-04-11 10:39 ` Michael S. Tsirkin
2023-04-11 11:03 ` Yan Vugenfirer
2023-04-11 10:42 ` Michael S. Tsirkin
2023-04-12 3:58 ` Jason Wang
2023-04-12 4:15 ` Michael S. Tsirkin
2023-04-12 4:51 ` Jason Wang
2023-04-12 5:01 ` [virtio-dev] " Parav Pandit
2023-04-12 5:14 ` [virtio-dev] " Jason Wang
2023-04-12 5:30 ` [virtio-dev] " Parav Pandit
2023-04-12 5:38 ` [virtio-dev] " Jason Wang
2023-04-12 5:55 ` [virtio-dev] " Parav Pandit
2023-04-12 6:15 ` [virtio-dev] " Jason Wang
2023-04-12 14:23 ` [virtio-dev] " Parav Pandit
2023-04-13 1:48 ` [virtio-dev] " Jason Wang
2023-04-13 3:31 ` Parav Pandit
2023-04-13 5:14 ` Jason Wang
2023-04-13 17:19 ` Michael S. Tsirkin
2023-04-13 19:39 ` [virtio-dev] " Parav Pandit
2023-04-14 3:09 ` [virtio-dev] " Jason Wang
2023-04-14 3:18 ` [virtio-dev] " Parav Pandit
2023-04-14 3:37 ` [virtio-dev] " Jason Wang
2023-04-14 3:51 ` [virtio-dev] " Parav Pandit
2023-04-14 7:05 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 3:22 ` Jason Wang
2023-04-17 17:23 ` [virtio-dev] " Parav Pandit
2023-04-17 20:26 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 20:28 ` [virtio-dev] " Parav Pandit
2023-04-18 0:36 ` [virtio-dev] " Jason Wang
2023-04-18 1:30 ` [virtio-dev] " Parav Pandit
2023-04-18 11:58 ` [virtio-dev] " Michael S. Tsirkin
2023-04-18 12:09 ` [virtio-dev] " Parav Pandit
2023-04-18 12:30 ` [virtio-dev] " Michael S. Tsirkin
2023-04-18 12:36 ` [virtio-dev] " Parav Pandit
2023-04-18 1:01 ` [virtio-dev] " Jason Wang
2023-04-18 1:48 ` [virtio-dev] " Parav Pandit
2023-04-13 17:24 ` [virtio-dev] " Parav Pandit
2023-04-13 21:02 ` Michael S. Tsirkin
2023-04-13 21:08 ` [virtio-dev] " Parav Pandit
2023-04-14 2:36 ` [virtio-dev] " Jason Wang
2023-04-14 2:43 ` [virtio-dev] " Parav Pandit
2023-04-14 6:57 ` [virtio-dev] " Michael S. Tsirkin
2023-04-16 13:41 ` [virtio-dev] " Parav Pandit
2023-04-16 20:44 ` [virtio-dev] " Michael S. Tsirkin
2023-04-17 16:59 ` [virtio-dev] " Parav Pandit
2023-04-18 1:09 ` [virtio-dev] " Jason Wang
2023-04-18 1:37 ` [virtio-dev] " Parav Pandit
2023-04-14 6:58 ` [virtio-dev] " Michael S. Tsirkin
2023-04-14 3:08 ` Jason Wang
2023-04-14 3:13 ` [virtio-dev] " Parav Pandit
2023-04-14 3:18 ` [virtio-dev] " Jason Wang
2023-04-14 3:22 ` [virtio-dev] " Parav Pandit
2023-04-14 3:29 ` [virtio-dev] " Jason Wang
2023-04-11 13:57 ` [virtio-dev] " Parav Pandit
2023-04-12 4:33 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 10/11] transport-pci: Use driver notification PCI capability Parav Pandit
2023-04-12 4:31 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 4:37 ` [virtio-dev] " Parav Pandit
2023-04-12 4:43 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 4:48 ` [virtio-dev] " Parav Pandit
2023-04-12 5:02 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 5:06 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-04-12 5:17 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 5:24 ` [virtio-dev] " Parav Pandit
2023-04-12 5:27 ` [virtio-dev] " Michael S. Tsirkin
2023-03-30 22:58 ` [virtio-dev] [PATCH 11/11] conformance: Add transitional MMR interface conformance Parav Pandit
2023-03-31 7:03 ` [virtio-dev] Re: [PATCH 00/11] Introduce transitional mmr pci device Michael S. Tsirkin
2023-03-31 21:43 ` Parav Pandit
2023-04-03 14:53 ` Michael S. Tsirkin
2023-04-03 14:57 ` [virtio-dev] " Parav Pandit
2023-04-03 15:06 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:16 ` [virtio-dev] " Parav Pandit
2023-04-03 15:23 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 15:34 ` Michael S. Tsirkin
2023-04-03 15:47 ` [virtio-dev] " Parav Pandit
2023-04-03 17:28 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 17:35 ` Parav Pandit
2023-04-03 17:39 ` Michael S. Tsirkin
2023-04-03 15:36 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-04-03 17:16 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 17:29 ` Parav Pandit
2023-04-03 18:02 ` Michael S. Tsirkin
2023-04-03 20:25 ` [virtio-dev] " Parav Pandit
2023-04-03 21:04 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 22:00 ` Parav Pandit
2023-04-07 9:35 ` Michael S. Tsirkin
2023-04-10 1:52 ` Jason Wang
2023-04-03 14:45 ` [virtio-dev] Re: [virtio-comment] " Stefan Hajnoczi
2023-04-03 14:53 ` Parav Pandit
2023-04-03 17:48 ` Michael S. Tsirkin
2023-04-03 19:11 ` Stefan Hajnoczi
2023-04-03 20:03 ` Michael S. Tsirkin
2023-04-03 19:48 ` [virtio-dev] " Parav Pandit
2023-04-03 20:02 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 20:42 ` [virtio-dev] " Parav Pandit
2023-04-03 21:14 ` [virtio-dev] " Michael S. Tsirkin
2023-04-03 22:08 ` Parav Pandit
2023-04-03 19:10 ` Stefan Hajnoczi
2023-04-03 20:27 ` [virtio-dev] " Parav Pandit
2023-04-04 14:30 ` [virtio-dev] " Stefan Hajnoczi
2023-04-12 4:48 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 4:52 ` [virtio-dev] " Parav Pandit
2023-04-12 5:12 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 5:15 ` [virtio-dev] RE: [virtio-comment] " Parav Pandit
2023-04-12 5:23 ` [virtio-dev] " Michael S. Tsirkin
2023-04-12 5:39 ` [virtio-dev] " Parav Pandit
2023-04-12 6:02 ` Parav Pandit
2023-04-12 5:10 ` [virtio-dev] " Halil Pasic
2023-04-25 2:42 ` [virtio-dev] " Parav Pandit
2023-05-02 7:17 ` [virtio-dev] Re: [virtio-comment] " David Edmondson
2023-05-02 13:54 ` [virtio-dev] " Parav Pandit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230331024233-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=sburla@marvell.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).