WireGuard Archive on lore.kernel.org
 help / Atom feed
* Request for review: Add a short name attribute to peers for human friendly output
@ 2019-01-29 21:59 Jaseem Abid
  0 siblings, 0 replies; 1+ messages in thread
From: Jaseem Abid @ 2019-01-29 21:59 UTC (permalink / raw)
  To: wireguard

[-- Attachment #1.1: Type: text/plain, Size: 1348 bytes --]

Hello lovely WireGuard people,

I wrote a tiny patch to add a name attribute to peers because identifying
clients on my VPN just got very hard. Also hacking on wg source was a lot of
fun. I asked @zx2c4 about this a while ago and he was open to the idea.

It's not _really_ ready for a submission yet because of a few rough edges
but
I'd love to get some eyes on this if anyone is kind! I've never written any
kernel code before and my C is a bit rusty, so please feel free to be picky
about the review. I've added '*NOTE:*'s for the reviewer where I'm not sure
of
the approach.

A few other questions,

1. There are barely any inline code comments, is that intentional or
something
that the community would love to improve? I don't mean the really obvious
ones
but things that are tricky.

2. Is there any interest in a getting started guide for developers wanting
to
work on wireguard itself? Something like the usual CONTRIBUTING.md? I had
to dig
through a lot of netlink tutorials and old kernel newbie guides to make any
progress. It would be helpful to have it in one small doc.

The patch stays in the `name` branch here[1] and this commit does most of
the
work[2].

[1]: https://github.com/jaseemabid/WireGuard/tree/name
[2]: https://github.com/jaseemabid/WireGuard/commit/544e59b4

-- 
Regards,

Jaseem Abid
https://twitter.com/jaseemabid

[-- Attachment #1.2: Type: text/html, Size: 1799 bytes --]

<div dir="ltr"><div dir="ltr"><div dir="ltr">Hello lovely WireGuard people,<br><br>I wrote a tiny patch to add a name attribute to peers because identifying<br>clients on my VPN just got very hard. Also hacking on wg source was a lot of<br>fun. I asked @zx2c4 about this a while ago and he was open to the idea.<br><br>It&#39;s not _really_ ready for a submission yet because of a few rough edges but<br>I&#39;d love to get some eyes on this if anyone is kind! I&#39;ve never written any<br>kernel code before and my C is a bit rusty, so please feel free to be picky<br>about the review. I&#39;ve added &#39;*NOTE:*&#39;s for the reviewer where I&#39;m not sure of<br>the approach.<br><br>A few other questions,<br><br>1. There are barely any inline code comments, is that intentional or something<br>that the community would love to improve? I don&#39;t mean the really obvious ones<br>but things that are tricky.<br><br>2. Is there any interest in a getting started guide for developers wanting to<br>work on wireguard itself? Something like the usual CONTRIBUTING.md? I had to dig<br>through a lot of netlink tutorials and old kernel newbie guides to make any<br>progress. It would be helpful to have it in one small doc.<br><br>The patch stays in the `name` branch here[1] and this commit does most of the<br>work[2].<br><br>[1]: <a href="https://github.com/jaseemabid/WireGuard/tree/name">https://github.com/jaseemabid/WireGuard/tree/name</a><br>[2]: <a href="https://github.com/jaseemabid/WireGuard/commit/544e59b4">https://github.com/jaseemabid/WireGuard/commit/544e59b4</a><br><br><div>-- <br><div dir="ltr" class="gmail_signature">Regards, <br><br>Jaseem Abid<br><a href="https://twitter.com/jaseemabid" target="_blank">https://twitter.com/jaseemabid</a><br></div></div></div></div></div>

[-- Attachment #2: Type: text/plain, Size: 148 bytes --]

_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard

^ permalink raw reply	[flat|nested] 1+ messages in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-29 21:59 Request for review: Add a short name attribute to peers for human friendly output Jaseem Abid

WireGuard Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/wireguard/0 wireguard/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 wireguard wireguard/ https://lore.kernel.org/wireguard \
		wireguard@lists.zx2c4.com zx2c4-wireguard@archiver.kernel.org
	public-inbox-index wireguard


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/com.zx2c4.lists.wireguard


AGPL code for this site: git clone https://public-inbox.org/ public-inbox