From: Julien Grall <julien.grall@arm.com> To: Jan Beulich <JBeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs Date: Tue, 21 May 2019 10:35:56 +0100 [thread overview] Message-ID: <1c7f43ce-7df2-24c9-ecb2-d8be1afebfa5@arm.com> (raw) In-Reply-To: <5CE3C45A0200007800230E0E@prv1-mh.provo.novell.com> Hi Jan, On 5/21/19 10:26 AM, Jan Beulich wrote: >>>> On 20.05.19 at 20:12, <julien.grall@arm.com> wrote: >> As this is now Xen and tools only, I am wondering whether the check on >> GNU_C is still necessary. I am happy to send a follow-up patch (or fold >> in this one) if it can be removed. > > I think this should be dropped if it can be without breaking any > part of the build. This is because all the tools are part of xen.git, right? >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -197,6 +197,7 @@ >> } while ( 0 ) >> #define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) >> >> +#if defined(__XEN__) || defined(__XEN_TOOLS__) >> #if defined(__GNUC__) && !defined(__STRICT_ANSI__) >> /* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ >> # define __DECL_REG(n64, n32) union { \ >> @@ -272,6 +273,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); >> >> #undef __DECL_REG >> >> +#endif > > If I was the maintainer of this code, I'd ask for the struct declaration > to be moved (into the existing #if) rather than adding a 2nd #if. s/2nd/3rd/ ;) The reason I haven't done that is git will generate a completely unrelated diff. So it makes quite difficult to understand the purpose of the patch. Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com> To: Jan Beulich <JBeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org> Subject: Re: [Xen-devel] [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs Date: Tue, 21 May 2019 10:35:56 +0100 [thread overview] Message-ID: <1c7f43ce-7df2-24c9-ecb2-d8be1afebfa5@arm.com> (raw) Message-ID: <20190521093556.c-l1pQDaLRaeh6oYxF9bejME6J4gr9gK-5ZQVv0zAp8@z> (raw) In-Reply-To: <5CE3C45A0200007800230E0E@prv1-mh.provo.novell.com> Hi Jan, On 5/21/19 10:26 AM, Jan Beulich wrote: >>>> On 20.05.19 at 20:12, <julien.grall@arm.com> wrote: >> As this is now Xen and tools only, I am wondering whether the check on >> GNU_C is still necessary. I am happy to send a follow-up patch (or fold >> in this one) if it can be removed. > > I think this should be dropped if it can be without breaking any > part of the build. This is because all the tools are part of xen.git, right? >> --- a/xen/include/public/arch-arm.h >> +++ b/xen/include/public/arch-arm.h >> @@ -197,6 +197,7 @@ >> } while ( 0 ) >> #define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val) >> >> +#if defined(__XEN__) || defined(__XEN_TOOLS__) >> #if defined(__GNUC__) && !defined(__STRICT_ANSI__) >> /* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */ >> # define __DECL_REG(n64, n32) union { \ >> @@ -272,6 +273,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t); >> >> #undef __DECL_REG >> >> +#endif > > If I was the maintainer of this code, I'd ask for the struct declaration > to be moved (into the existing #if) rather than adding a 2nd #if. s/2nd/3rd/ ;) The reason I haven't done that is git will generate a completely unrelated diff. So it makes quite difficult to understand the purpose of the patch. Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-21 9:36 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-20 18:12 [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs Julien Grall 2019-05-20 18:12 ` [Xen-devel] " Julien Grall 2019-05-21 9:26 ` Jan Beulich 2019-05-21 9:26 ` [Xen-devel] " Jan Beulich 2019-05-21 9:35 ` Julien Grall [this message] 2019-05-21 9:35 ` Julien Grall 2019-05-21 9:43 ` Jan Beulich 2019-05-21 9:43 ` [Xen-devel] " Jan Beulich 2019-05-21 9:55 ` Julien Grall 2019-05-21 9:55 ` [Xen-devel] " Julien Grall 2019-05-21 21:06 ` Stefano Stabellini 2019-05-21 21:06 ` [Xen-devel] " Stefano Stabellini 2019-05-22 12:20 ` Julien Grall 2019-05-22 12:20 ` [Xen-devel] " Julien Grall 2019-05-22 12:29 ` Jan Beulich 2019-05-22 12:29 ` [Xen-devel] " Jan Beulich 2019-05-22 13:00 ` Julien Grall 2019-05-22 13:00 ` [Xen-devel] " Julien Grall 2019-05-22 18:05 ` Artem Mygaiev 2019-05-22 18:05 ` [Xen-devel] " Artem Mygaiev 2019-06-02 10:37 ` Julien Grall 2019-06-02 10:37 ` [Xen-devel] " Julien Grall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1c7f43ce-7df2-24c9-ecb2-d8be1afebfa5@arm.com \ --to=julien.grall@arm.com \ --cc=Ian.Jackson@eu.citrix.com \ --cc=JBeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=sstabellini@kernel.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).