xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs
Date: Wed, 22 May 2019 13:20:45 +0100	[thread overview]
Message-ID: <83c1a4f7-0714-0ee5-e225-835126d92c5d@arm.com> (raw)
In-Reply-To: <f2f912ac-a1c6-1f07-f708-cf2935c0270f@arm.com>



On 21/05/2019 10:55, Julien Grall wrote:
> Hi Jan,
> 
> On 5/21/19 10:43 AM, Jan Beulich wrote:
>>>>> On 21.05.19 at 11:35, <julien.grall@arm.com> wrote:
>>> On 5/21/19 10:26 AM, Jan Beulich wrote:
>>>>>>> On 20.05.19 at 20:12, <julien.grall@arm.com> wrote:
>>>>>       As this is now Xen and tools only, I am wondering whether the check on
>>>>>       GNU_C is still necessary. I am happy to send a follow-up patch (or fold
>>>>>       in this one) if it can be removed.
>>>>
>>>> I think this should be dropped if it can be without breaking any
>>>> part of the build.
>>> This is because all the tools are part of xen.git, right?
>>
>> Right - no-one else is supposed to define __XEN_TOOLS__, or
>> if anyone does, they're on their own.
> 
> Thanks for the information. I will do a full build check.

I thought about this again, long term there are an attempt to build xen with 
other compiler not necessarily supporting GNU C extension.

While this would probably not be the only place that need to be reworked, we 
would have to revert part of this change. So I will not drop the #ifdef here.

I will resend the patch next week to give some time for more feedback.


Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs
Date: Wed, 22 May 2019 13:20:45 +0100	[thread overview]
Message-ID: <83c1a4f7-0714-0ee5-e225-835126d92c5d@arm.com> (raw)
Message-ID: <20190522122045.Icai35w-hGqBfl8I4UkI3XJPPP3s425ecDqnFyWS_94@z> (raw)
In-Reply-To: <f2f912ac-a1c6-1f07-f708-cf2935c0270f@arm.com>



On 21/05/2019 10:55, Julien Grall wrote:
> Hi Jan,
> 
> On 5/21/19 10:43 AM, Jan Beulich wrote:
>>>>> On 21.05.19 at 11:35, <julien.grall@arm.com> wrote:
>>> On 5/21/19 10:26 AM, Jan Beulich wrote:
>>>>>>> On 20.05.19 at 20:12, <julien.grall@arm.com> wrote:
>>>>>       As this is now Xen and tools only, I am wondering whether the check on
>>>>>       GNU_C is still necessary. I am happy to send a follow-up patch (or fold
>>>>>       in this one) if it can be removed.
>>>>
>>>> I think this should be dropped if it can be without breaking any
>>>> part of the build.
>>> This is because all the tools are part of xen.git, right?
>>
>> Right - no-one else is supposed to define __XEN_TOOLS__, or
>> if anyone does, they're on their own.
> 
> Thanks for the information. I will do a full build check.

I thought about this again, long term there are an attempt to build xen with 
other compiler not necessarily supporting GNU C extension.

While this would probably not be the only place that need to be reworked, we 
would have to revert part of this change. So I will not drop the #ifdef here.

I will resend the patch next week to give some time for more feedback.


Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-22 12:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20 18:12 [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs Julien Grall
2019-05-20 18:12 ` [Xen-devel] " Julien Grall
2019-05-21  9:26 ` Jan Beulich
2019-05-21  9:26   ` [Xen-devel] " Jan Beulich
2019-05-21  9:35   ` Julien Grall
2019-05-21  9:35     ` [Xen-devel] " Julien Grall
2019-05-21  9:43     ` Jan Beulich
2019-05-21  9:43       ` [Xen-devel] " Jan Beulich
2019-05-21  9:55       ` Julien Grall
2019-05-21  9:55         ` [Xen-devel] " Julien Grall
2019-05-21 21:06         ` Stefano Stabellini
2019-05-21 21:06           ` [Xen-devel] " Stefano Stabellini
2019-05-22 12:20         ` Julien Grall [this message]
2019-05-22 12:20           ` Julien Grall
2019-05-22 12:29           ` Jan Beulich
2019-05-22 12:29             ` [Xen-devel] " Jan Beulich
2019-05-22 13:00             ` Julien Grall
2019-05-22 13:00               ` [Xen-devel] " Julien Grall
2019-05-22 18:05               ` Artem Mygaiev
2019-05-22 18:05                 ` [Xen-devel] " Artem Mygaiev
2019-06-02 10:37                 ` Julien Grall
2019-06-02 10:37                   ` [Xen-devel] " Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83c1a4f7-0714-0ee5-e225-835126d92c5d@arm.com \
    --to=julien.grall@arm.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).