Re: [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs

From: "Jan Beulich" <JBeulich@suse.com>
To: Julien Grall <julien.grall@arm.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] xen/public: arch-arm: Restrict the visibility of struct vcpu_guest_core_regs
Date: Tue, 21 May 2019 03:26:50 -0600	[thread overview]
Message-ID: <5CE3C45A0200007800230E0E@prv1-mh.provo.novell.com> (raw)
In-Reply-To: <20190520181250.17404-1-julien.grall@arm.com>

>>> On 20.05.19 at 20:12, <julien.grall@arm.com> wrote:
>     As this is now Xen and tools only, I am wondering whether the check on
>     GNU_C is still necessary. I am happy to send a follow-up patch (or fold
>     in this one) if it can be removed.

I think this should be dropped if it can be without breaking any
part of the build.

> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -197,6 +197,7 @@
>      } while ( 0 )
>  #define set_xen_guest_handle(hnd, val) set_xen_guest_handle_raw(hnd, val)
>  
> +#if defined(__XEN__) || defined(__XEN_TOOLS__)
>  #if defined(__GNUC__) && !defined(__STRICT_ANSI__)
>  /* Anonymous union includes both 32- and 64-bit names (e.g., r0/x0). */
>  # define __DECL_REG(n64, n32) union {          \
> @@ -272,6 +273,8 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_core_regs_t);
>  
>  #undef __DECL_REG
>  
> +#endif

If I was the maintainer of this code, I'd ask for the struct declaration
to be moved (into the existing #if) rather than adding a 2nd #if.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel