From: Konrad Rzeszutek Wilk <konrad@kernel.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>,
andrew.cooper3@citrix.com,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
mpohlack@amazon.de, ross.lagerwall@citrix.com,
sasha.levin@oracle.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v5 09/28] xsplice: Add helper elf routines
Date: Tue, 5 Apr 2016 21:38:58 -0400 [thread overview]
Message-ID: <20160406013857.GA5468@localhost.localdomain> (raw)
In-Reply-To: <56FD2E2F02000078000E1BA2@prv-mh.provo.novell.com>
> > +static int elf_resolve_sections(struct xsplice_elf *elf, const void *data)
> > +{
.. snip..
> > + /* N.B. We also will ingest SHN_UNDEF sections. */
>
> Because of? The meaning of the fields in the 0-th section header is
> different from that of ordinary ones.
>
> > + for ( i = 0; i < elf->hdr->e_shnum; i++ )
The reason for this is not obvious .. In the payload loading patch I
iterate over each elf->sec (starting at zero) and immediately
dereference the sh_type:
if ( (elf->sec[i].sec->sh_flags .. )
As you can imagine if I don't set elf->sec[0].sec this blows up. Hence
the odd start at zero.
However one can as well just fix the loop in 'move_payload' to start
at 1 instead of 0 - which is what I did.
> > + {
> > + ssize_t delta = elf->hdr->e_shoff + i * elf->hdr->e_shentsize;
>
> Why ssize_t? (This anyway should be a suitable ELF type.)
>
> > +
> > + if ( delta + sizeof(Elf_Shdr) > elf->len )
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: Section header [%d] is past end of payload!\n",
> > + XSPLICE, elf->name, i);
>
> XSPLICE is a string literal, so should be prepended to the format
> string instead of forced through %s. And %u please for unsigned
> arguments.
>
> Also this check doesn't need doing inside the loop - you can simply
> check once (using e_shnum) that the entire section table is valid.
>
> > + return -EINVAL;
> > + }
> > +
> > + sec[i].sec = (Elf_Shdr *)(data + delta);
>
> Pointless cast bogusly casting away constness.
>
> > + delta = sec[i].sec->sh_offset;
> > +
> > + if ( delta > elf->len )
>
> This is relevant only for sections having non-zero size. And then you of
> course need to take size into account when dong the bounds check.
>
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: Section [%d] data is past end of payload!\n",
> > + XSPLICE, elf->name, i);
> > + return -EINVAL;
> > + }
> > +
> > + sec[i].data = data + delta;
> > + /* Name is populated in xsplice_elf_sections_name. */
> > + sec[i].name = NULL;
> > +
> > + if ( sec[i].sec->sh_type == SHT_SYMTAB )
> > + {
> > + if ( elf->symtab )
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: Multiple symbol tables!\n",
> > + XSPLICE, elf->name);
> > + return -EINVAL;
>
> There's nothing invalid about this, it's simply unsupported by the
> implementation (read: a better error code please).
>
> > + }
> > +
> > + elf->symtab = &sec[i];
> > +
> > + /*
> > + * elf->symtab->sec->sh_link would point to the right section
> > + * but we hadn't finished parsing all the sections.
> > + */
> > + if ( elf->symtab->sec->sh_link > elf->hdr->e_shnum )
>
> >=
>
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: Symbol table idx (%d) to strtab past end (%d)\n",
> > + XSPLICE, elf->name, elf->symtab->sec->sh_link,
> > + elf->hdr->e_shnum);
> > + return -EINVAL;
> > + }
> > + }
> > + }
> > +
> > + if ( !elf->symtab )
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: No symbol table found!\n",
> > + XSPLICE, elf->name);
> > + return -EINVAL;
> > + }
> > +
> > + /* There can be multiple SHT_STRTAB so pick the right one. */
> > + elf->strtab = &sec[elf->symtab->sec->sh_link];
>
> How about checking this really is a SHT_STRTAB section?
>
> > + if ( !elf->symtab->sec->sh_size || !elf->symtab->sec->sh_entsize ||
> > + elf->symtab->sec->sh_entsize != sizeof(Elf_Sym) )
>
> The first sh_entsize check is redundant with the second, and the
> second is too strict (< suffices).
>
> Also shouldn't the string table section also have at least non-zero
> size? And its first and last bytes be NUL?
>
> > +static int elf_resolve_section_names(struct xsplice_elf *elf, const void *data)
> > +{
> > + const char *shstrtab;
> > + unsigned int i;
> > + unsigned int offset, delta;
> > +
> > + /*
> > + * The elf->sec[0 -> e_shnum] structures have been verified by
> > + * elf_resolve_sections. Find file offset for section string table.
> > + */
> > + offset = elf->sec[elf->hdr->e_shstrndx].sec->sh_offset;
>
> Truncating the value on 64-bit ELF.
>
> > + if ( offset > elf->len )
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: shstrtab section offset (%u) past end of payload!\n",
> > + XSPLICE, elf->name, elf->hdr->e_shstrndx);
> > + return -EINVAL;
> > + }
> > +
> > + shstrtab = (data + offset);
>
> Pointless parentheses.
>
> > + /* We could ignore the first as it is reserved.. */
>
> Double full stop.
>
> > + for ( i = 0; i < elf->hdr->e_shnum; i++ )
> > + {
> > + delta = elf->sec[i].sec->sh_name;
> > +
> > + if ( offset + delta > elf->len )
>
> This is too weak: After having bounds checked the string table section
> to be inside the image, you now need to bounds check the string offset
> to be inside the string table. Also it seems (just like above) you
> no-where check that the referenced section actually is a string table.
>
> > +static int elf_get_sym(struct xsplice_elf *elf, const void *data)
> > +{
> > + struct xsplice_elf_sec *symtab_sec, *strtab_sec;
> > + struct xsplice_elf_sym *sym;
> > + unsigned int i, delta, offset, nsym;
> > +
> > + symtab_sec = elf->symtab;
> > + strtab_sec = elf->strtab;
> > +
> > + /* Pointers arithmetic to get file offset. */
> > + offset = strtab_sec->data - data;
> > +
> > + ASSERT(offset == strtab_sec->sec->sh_offset);
> > +
> > + /* symtab_sec->data was computed in elf_resolve_sections. */
> > + ASSERT((symtab_sec->sec->sh_offset + data) == symtab_sec->data);
> > +
> > + /* No need to check values as elf_resolve_sections did it. */
> > + nsym = symtab_sec->sec->sh_size / symtab_sec->sec->sh_entsize;
> > +
> > + sym = xmalloc_array(struct xsplice_elf_sym, nsym);
> > + if ( !sym )
> > + {
> > + printk(XENLOG_ERR "%s%s: Could not allocate memory for symbols\n",
> > + XSPLICE, elf->name);
> > + return -ENOMEM;
> > + }
> > +
> > + /* So we don't leak memory. */
> > + elf->sym = sym;
> > + for ( i = 0; i < nsym; i++ )
>
> As with sections, the 0th symbol table entry is special too.
>
> > + {
> > + Elf_Sym *s;
> > +
> > + if ( i * sizeof(Elf_Sym) > elf->len )
>
> Considering that we know the symbol table section is within bounds,
> I don't think this check does any good. Plus it ought to be adding 1
> to i and take the section file offset into account.
>
> > + {
> > + dprintk(XENLOG_DEBUG, "%s%s: Symbol header [%d] is past end of payload!\n",
> > + XSPLICE, elf->name, i);
> > + return -EINVAL;
> > + }
> > +
> > + s = &((Elf_Sym *)symtab_sec->data)[i];
> > +
> > + /* If st->name is STN_UNDEF is zero, the check will always be true. */
>
> Odd double use of "is".
>
> > + delta = s->st_name;
> > +
> > + /* Offset has been computed earlier. */
> > + if ( offset + delta > elf->len )
>
> This should again check against the string table size and again use >= .
I reworked this a bit (borrowed your idea of checking the full size of
the section before the loop) - which removes the need to check
the offset.
What I ended up is something much simpler (as I know the offset
is OK - I just need to check that the delta is within the section):
if ( delta && (delta > strtab_sec->sec->sec_sh_size) )
..
The offset gets (in the new patchset) checked in elf_resolve_section.
Albeit I am not sure about the >= instead of >, .. I need to think of
that.
.. snip..
> > +void xsplice_elf_free(struct xsplice_elf *elf)
> > +{
> > + xfree(elf->sec);
> > + elf->sec = NULL;
> > + xfree(elf->sym);
> > + elf->sym = NULL;
> > + elf->nsym = 0;
> > + elf->name = NULL;
> > + elf->len = 0;
> > +}
>
> Instead of zeroing these fields, wouldn't it make sense to simply
> xfree(elf) as the last action here?
The struct xsplice_elf is allocated on the stack (in the next
patch).
> > --- /dev/null
> > +++ b/xen/include/xen/xsplice_elf.h
.. snip..
> > +struct xsplice_elf_sym {
> > + Elf_Sym *sym;
>
> const?
.. this is much harder. I end up computing the values for
these symbols and have to write to this this structure a couple of times
(at worst).
>
> > + const char *name;
> > +};
> > +
> > +struct xsplice_elf {
> > + const char *name; /* Pointer to payload->name. */
> > + ssize_t len; /* Length of the ELF file. */
>
> Why ssize_t?
Made it 'size_t'
>
> > + Elf_Ehdr *hdr; /* ELF file. */
> > + struct xsplice_elf_sec *sec; /* Array of sections, allocated by us. */
> > + struct xsplice_elf_sym *sym; /* Array of symbols , allocated by us. */
> > + unsigned int nsym;
> > + struct xsplice_elf_sec *symtab;/* Pointer to .symtab section - aka to sec[x]. */
> > + struct xsplice_elf_sec *strtab;/* Pointer to .strtab section - aka to sec[y]. */
>
> Many times - const?
I have made the symtab and strtab const, but the 'sec' and 'sym'
I can't easily. There are many instances where I poke in the
section (like for ELF relocations) and have to modify this.
I can do some casting but it gets a bit .. messy.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 1:39 UTC|newest]
Thread overview: 190+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 20:00 [PATCH v5] xSplice v1 design and implementation Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane Konrad Rzeszutek Wilk
2016-03-24 20:22 ` Andrew Cooper
2016-03-24 21:07 ` Konrad Rzeszutek Wilk
2016-03-24 21:30 ` Konrad Rzeszutek Wilk
2016-03-30 15:43 ` Jan Beulich
2016-03-31 6:30 ` Jan Beulich
2016-03-31 11:43 ` Konrad Rzeszutek Wilk
2016-03-31 12:07 ` Jan Beulich
2016-03-31 13:28 ` REST MAINTAINERS feedback requested Was:Re: " Konrad Rzeszutek Wilk
2016-03-31 13:50 ` Jan Beulich
2016-04-08 16:33 ` Jan Beulich
2016-04-08 17:09 ` Konrad Rzeszutek Wilk
2016-04-08 17:13 ` Jan Beulich
2016-04-08 17:21 ` Wei Liu
2016-04-08 17:23 ` Konrad Rzeszutek Wilk
2016-04-08 17:27 ` Wei Liu
2016-04-08 17:21 ` Ian Jackson
2016-04-08 17:41 ` Andrew Cooper
2016-04-08 17:54 ` Jan Beulich
2016-04-11 10:50 ` Ian Jackson
2016-04-11 13:56 ` Konrad Rzeszutek Wilk
2016-04-11 14:22 ` Ian Jackson
2016-04-11 15:48 ` Jan Beulich
2016-04-11 16:25 ` Ian Jackson
2016-04-11 16:53 ` Konrad Rzeszutek Wilk
2016-04-11 17:06 ` Jan Beulich
2016-04-11 17:00 ` Jan Beulich
2016-04-11 17:13 ` Ian Jackson
2016-04-11 17:34 ` Jan Beulich
2016-04-11 17:46 ` Jan Beulich
2016-04-12 9:58 ` George Dunlap
2016-04-12 13:56 ` Konrad Rzeszutek Wilk
2016-04-12 14:38 ` George Dunlap
2016-04-12 15:00 ` Konrad Rzeszutek Wilk
2016-04-12 15:26 ` Ian Jackson
2016-04-13 4:21 ` Jan Beulich
2016-04-13 16:07 ` Ian Jackson
2016-04-14 15:13 ` George Dunlap
2016-04-14 15:59 ` Jan Beulich
2016-04-14 16:19 ` George Dunlap
2016-04-14 17:01 ` Jan Beulich
2016-04-14 18:11 ` REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane. [and 1 more messages] Ian Jackson
2016-04-14 19:22 ` Konrad Rzeszutek Wilk
2016-04-17 7:23 ` Jan Beulich
2016-04-15 11:23 ` REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane George Dunlap
2016-04-17 7:52 ` Jan Beulich
2016-04-12 15:31 ` Jan Beulich
2016-04-12 15:17 ` Jan Beulich
2016-04-12 15:28 ` Konrad Rzeszutek Wilk
2016-04-08 17:24 ` George Dunlap
2016-04-08 17:34 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 02/28] libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION hypercall Konrad Rzeszutek Wilk
2016-03-24 21:24 ` Wei Liu
2016-03-25 13:21 ` Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 03/28] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup Konrad Rzeszutek Wilk
2016-03-30 16:09 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 04/28] vmap: Add vmalloc_cb and vfree_cb Konrad Rzeszutek Wilk
2016-03-30 16:24 ` Jan Beulich
2016-03-30 16:44 ` Konrad Rzeszutek Wilk
2016-03-31 6:46 ` Jan Beulich
2016-03-31 11:49 ` Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 05/28] xsplice: Design document Konrad Rzeszutek Wilk
2016-03-29 9:36 ` Jan Beulich
2016-03-29 20:46 ` Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 06/28] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op Konrad Rzeszutek Wilk
2016-03-31 9:45 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 07/28] libxc: Implementation of XEN_XSPLICE_op in libxc Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 08/28] xen-xsplice: Tool to manipulate xsplice payloads Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 09/28] xsplice: Add helper elf routines Konrad Rzeszutek Wilk
2016-03-31 12:03 ` Jan Beulich
2016-04-06 1:38 ` Konrad Rzeszutek Wilk [this message]
2016-04-07 0:38 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 10/28] xsplice: Implement payload loading Konrad Rzeszutek Wilk
2016-03-31 13:45 ` Jan Beulich
2016-03-31 21:26 ` Konrad Rzeszutek Wilk
2016-04-01 9:18 ` Jan Beulich
2016-04-04 19:44 ` Konrad Rzeszutek Wilk
2016-04-05 1:57 ` Konrad Rzeszutek Wilk
2016-04-05 7:34 ` Jan Beulich
2016-04-05 15:50 ` Konrad Rzeszutek Wilk
2016-04-05 16:15 ` Jan Beulich
2016-04-05 16:45 ` Konrad Rzeszutek Wilk
2016-04-05 17:48 ` Konrad Rzeszutek Wilk
2016-04-07 0:49 ` Jan Beulich
2016-04-07 0:46 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches Konrad Rzeszutek Wilk
2016-04-01 13:28 ` Jan Beulich
2016-04-01 21:04 ` Konrad Rzeszutek Wilk
2016-04-04 7:07 ` Jan Beulich
2016-04-07 3:05 ` Konrad Rzeszutek Wilk
2016-04-07 15:38 ` Jan Beulich
2016-04-09 14:42 ` Konrad Rzeszutek Wilk
2016-04-11 15:38 ` Jan Beulich
2016-04-07 3:09 ` Konrad Rzeszutek Wilk
2016-04-07 15:43 ` Jan Beulich
2016-04-10 2:36 ` Konrad Rzeszutek Wilk
2016-04-10 2:45 ` Konrad Rzeszutek Wilk
2016-04-11 15:41 ` Jan Beulich
2016-04-11 23:29 ` Konrad Rzeszutek Wilk
2016-04-10 19:47 ` Is: ARM maintainers advice ..Was:Re: " Konrad Rzeszutek Wilk
2016-04-10 20:58 ` Stefano Stabellini
2016-04-11 15:44 ` Jan Beulich
2016-04-11 15:50 ` Konrad Rzeszutek Wilk
2016-04-11 16:05 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 12/28] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version' Konrad Rzeszutek Wilk
2016-04-01 13:33 ` Jan Beulich
2016-04-06 2:03 ` Konrad Rzeszutek Wilk
2016-04-07 1:03 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 13/28] xsplice, symbols: Implement symbol name resolution on address Konrad Rzeszutek Wilk
2016-04-01 15:11 ` Jan Beulich
2016-04-07 3:14 ` Konrad Rzeszutek Wilk
2016-04-07 15:46 ` Jan Beulich
2016-04-08 1:32 ` Konrad Rzeszutek Wilk
2016-04-08 15:21 ` Jan Beulich
2016-04-08 15:27 ` Konrad Rzeszutek Wilk
2016-04-08 15:29 ` Jan Beulich
[not found] ` <5707D68A.8090006@citrix.com>
[not found] ` <5707FA8B02000078000E6178@prv-mh.provo.novell.com>
2016-04-11 8:07 ` Ross Lagerwall
2016-03-24 20:00 ` [PATCH v5 14/28] x86, xsplice: Print payload's symbol name and payload name in backtraces Konrad Rzeszutek Wilk
2016-04-01 15:23 ` Jan Beulich
2016-04-06 2:39 ` Konrad Rzeszutek Wilk
2016-04-07 1:07 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case Konrad Rzeszutek Wilk
2016-04-01 15:50 ` Jan Beulich
2016-04-06 2:42 ` Konrad Rzeszutek Wilk
2016-04-06 6:39 ` Martin Pohlack
2016-04-07 1:15 ` Jan Beulich
2016-04-08 15:57 ` Ross Lagerwall
2016-04-08 17:39 ` Jan Beulich
2016-04-11 8:23 ` Ross Lagerwall
2016-04-22 13:33 ` Jan Beulich
2016-04-22 13:58 ` Jan Beulich
2016-04-22 17:32 ` Konrad Rzeszutek Wilk
2016-04-07 1:11 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 16/28] xsplice: Add support for bug frames Konrad Rzeszutek Wilk
2016-04-01 16:00 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 17/28] xsplice: Add support for exception tables Konrad Rzeszutek Wilk
2016-04-01 16:06 ` Jan Beulich
2016-04-06 14:41 ` Konrad Rzeszutek Wilk
2016-04-06 15:32 ` Andrew Cooper
2016-04-07 1:21 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 18/28] xsplice: Add support for alternatives Konrad Rzeszutek Wilk
2016-04-01 16:20 ` Jan Beulich
2016-04-07 3:11 ` Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 19/28] build_id: Provide ld-embedded build-ids Konrad Rzeszutek Wilk
2016-04-04 12:46 ` Jan Beulich
2016-04-07 2:58 ` Konrad Rzeszutek Wilk
2016-04-08 15:49 ` Ross Lagerwall
2016-04-08 18:47 ` Konrad Rzeszutek Wilk
2016-04-08 18:54 ` Andrew Cooper
2016-04-08 19:54 ` Jan Beulich
2016-04-08 0:18 ` Konrad Rzeszutek Wilk
2016-04-08 1:52 ` Konrad Rzeszutek Wilk
2016-04-08 15:27 ` Jan Beulich
2016-04-08 17:06 ` Konrad Rzeszutek Wilk
2016-04-08 17:44 ` Jan Beulich
2016-04-08 19:23 ` Konrad Rzeszutek Wilk
2016-04-08 19:39 ` Konrad Rzeszutek Wilk
2016-04-08 20:14 ` Jan Beulich
2016-04-08 20:50 ` Konrad Rzeszutek Wilk
2016-04-08 21:11 ` Jan Beulich
2016-04-08 21:15 ` Konrad Rzeszutek Wilk
2016-04-08 15:25 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 20/28] HYPERCALL_version_op: Add VERSION_build_id to retrieve build-id Konrad Rzeszutek Wilk
2016-03-25 16:26 ` Daniel De Graaf
2016-04-04 13:35 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 21/28] libxl: info: Display build_id of the hypervisor using XEN_VERSION_build_id Konrad Rzeszutek Wilk
2016-03-25 13:25 ` Konrad Rzeszutek Wilk
2016-03-25 15:27 ` Wei Liu
2016-03-24 20:00 ` [PATCH v5 22/28] xsplice: Print build_id in keyhandler and on bootup Konrad Rzeszutek Wilk
2016-04-04 13:38 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 23/28] xsplice: Stacking build-id dependency checking Konrad Rzeszutek Wilk
2016-04-04 15:00 ` Jan Beulich
2016-04-04 20:01 ` Konrad Rzeszutek Wilk
2016-04-05 7:43 ` Jan Beulich
2016-04-08 16:15 ` Ross Lagerwall
2016-04-08 17:47 ` Jan Beulich
2016-04-06 20:05 ` Konrad Rzeszutek Wilk
2016-04-07 1:24 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 24/28] xsplice/xen_replace_world: Test-case for XSPLICE_ACTION_REPLACE Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 25/28] xsplice: Print dependency and payloads build_id in the keyhandler Konrad Rzeszutek Wilk
2016-04-04 15:03 ` Jan Beulich
2016-03-24 20:00 ` [PATCH v5 26/28] xsplice: Prevent duplicate payloads from being loaded Konrad Rzeszutek Wilk
2016-04-04 15:06 ` Jan Beulich
2016-04-04 19:52 ` Konrad Rzeszutek Wilk
2016-03-24 20:00 ` [PATCH v5 27/28] xsplice: Add support for shadow variables Konrad Rzeszutek Wilk
2016-04-04 15:18 ` Jan Beulich
2016-04-06 2:26 ` Konrad Rzeszutek Wilk
2016-04-08 15:58 ` Ross Lagerwall
2016-03-24 20:00 ` [PATCH v5 28/28] MAINTAINERS/xsplice: Add myself and Ross as the maintainers Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406013857.GA5468@localhost.localdomain \
--to=konrad@kernel.org \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=mpohlack@amazon.de \
--cc=ross.lagerwall@citrix.com \
--cc=sasha.levin@oracle.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).