Re: REST MAINTAINERS feedback requested Was:Re: [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

[George Dunlap <dunlapg@umich.edu>]

On Tue, Apr 12, 2016 at 2:56 PM, Konrad Rzeszutek Wilk
<konrad.wilk@oracle.com> wrote:
>> 3. We could use a new hypercall only for new functionality, with the
>> proposed new semantics.  This would at minimum be build-id, but
>> probably also extraversion, compileinfo, changeset, maybe
>> capabilities_info.
>>
>> 4. Have the new hypercall replace the old hypercall.  The new
>> hypercall will duplicate all the functionality of the old hypercall.
>> Deprecate the hypercall for a release or two, then remove it from the
>> public headers (although keep the code, because we need to maintain
>> backwards compatibility).
>
> 5). Stick the build-id in the xsplice sysctl. Or just in the sysctl.

Which is somewhat similar to #3, except that instead of being in its
own hypercall, it's with a bunch of other related functionality.  I'd
be OK with that color too; it's not a great color but I think it's
better than 3. :-)

>> This does seem to me an awful lot like a bike shed. :-)  All of the
>
> This is really past bike shedding - all the bikes shed have been
> already built (for all those options).

You mean, the shed already has 3 layers of paint, a layer of
wallpaper, and a layer of plastic siding? :-)

>> options (1-4) seem perfectly fine to me.  FWIW my preferred color
>> would probably be 1 because it's the easiest and least inconsistent
>> with the current state of things. My least favorite would be 3,
>> because although each individual piece of information is only in one
>> place, the path to get there is duplicated; both the kernel developer
>> and the hypervisor developer are forced to continue to deal with both.
>>
>
>
> The state is that 1-3 have been Nacked by Andrew, 4 has been
> Nacked by Jan. And 5) (the original way) was way way back Nacked
> as well.

There's a difference between "I think this other way is better" and "I
am absolutely opposed to this".

Well we know which option Andy prefers, but are there other options
that Andy is not absolutely opposed to?  And we don't know anything
about which option Jan prefers at all, except that it's not #4.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel