From: "Jan Beulich" <JBeulich@suse.com>
To: "Volodymyr Babchuk" <volodymyr_babchuk@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xenproject.org>,
"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets
Date: Wed, 15 May 2019 01:24:37 -0600 [thread overview]
Message-ID: <5CDBBEB5020000780022F176@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190515072437.rDltKsdW-QiCiyeG_nsuQrrCqkP8gFHMCpx8LBAvNf4@z> (raw)
In-Reply-To: <20190514184552.25100-1-volodymyr_babchuk@epam.com>
>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@epam.com> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \
> $(kconfig):
> $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
So the rule you add matches this one. Is there a reason ...
> +%_defconfig:
... why you can't simply add this to the kconfig variable set a few
lines up? Oh - newer make doesn't like mixing pattern and
non-pattern rules. Perhaps worth a brief comment, to justify the
redundancy? Or alternatively, how about using $(wildcard )
instead of a pattern rule, thus rejecting invalid targets right away,
rather than deferring to the recursive make to notice the error?
Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-15 7:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 18:45 [PATCH v1 1/2] makefile: add support for *_defconfig targets Volodymyr Babchuk
2019-05-14 18:45 ` [Xen-devel] " Volodymyr Babchuk
2019-05-14 18:45 ` [PATCH v1 2/2] arm: rename tiny64.conf to tiny64_defconfig Volodymyr Babchuk
2019-05-14 18:45 ` [Xen-devel] " Volodymyr Babchuk
2019-05-15 7:24 ` Jan Beulich [this message]
2019-05-15 7:24 ` [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets Jan Beulich
2019-05-15 19:07 ` Volodymyr Babchuk
2019-05-15 19:07 ` [Xen-devel] " Volodymyr Babchuk
2019-05-16 7:21 ` Jan Beulich
2019-05-16 7:21 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CDBBEB5020000780022F176@prv1-mh.provo.novell.com \
--to=jbeulich@suse.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=andrii_anisov@epam.com \
--cc=julien.grall@arm.com \
--cc=konrad.wilk@oracle.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=volodymyr_babchuk@epam.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).