From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> To: Jan Beulich <JBeulich@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Andrii Anisov <Andrii_Anisov@epam.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> Subject: Re: [PATCH v1 1/2] makefile: add support for *_defconfig targets Date: Wed, 15 May 2019 19:07:57 +0000 [thread overview] Message-ID: <87bm038rjn.fsf@epam.com> (raw) In-Reply-To: <5CDBBEB5020000780022F176@prv1-mh.provo.novell.com> Hello Jan, Jan Beulich writes: >>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@epam.com> wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \ >> $(kconfig): >> $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@ > > So the rule you add matches this one. Is there a reason ... > >> +%_defconfig: > > ... why you can't simply add this to the kconfig variable set a few > lines up? Oh - newer make doesn't like mixing pattern and > non-pattern rules. Yes, my first intention was to add this rule to the kconfig variable. Sadly make does not allows this > Perhaps worth a brief comment, to justify the > redundancy? Sure, will add in the next version. > Or alternatively, how about using $(wildcard ) > instead of a pattern rule, thus rejecting invalid targets right away, > rather than deferring to the recursive make to notice the error? I considered this, but I can't see how $(wildcard ) can be used. AFAIK, $(wildcard ) expects to find a file, matching the wildcard. But %_defconfig is the phony rule, so I can't imagine how to use $(wildcard ) in this case. On other hand, following rule checks the presence of required _defconfig file: %_defconfig: arch/$(SRCARCH)/configs/%_defconfig So, I can do in this way if you wish. BTW, I'll add .PHONY: %_defconfig in the next version. -- Best regards, Volodymyr Babchuk _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
WARNING: multiple messages have this Message-ID (diff)
From: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> To: Jan Beulich <JBeulich@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org>, Andrii Anisov <Andrii_Anisov@epam.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Julien Grall <julien.grall@arm.com>, xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wei.liu2@citrix.com>, Volodymyr Babchuk <Volodymyr_Babchuk@epam.com> Subject: Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets Date: Wed, 15 May 2019 19:07:57 +0000 [thread overview] Message-ID: <87bm038rjn.fsf@epam.com> (raw) Message-ID: <20190515190757.4Fvd3cCWMIitav3CefwTSpmJMifq6JHSeJDp4vtvSfw@z> (raw) In-Reply-To: <5CDBBEB5020000780022F176@prv1-mh.provo.novell.com> Hello Jan, Jan Beulich writes: >>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@epam.com> wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \ >> $(kconfig): >> $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@ > > So the rule you add matches this one. Is there a reason ... > >> +%_defconfig: > > ... why you can't simply add this to the kconfig variable set a few > lines up? Oh - newer make doesn't like mixing pattern and > non-pattern rules. Yes, my first intention was to add this rule to the kconfig variable. Sadly make does not allows this > Perhaps worth a brief comment, to justify the > redundancy? Sure, will add in the next version. > Or alternatively, how about using $(wildcard ) > instead of a pattern rule, thus rejecting invalid targets right away, > rather than deferring to the recursive make to notice the error? I considered this, but I can't see how $(wildcard ) can be used. AFAIK, $(wildcard ) expects to find a file, matching the wildcard. But %_defconfig is the phony rule, so I can't imagine how to use $(wildcard ) in this case. On other hand, following rule checks the presence of required _defconfig file: %_defconfig: arch/$(SRCARCH)/configs/%_defconfig So, I can do in this way if you wish. BTW, I'll add .PHONY: %_defconfig in the next version. -- Best regards, Volodymyr Babchuk _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-05-15 19:08 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-05-14 18:45 [PATCH v1 1/2] makefile: add support for *_defconfig targets Volodymyr Babchuk 2019-05-14 18:45 ` [Xen-devel] " Volodymyr Babchuk 2019-05-14 18:45 ` [PATCH v1 2/2] arm: rename tiny64.conf to tiny64_defconfig Volodymyr Babchuk 2019-05-14 18:45 ` [Xen-devel] " Volodymyr Babchuk 2019-05-15 7:24 ` [PATCH v1 1/2] makefile: add support for *_defconfig targets Jan Beulich 2019-05-15 7:24 ` [Xen-devel] " Jan Beulich 2019-05-15 19:07 ` Volodymyr Babchuk [this message] 2019-05-15 19:07 ` Volodymyr Babchuk 2019-05-16 7:21 ` Jan Beulich 2019-05-16 7:21 ` [Xen-devel] " Jan Beulich
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87bm038rjn.fsf@epam.com \ --to=volodymyr_babchuk@epam.com \ --cc=Andrii_Anisov@epam.com \ --cc=George.Dunlap@eu.citrix.com \ --cc=Ian.Jackson@eu.citrix.com \ --cc=JBeulich@suse.com \ --cc=andrew.cooper3@citrix.com \ --cc=julien.grall@arm.com \ --cc=konrad.wilk@oracle.com \ --cc=sstabellini@kernel.org \ --cc=tim@xen.org \ --cc=wei.liu2@citrix.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).