Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets

From: "Jan Beulich" <JBeulich@suse.com>
To: "Volodymyr Babchuk" <volodymyr_babchuk@epam.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	Wei Liu <wei.liu2@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Julien Grall <julien.grall@arm.com>,
	xen-devel <xen-devel@lists.xenproject.org>,
	"andrii_anisov@epam.com" <andrii_anisov@epam.com>
Subject: Re: [Xen-devel] [PATCH v1 1/2] makefile: add support for *_defconfig targets
Date: Thu, 16 May 2019 01:21:58 -0600	[thread overview]
Message-ID: <5CDD0F96020000780022F740@prv1-mh.provo.novell.com> (raw)
Message-ID: <20190516072158.5c2c3PJMdceMh2aSChFmLekVFPqqrERWTt4zOHjmaH0@z> (raw)
In-Reply-To: <87bm038rjn.fsf@epam.com>

>>> On 15.05.19 at 21:07, <Volodymyr_Babchuk@epam.com> wrote:

> Hello Jan,
> 
> Jan Beulich writes:
> 
>>>>> On 14.05.19 at 20:45, <Volodymyr_Babchuk@epam.com> wrote:
>>> --- a/xen/Makefile
>>> +++ b/xen/Makefile
>>> @@ -269,6 +269,9 @@ kconfig := silentoldconfig oldconfig config menuconfig 
> defconfig \
>>>  $(kconfig):
>>>  	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) 
> SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
>>
>> So the rule you add matches this one. Is there a reason ...
>>
>>> +%_defconfig:
>>
>> ... why you can't simply add this to the kconfig variable set a few
>> lines up? Oh - newer make doesn't like mixing pattern and
>> non-pattern rules.
> Yes, my first intention was to add this rule to the kconfig variable.
> Sadly make does not allows this
> 
>> Perhaps worth a brief comment, to justify the
>> redundancy?
> Sure, will add in the next version.
> 
>> Or alternatively, how about using $(wildcard )
>> instead of a pattern rule, thus rejecting invalid targets right away,
>> rather than deferring to the recursive make to notice the error?
> I considered this, but I can't see how $(wildcard ) can be used.
> AFAIK, $(wildcard ) expects to find a file, matching the wildcard.
> But %_defconfig is the phony rule, so I can't imagine how to use
> $(wildcard ) in this case.
> 
> On other hand, following rule checks the presence of required _defconfig 
> file:
> 
> %_defconfig: arch/$(SRCARCH)/configs/%_defconfig

And similarly I'd expect $(wildcard arch/$(SRCARCH)/configs/*_defconfig)
to work as suggested (wrapped in $(notdir ...) to strip the path).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel